From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: [PATCH] ASoC: ti: delete some dead code in omap_abe_probe()
Date: Wed, 30 Jun 2021 14:18:53 +0300 [thread overview]
Message-ID: <YNxTHXz58dhgbFtG@mwanda> (raw)
This code checks "priv->mclk_freq" twice and the second check is not
required. The code is left over from when removed support for legacy
boot.
Fixes: 8fe120b5a665 ("ASoC: omap-abe-twl6040: Remove support for pdata (legacy boot)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/ti/omap-abe-twl6040.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/soc/ti/omap-abe-twl6040.c b/sound/soc/ti/omap-abe-twl6040.c
index 91cc9a4f44d7..2e3d1eea77c1 100644
--- a/sound/soc/ti/omap-abe-twl6040.c
+++ b/sound/soc/ti/omap-abe-twl6040.c
@@ -292,11 +292,6 @@ static int omap_abe_probe(struct platform_device *pdev)
card->fully_routed = 1;
- if (!priv->mclk_freq) {
- dev_err(&pdev->dev, "MCLK frequency missing\n");
- return -ENODEV;
- }
-
card->dai_link = priv->dai_links;
card->num_links = num_links;
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] ASoC: ti: delete some dead code in omap_abe_probe()
Date: Wed, 30 Jun 2021 14:18:53 +0300 [thread overview]
Message-ID: <YNxTHXz58dhgbFtG@mwanda> (raw)
This code checks "priv->mclk_freq" twice and the second check is not
required. The code is left over from when removed support for legacy
boot.
Fixes: 8fe120b5a665 ("ASoC: omap-abe-twl6040: Remove support for pdata (legacy boot)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/ti/omap-abe-twl6040.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/soc/ti/omap-abe-twl6040.c b/sound/soc/ti/omap-abe-twl6040.c
index 91cc9a4f44d7..2e3d1eea77c1 100644
--- a/sound/soc/ti/omap-abe-twl6040.c
+++ b/sound/soc/ti/omap-abe-twl6040.c
@@ -292,11 +292,6 @@ static int omap_abe_probe(struct platform_device *pdev)
card->fully_routed = 1;
- if (!priv->mclk_freq) {
- dev_err(&pdev->dev, "MCLK frequency missing\n");
- return -ENODEV;
- }
-
card->dai_link = priv->dai_links;
card->num_links = num_links;
--
2.30.2
next reply other threads:[~2021-06-30 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 11:18 Dan Carpenter [this message]
2021-06-30 11:18 ` [PATCH] ASoC: ti: delete some dead code in omap_abe_probe() Dan Carpenter
2021-06-30 14:04 ` Péter Ujfalusi
2021-06-30 14:04 ` Péter Ujfalusi
2021-07-12 10:45 ` Mark Brown
2021-07-12 10:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNxTHXz58dhgbFtG@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.