From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function
Date: Wed, 14 Jul 2021 13:25:22 +0300 [thread overview]
Message-ID: <YO67kjKArYFJS5WD@intel.com> (raw)
In-Reply-To: <20210714080002.26107-1-vidya.srinivas@intel.com>
On Wed, Jul 14, 2021 at 01:30:02PM +0530, Vidya Srinivas wrote:
> Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.
>
> is_6bpc is supposed to return false if connector is not eDP or DSI.
> The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI
> By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI
> was being used.
Instead of these incomplete hacks why aren't we just turning
off dithering when doing crc capture?
>
> Credits-to: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_plane_alpha_blend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index a3529dc2190f..8020216c1594 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
> return false;
>
> c = output->config.connector;
> - if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> + if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
> c->connector_type != DRM_MODE_CONNECTOR_DSI)
> return false;
>
> --
> 2.32.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-07-14 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 8:00 [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function Vidya Srinivas
2021-07-14 8:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-14 10:04 ` [igt-dev] [PATCH i-g-t] " Ramalingam C
2021-07-14 11:22 ` Srinivas, Vidya
2021-07-14 10:25 ` Ville Syrjälä [this message]
2021-07-14 11:21 ` Srinivas, Vidya
2021-07-14 13:03 ` Ville Syrjälä
2021-07-14 13:22 ` Srinivas, Vidya
2021-07-14 14:27 ` Ville Syrjälä
2021-07-14 15:01 ` Srinivas, Vidya
2021-07-15 3:05 ` Ville Syrjälä
2021-07-15 3:50 ` Srinivas, Vidya
2021-07-22 13:40 ` Srinivas, Vidya
2021-07-14 16:09 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO67kjKArYFJS5WD@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.