All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function
@ 2021-07-14  8:00 Vidya Srinivas
  2021-07-14  8:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Vidya Srinivas @ 2021-07-14  8:00 UTC (permalink / raw)
  To: igt-dev

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI.
The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI
By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI
was being used.

Credits-to: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index a3529dc2190f..8020216c1594 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-07-22 13:40 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14  8:00 [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function Vidya Srinivas
2021-07-14  8:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-14 10:04 ` [igt-dev] [PATCH i-g-t] " Ramalingam C
2021-07-14 11:22   ` Srinivas, Vidya
2021-07-14 10:25 ` Ville Syrjälä
2021-07-14 11:21   ` Srinivas, Vidya
2021-07-14 13:03     ` Ville Syrjälä
2021-07-14 13:22       ` Srinivas, Vidya
2021-07-14 14:27         ` Ville Syrjälä
2021-07-14 15:01           ` Srinivas, Vidya
2021-07-15  3:05             ` Ville Syrjälä
2021-07-15  3:50               ` Srinivas, Vidya
2021-07-22 13:40                 ` Srinivas, Vidya
2021-07-14 16:09 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.