From: Petr Vorel <pvorel@suse.cz>
To: Daniel Kiper <daniel.kiper@oracle.com>,
grub-devel@gnu.org, Michael Chang <mchang@suse.com>,
Mike Gilbert <floppym@gentoo.org>, Jeff Mahoney <jeffm@suse.com>
Subject: Re: [PATCH 1/2] osdep: Introduce major.h and use it
Date: Wed, 14 Jul 2021 16:47:24 +0200 [thread overview]
Message-ID: <YO74/IBgKizbBzeE@pevik> (raw)
In-Reply-To: <YO738x/0yjIirdl0@pevik>
Hi Daniel,
...
> > > +/*
> > > + * Fix for glibc 2.25 is deprecating the namespace pollution of sys/types.h
> > > + * injecting major(), minor(), and makedev() into the compilation environment.
> > > + * See configure.ac.
> > It seems to me "See configure.ac." is not relevant in the GRUB source.
> > So, probably it should be replaced with some text from glibc configure.ac.
> I didn't know how to link AC_HEADER_MAJOR with include/grub/osdep/major.h.
> Because in the future when glibc 2.25 is old enough the header will be removed
> and AC_HEADER_MAJOR might be left in configure.ac (name is different from
> MAJOR_IN_{MKDEV,SYSMACROS}). But I can note this in commit message instead.
But thinking about it twice also note in configure.ac instead (+ commit message)
would be good. But that's just a minor detail.
Kind regards,
Petr
> Kind regards,
> Petr
> > Daniel
next prev parent reply other threads:[~2021-07-14 14:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:55 [PATCH 0/2] linux: use stat instead of udevadm for partition lookup + cleanup Petr Vorel
2021-07-08 15:55 ` [PATCH 1/2] osdep: Introduce major.h and use it Petr Vorel
2021-07-13 17:36 ` Daniel Kiper
2021-07-13 19:07 ` Petr Vorel
2021-07-14 6:54 ` Petr Vorel
2021-07-14 12:55 ` Daniel Kiper
2021-07-14 14:42 ` Petr Vorel
2021-07-14 14:47 ` Petr Vorel [this message]
2021-07-08 15:55 ` [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup Petr Vorel
2021-07-13 9:25 ` Paul Menzel
2021-07-13 10:52 ` Petr Vorel
2021-07-14 6:24 ` Michael Chang
2021-07-14 6:45 ` Petr Vorel
2021-07-14 4:16 ` Michael Chang
2021-07-13 17:48 ` Daniel Kiper
2021-07-13 18:03 ` Jeff Mahoney
2021-07-13 19:10 ` Petr Vorel
2021-07-14 13:00 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO74/IBgKizbBzeE@pevik \
--to=pvorel@suse.cz \
--cc=daniel.kiper@oracle.com \
--cc=floppym@gentoo.org \
--cc=grub-devel@gnu.org \
--cc=jeffm@suse.com \
--cc=mchang@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.