From: Ming Lei <ming.lei@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 2/2] nvme-fc: Wait with a timeout for queue to freeze
Date: Wed, 7 Jul 2021 10:46:15 +0800 [thread overview]
Message-ID: <YOUVdx6VasZNANvW@T590> (raw)
In-Reply-To: <20210706122121.qicyihexk2qawvef@beryllium.lan>
On Tue, Jul 06, 2021 at 02:21:21PM +0200, Daniel Wagner wrote:
> A nvme_start_freeze() before nvme_wait_freeze() fixes the hangers. It is this
> simple?
Yeah, it can be the issue, also nvme_start_freeze() has to be paired
with nvme_unfreeze().
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 2/2] nvme-fc: Wait with a timeout for queue to freeze
Date: Wed, 7 Jul 2021 10:46:15 +0800 [thread overview]
Message-ID: <YOUVdx6VasZNANvW@T590> (raw)
In-Reply-To: <20210706122121.qicyihexk2qawvef@beryllium.lan>
On Tue, Jul 06, 2021 at 02:21:21PM +0200, Daniel Wagner wrote:
> A nvme_start_freeze() before nvme_wait_freeze() fixes the hangers. It is this
> simple?
Yeah, it can be the issue, also nvme_start_freeze() has to be paired
with nvme_unfreeze().
Thanks,
Ming
next prev parent reply other threads:[~2021-07-07 2:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 10:16 [PATCH 0/2] Handle update hardware queues and queue freeze more carefully Daniel Wagner
2021-06-25 10:16 ` Daniel Wagner
2021-06-25 10:16 ` [PATCH 1/2] nvme-fc: Update hardware queues before using them Daniel Wagner
2021-06-25 10:16 ` Daniel Wagner
2021-06-27 13:47 ` James Smart
2021-06-27 13:47 ` James Smart
2021-06-29 1:32 ` Ming Lei
2021-06-29 1:32 ` Ming Lei
2021-06-29 12:31 ` Hannes Reinecke
2021-06-29 12:31 ` Hannes Reinecke
2021-06-25 10:16 ` [PATCH 2/2] nvme-fc: Wait with a timeout for queue to freeze Daniel Wagner
2021-06-25 10:16 ` Daniel Wagner
2021-06-27 14:04 ` James Smart
2021-06-27 14:04 ` James Smart
2021-06-29 1:39 ` Ming Lei
2021-06-29 1:39 ` Ming Lei
2021-06-29 7:48 ` Daniel Wagner
2021-06-29 7:48 ` Daniel Wagner
2021-07-05 16:34 ` Daniel Wagner
2021-07-05 16:34 ` Daniel Wagner
2021-07-06 7:29 ` Ming Lei
2021-07-06 7:29 ` Ming Lei
2021-07-06 8:10 ` Daniel Wagner
2021-07-06 8:10 ` Daniel Wagner
2021-07-06 8:45 ` Ming Lei
2021-07-06 8:45 ` Ming Lei
2021-07-06 8:59 ` Daniel Wagner
2021-07-06 8:59 ` Daniel Wagner
2021-07-06 12:21 ` Daniel Wagner
2021-07-06 12:21 ` Daniel Wagner
2021-07-07 2:46 ` Ming Lei [this message]
2021-07-07 2:46 ` Ming Lei
2021-06-29 12:31 ` Hannes Reinecke
2021-06-29 12:31 ` Hannes Reinecke
2021-06-25 12:21 ` [PATCH 0/2] Handle update hardware queues and queue freeze more carefully Daniel Wagner
2021-06-25 12:21 ` Daniel Wagner
2021-06-25 13:00 ` Ming Lei
2021-06-25 13:00 ` Ming Lei
2021-06-29 1:31 ` Ming Lei
2021-06-29 1:31 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOUVdx6VasZNANvW@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.