From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] gethostid: Rewrite with newlib and use/test sethostid
Date: Thu, 8 Jul 2021 13:58:35 +0200 [thread overview]
Message-ID: <YOboa9GY1eL+HR99@yuki> (raw)
In-Reply-To: <16e18b1d-93c7-9885-9485-c2d08c17c02d@huawei.com>
Hi!
> > I made some refine and pushed, thanks!
> Thanks for your review. Besides, I noticed the CI fails to be compiled
> on Apine. The difference appears to be caused by the underlying libc
> implementation: glibc and Alpine's musl-libc.
>
> Is there anything that needs to be modified for this patch? Or simply
> ignore it in the CI script.
This has to be fixed, the whole point of the CI is to catch build
failures on different libc/compiler combinations.
Looking at musl the sethostid() is not implemented at all, so I guess
that the correct solution here would be adding a configure check for
sethostid() and skip the whole test if it's not available.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-08 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 8:07 [LTP] [PATCH] gethostid: Rewrite with newlib and use/test sethostid Xie Ziyao
2021-07-08 10:18 ` Li Wang
2021-07-08 11:38 ` Xie Ziyao
2021-07-08 11:58 ` Cyril Hrubis [this message]
2021-07-08 13:17 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOboa9GY1eL+HR99@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.