Re: [PATCH v2] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Jordan Crouse <jordan@cosmicpenguin.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Adrien Grassein <adrien.grassein@gmail.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Yangtao Li <tiny.windzz@gmail.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Abhinav Kumar <abhinavk@codeaurora.org>,
	Pi-Hsun Shih <pihsun@chromium.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Paul <sean@poorly.run>, Xin Ji <xji@analogixsemi.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Robert Foss <robert.foss@linaro.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
Date: Mon, 26 Jul 2021 15:40:57 +0200	[thread overview]
Message-ID: <YP67aeAOIVgpMdca@ravnborg.org> (raw)
In-Reply-To: <CANMq1KD_6DoNR9PvO9wrpEQc5BDwx6952mwz0poCw=hu+HsUbw@mail.gmail.com>

Hi Nicolas,

On Mon, Jul 26, 2021 at 08:38:18AM +0800, Nicolas Boichat wrote:
> On Sun, Jul 25, 2021 at 9:31 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:
> > > Many of the DSI flags have names opposite to their actual effects,
> > > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> > > be disabled. Fix this by including _NO_ in the flag names, e.g.
> > > MIPI_DSI_MODE_NO_EOT_PACKET.
> > >
> > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> >
> > Hi Nicolas,
> >
> > in this thread:
> > https://lore.kernel.org/dri-devel/20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid/
> > I see that several people added their Reviewed-by.
> >
> > Please either add the tgas if missing, or elaborate why you left them out.
> 
> Oh simple, I just forgot.
Yeah, know that feeling.
> 
> I regenerated the patch so it's a bit different from v1... Not 100%
> sure if I can add those, since those were for the overall patch:
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@samsung.com>.
> 
> Those 2 shouldn't be a problem:
> Reviewed-by: Xin Ji <xji@analogixsemi.com> # anx7625.c
> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> # msm/dsi
> 
> > I was suprised this had not landed yet.
> 
> Yep. Let me know if you want me to send a v3 with those tags.
Please resend a v3 with the tags.

	Sam

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek