All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Kyung Min Park <kyung.min.park@intel.com>
Cc: ravi.v.shankar@intel.com, ashok.raj@intel.com,
	dwmw2@infradead.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, will@kernel.org
Subject: Re: [PATCH v2] iommu/vt-d: Dump DMAR translation structure
Date: Mon, 26 Jul 2021 14:25:39 +0200	[thread overview]
Message-ID: <YP6pw9j8i3bGOb13@8bytes.org> (raw)
In-Reply-To: <20210722042453.10579-1-kyung.min.park@intel.com>

On Wed, Jul 21, 2021 at 09:24:53PM -0700, Kyung Min Park wrote:
> When the dmar translation fault happens, the kernel prints a single line
> fault reason with corresponding hexadecimal code defined in the Intel VT-d
> specification.
> 
> Currently, when user wants to debug the translation fault in detail,
> debugfs is used for dumping the dmar_translation_struct, which is not
> available when the kernel failed to boot.
> 
> Dump the DMAR translation structure, pagewalk the IO page table and print
> the page table entry when the fault happens.
> 
> Signed-off-by: Kyung Min Park <kyung.min.park@intel.com>

This is too much noise in dmesg for a single dmar fault. Please hide
that additional debug information behind a debug kernel option for the
VT-d driver.

Thanks,
	
	Joerg

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Kyung Min Park <kyung.min.park@intel.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	baolu.lu@linux.intel.com, dwmw2@infradead.org, will@kernel.org,
	yian.chen@intel.com, sohil.mehta@intel.com,
	ravi.v.shankar@intel.com, ashok.raj@intel.com
Subject: Re: [PATCH v2] iommu/vt-d: Dump DMAR translation structure
Date: Mon, 26 Jul 2021 14:25:39 +0200	[thread overview]
Message-ID: <YP6pw9j8i3bGOb13@8bytes.org> (raw)
In-Reply-To: <20210722042453.10579-1-kyung.min.park@intel.com>

On Wed, Jul 21, 2021 at 09:24:53PM -0700, Kyung Min Park wrote:
> When the dmar translation fault happens, the kernel prints a single line
> fault reason with corresponding hexadecimal code defined in the Intel VT-d
> specification.
> 
> Currently, when user wants to debug the translation fault in detail,
> debugfs is used for dumping the dmar_translation_struct, which is not
> available when the kernel failed to boot.
> 
> Dump the DMAR translation structure, pagewalk the IO page table and print
> the page table entry when the fault happens.
> 
> Signed-off-by: Kyung Min Park <kyung.min.park@intel.com>

This is too much noise in dmesg for a single dmar fault. Please hide
that additional debug information behind a debug kernel option for the
VT-d driver.

Thanks,
	
	Joerg


  reply	other threads:[~2021-07-26 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  4:24 [PATCH v2] iommu/vt-d: Dump DMAR translation structure Kyung Min Park
2021-07-22  4:24 ` Kyung Min Park
2021-07-26 12:25 ` Joerg Roedel [this message]
2021-07-26 12:25   ` Joerg Roedel
2021-07-30 23:51   ` Kyung Min Park
2021-07-30 23:51     ` Kyung Min Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP6pw9j8i3bGOb13@8bytes.org \
    --to=joro@8bytes.org \
    --cc=ashok.raj@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kyung.min.park@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.