From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
newbyte@disroot.org, Stephan Gerhold <stephan@gerhold.net>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3] backlight: ktd253: Stabilize backlight
Date: Thu, 15 Jul 2021 12:20:52 +0100 [thread overview]
Message-ID: <YPAaFMC62hApTG9g@google.com> (raw)
In-Reply-To: <CACRpkdbacfR52__8ZuwWV3B56w1KTvhOKe2_7OiVdPoLXrWbnQ@mail.gmail.com>
On Tue, 13 Jul 2021, Linus Walleij wrote:
> On Fri, Jun 4, 2021 at 8:34 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > Remove interrupt disablement during backlight setting. It is
> > way to dangerous and makes platforms instable by having it
> > miss vblank IRQs leading to the graphics derailing.
> >
> > The code is using ndelay() which is not available on
> > platforms such as ARM and will result in 32 * udelay(1)
> > which is substantial.
> >
> > Add some code to detect if an interrupt occurs during the
> > tight loop and in that case just redo it from the top.
> >
> > Fixes: 5317f37e48b9 ("backlight: Add Kinetic KTD253 backlight driver")
> > Cc: Stephan Gerhold <stephan@gerhold.net>
> > Reported-by: newbyte@disroot.org
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hm it seems this patch did not make it into v5.14-rc1, could it be applied
> as a fix for the -rc:s?
Ah, it was sent late in the cycle, so I postponed it.
> Shall I resend it with Daniel's ACK?
Yes please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-07-15 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 6:32 [PATCH v3] backlight: ktd253: Stabilize backlight Linus Walleij
2021-06-07 11:11 ` Daniel Thompson
2021-07-13 15:37 ` Linus Walleij
2021-07-15 11:20 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPAaFMC62hApTG9g@google.com \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=newbyte@disroot.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.