All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Fei Shao <fshao@chromium.org>
Cc: Gene Chen <gene_chen@richtek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] mfd: mt6360: Restore error message to regmap_read failure
Date: Fri, 16 Jul 2021 09:03:49 +0100	[thread overview]
Message-ID: <YPE9ZSu1lYtRb1DA@google.com> (raw)
In-Reply-To: <20210629094339.874120-2-fshao@chromium.org>

On Tue, 29 Jun 2021, Fei Shao wrote:

> This adds back a missing error message for better log readability.
> 
> Fixes: e84702940613 ("mfd: mt6360: Fix flow which is used to check ic
> exist")
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
> 
>  drivers/mfd/mt6360-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 6eaa6775b888..0ff8dae4536c 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -351,8 +351,10 @@ static int mt6360_check_vendor_info(struct mt6360_ddata *ddata)
>  	int ret;
>  
>  	ret = regmap_read(ddata->regmap, MT6360_PMU_DEV_INFO, &info);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		dev_err(ddata->dev, "Failed to read device info from regmap\n");

I'm not fussed about this change either, but if you insist, please
change the commit message to be a little more generic.  Users don't
care about Regmaps and developers can grep it in the source.

Suggest: "Failed to fetch device information from H/W"

>  		return ret;
> +	}
>  
>  	if ((info & CHIP_VEN_MASK) != CHIP_VEN_MT6360) {
>  		dev_err(ddata->dev, "Device not supported\n");

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Fei Shao <fshao@chromium.org>
Cc: Gene Chen <gene_chen@richtek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] mfd: mt6360: Restore error message to regmap_read failure
Date: Fri, 16 Jul 2021 09:03:49 +0100	[thread overview]
Message-ID: <YPE9ZSu1lYtRb1DA@google.com> (raw)
In-Reply-To: <20210629094339.874120-2-fshao@chromium.org>

On Tue, 29 Jun 2021, Fei Shao wrote:

> This adds back a missing error message for better log readability.
> 
> Fixes: e84702940613 ("mfd: mt6360: Fix flow which is used to check ic
> exist")
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
> 
>  drivers/mfd/mt6360-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 6eaa6775b888..0ff8dae4536c 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -351,8 +351,10 @@ static int mt6360_check_vendor_info(struct mt6360_ddata *ddata)
>  	int ret;
>  
>  	ret = regmap_read(ddata->regmap, MT6360_PMU_DEV_INFO, &info);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		dev_err(ddata->dev, "Failed to read device info from regmap\n");

I'm not fussed about this change either, but if you insist, please
change the commit message to be a little more generic.  Users don't
care about Regmaps and developers can grep it in the source.

Suggest: "Failed to fetch device information from H/W"

>  		return ret;
> +	}
>  
>  	if ((info & CHIP_VEN_MASK) != CHIP_VEN_MT6360) {
>  		dev_err(ddata->dev, "Device not supported\n");

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Fei Shao <fshao@chromium.org>
Cc: Gene Chen <gene_chen@richtek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] mfd: mt6360: Restore error message to regmap_read failure
Date: Fri, 16 Jul 2021 09:03:49 +0100	[thread overview]
Message-ID: <YPE9ZSu1lYtRb1DA@google.com> (raw)
In-Reply-To: <20210629094339.874120-2-fshao@chromium.org>

On Tue, 29 Jun 2021, Fei Shao wrote:

> This adds back a missing error message for better log readability.
> 
> Fixes: e84702940613 ("mfd: mt6360: Fix flow which is used to check ic
> exist")
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
> 
>  drivers/mfd/mt6360-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 6eaa6775b888..0ff8dae4536c 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -351,8 +351,10 @@ static int mt6360_check_vendor_info(struct mt6360_ddata *ddata)
>  	int ret;
>  
>  	ret = regmap_read(ddata->regmap, MT6360_PMU_DEV_INFO, &info);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		dev_err(ddata->dev, "Failed to read device info from regmap\n");

I'm not fussed about this change either, but if you insist, please
change the commit message to be a little more generic.  Users don't
care about Regmaps and developers can grep it in the source.

Suggest: "Failed to fetch device information from H/W"

>  		return ret;
> +	}
>  
>  	if ((info & CHIP_VEN_MASK) != CHIP_VEN_MT6360) {
>  		dev_err(ddata->dev, "Device not supported\n");

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2021-07-16  8:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  9:43 [PATCH 1/2] mfd: mt6360: Sort regulator resources Fei Shao
2021-06-29  9:43 ` Fei Shao
2021-06-29  9:43 ` Fei Shao
2021-06-29  9:43 ` [PATCH 2/2] mfd: mt6360: Restore error message to regmap_read failure Fei Shao
2021-06-29  9:43   ` Fei Shao
2021-06-29  9:43   ` Fei Shao
2021-07-02  4:52   ` Tzung-Bi Shih
2021-07-02  4:52     ` Tzung-Bi Shih
2021-07-02  4:52     ` Tzung-Bi Shih
2021-07-16  8:03   ` Lee Jones [this message]
2021-07-16  8:03     ` Lee Jones
2021-07-16  8:03     ` Lee Jones
2021-07-16 10:23     ` Fei Shao
2021-07-16 10:23       ` Fei Shao
2021-07-16 10:23       ` Fei Shao
2021-07-02  4:52 ` [PATCH 1/2] mfd: mt6360: Sort regulator resources Tzung-Bi Shih
2021-07-02  4:52   ` Tzung-Bi Shih
2021-07-02  4:52   ` Tzung-Bi Shih
2021-07-16  8:01 ` Lee Jones
2021-07-16  8:01   ` Lee Jones
2021-07-16  8:01   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPE9ZSu1lYtRb1DA@google.com \
    --to=lee.jones@linaro.org \
    --cc=fshao@chromium.org \
    --cc=gene_chen@richtek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.