From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: stable@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: let's keep writing IOs on SBI_NEED_FSCK
Date: Mon, 19 Jul 2021 11:49:57 -0700 [thread overview]
Message-ID: <YPXJVWflOq1lwoL2@google.com> (raw)
In-Reply-To: <ae44f40d-4727-92af-9f0b-ffb8540da872@kernel.org>
On 07/19, Chao Yu wrote:
> On 2021/7/15 7:18, Jaegeuk Kim wrote:
> > SBI_NEED_FSCK is an indicator that fsck.f2fs needs to be triggered, so it
> > is not fully critical to stop any IO writes. So, let's allow to write data
> > instead of reporting EIO forever given SBI_NEED_FSCK.
>
> Well, it looks we need to check why there is SBI_NEED_FSCK flag.
>
> If this patch breaks something, how about forcing OPU if SBI_NEED_FSCK
> was set?
Yea, let me take that.
>
> >
> > Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal")
> > Cc: <stable@kernel.org> # v5.13+
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/segment.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 15cc89eef28d..f9b7fb785e1d 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -3563,7 +3563,7 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
> > goto drop_bio;
> > }
> > - if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) || f2fs_cp_error(sbi)) {
> > + if (f2fs_cp_error(sbi)) {
> > err = -EIO;
> > goto drop_bio;
> > }
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, stable@kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: let's keep writing IOs on SBI_NEED_FSCK
Date: Mon, 19 Jul 2021 11:49:57 -0700 [thread overview]
Message-ID: <YPXJVWflOq1lwoL2@google.com> (raw)
In-Reply-To: <ae44f40d-4727-92af-9f0b-ffb8540da872@kernel.org>
On 07/19, Chao Yu wrote:
> On 2021/7/15 7:18, Jaegeuk Kim wrote:
> > SBI_NEED_FSCK is an indicator that fsck.f2fs needs to be triggered, so it
> > is not fully critical to stop any IO writes. So, let's allow to write data
> > instead of reporting EIO forever given SBI_NEED_FSCK.
>
> Well, it looks we need to check why there is SBI_NEED_FSCK flag.
>
> If this patch breaks something, how about forcing OPU if SBI_NEED_FSCK
> was set?
Yea, let me take that.
>
> >
> > Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal")
> > Cc: <stable@kernel.org> # v5.13+
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/segment.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 15cc89eef28d..f9b7fb785e1d 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -3563,7 +3563,7 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
> > goto drop_bio;
> > }
> > - if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) || f2fs_cp_error(sbi)) {
> > + if (f2fs_cp_error(sbi)) {
> > err = -EIO;
> > goto drop_bio;
> > }
> >
next prev parent reply other threads:[~2021-07-19 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 23:18 [f2fs-dev] [PATCH] f2fs: let's keep writing IOs on SBI_NEED_FSCK Jaegeuk Kim
2021-07-14 23:18 ` Jaegeuk Kim
2021-07-19 8:23 ` [f2fs-dev] " Chao Yu
2021-07-19 8:23 ` Chao Yu
2021-07-19 18:49 ` Jaegeuk Kim [this message]
2021-07-19 18:49 ` Jaegeuk Kim
2021-07-19 18:50 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim
2021-07-19 18:50 ` Jaegeuk Kim
2021-07-20 1:04 ` [f2fs-dev] " Chao Yu
2021-07-20 1:04 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPXJVWflOq1lwoL2@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.