From: Christoph Hellwig <hch@infradead.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions
Date: Wed, 21 Jul 2021 07:45:48 +0100 [thread overview]
Message-ID: <YPfCnIfVmolgfMPF@infradead.org> (raw)
In-Reply-To: <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com>
> +/**
> + * ib_create_qp_kernel - Creates a kernel QP associated with the specified
Any reason this function is renamed? This seems rather unrelated to
the rest of th patch.
> + * protection domain.
> * @pd: The protection domain associated with the QP.
> * @qp_init_attr: A list of initial attributes required to create the
> * QP. If QP creation succeeds, then the attributes are updated to
> * the actual capabilities of the created QP.
> * @caller: caller's build-time module name
> - *
> - * NOTE: for user qp use ib_create_qp_user with valid udata!
> */
Also a kerneldoc comment for a function that is an implementation
detail is actively harmful. Please document ib_create_qp instead.
next prev parent reply other threads:[~2021-07-21 6:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:12 [PATCH rdma-next 0/7] Separate user/kernel QP creation logic Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 1/7] RDMA/mlx5: Delete not-available udata check Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 2/7] RDMA/core: Delete duplicated and unreachable code Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage Leon Romanovsky
2021-07-21 6:41 ` Christoph Hellwig
2021-07-21 6:56 ` Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions Leon Romanovsky
2021-07-21 6:45 ` Christoph Hellwig [this message]
2021-07-21 6:58 ` Leon Romanovsky
2021-07-21 7:47 ` Mark Zhang
2021-07-21 7:49 ` Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 5/7] RDMA/core: Configure selinux QP during creation Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 6/7] RDMA/core: Properly increment and decrement QP usecnts Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs Leon Romanovsky
2021-07-21 6:48 ` Christoph Hellwig
2021-07-21 7:06 ` Leon Romanovsky
2021-07-21 7:12 ` Christoph Hellwig
2021-07-21 7:20 ` Christoph Hellwig
2021-07-21 7:31 ` Leon Romanovsky
2021-07-21 7:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPfCnIfVmolgfMPF@infradead.org \
--to=hch@infradead.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.