All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage
Date: Wed, 21 Jul 2021 09:56:54 +0300	[thread overview]
Message-ID: <YPfFNvdw/UPNR9Mb@unreal> (raw)
In-Reply-To: <YPfBiDdghnRwSjwG@infradead.org>

On Wed, Jul 21, 2021 at 07:41:12AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 09:13:02AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> > 
> > The ib_create_named_qp() is kernel verb that is not used for user
> > supplied attributes. In such case, it is ULP responsibility to provide
> > valid QP attributes.
> > 
> > In-kernel API shouldn't check it, exactly like other functions that
> > don't check device capabilities.
> 
> Hmm.  These still looks like useful debugging checks.

All in-tree ULPs already set properly based on device capabilities.

Thanks

  reply	other threads:[~2021-07-21  6:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  6:12 [PATCH rdma-next 0/7] Separate user/kernel QP creation logic Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 1/7] RDMA/mlx5: Delete not-available udata check Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 2/7] RDMA/core: Delete duplicated and unreachable code Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage Leon Romanovsky
2021-07-21  6:41   ` Christoph Hellwig
2021-07-21  6:56     ` Leon Romanovsky [this message]
2021-07-21  6:13 ` [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions Leon Romanovsky
2021-07-21  6:45   ` Christoph Hellwig
2021-07-21  6:58     ` Leon Romanovsky
2021-07-21  7:47   ` Mark Zhang
2021-07-21  7:49     ` Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 5/7] RDMA/core: Configure selinux QP during creation Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 6/7] RDMA/core: Properly increment and decrement QP usecnts Leon Romanovsky
2021-07-21  6:13 ` [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs Leon Romanovsky
2021-07-21  6:48   ` Christoph Hellwig
2021-07-21  7:06     ` Leon Romanovsky
2021-07-21  7:12       ` Christoph Hellwig
2021-07-21  7:20         ` Christoph Hellwig
2021-07-21  7:31           ` Leon Romanovsky
2021-07-21  7:30         ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPfFNvdw/UPNR9Mb@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=hch@infradead.org \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=markz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.