From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-spi@vger.kernel.org
Subject: Re: [bug report] spi: pxa2xx: Reuse int_stop_and_reset() in couple of places
Date: Wed, 21 Jul 2021 15:15:33 +0300 [thread overview]
Message-ID: <YPgP5TuvwBh0r5CS@smile.fi.intel.com> (raw)
In-Reply-To: <20210721113246.GA24694@kili>
On Wed, Jul 21, 2021 at 04:32:46AM -0700, Dan Carpenter wrote:
> Hello Andy Shevchenko,
>
> The patch 3bbdc083262d: "spi: pxa2xx: Reuse int_stop_and_reset() in
> couple of places" from Jul 19, 2021, leads to the following static
> checker warning:
>
> drivers/spi/spi-pxa2xx.c:774 ssp_int()
> error: we previously assumed 'drv_data->controller->cur_msg' could be null (see line 773)
> 773 if (!drv_data->controller->cur_msg) {
> --> 774 handle_bad_msg(drv_data);
> ^^^^^^^^^^^^^^^^^^^^^^^^
> We can't reset with a NULL drv_data->controller->cur_msg.
We can if we handle this inside reset_sccr1() properly.
Thanks for the report and patch on its way!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-21 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 11:32 [bug report] spi: pxa2xx: Reuse int_stop_and_reset() in couple of places Dan Carpenter
2021-07-21 12:15 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPgP5TuvwBh0r5CS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.