From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: linux-rdma@vger.kernel.org, daniel.vetter@ffwll.ch,
sleybo@amazon.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, galpress@amazon.com,
linaro-mm-sig@lists.linaro.org, jgg@ziepe.ca,
dledford@redhat.com, hch@lst.de, amd-gfx@lists.freedesktop.org,
alexander.deucher@amd.com, airlied@gmail.com,
sumit.semwal@linaro.org, christian.koenig@amd.com,
leonro@nvidia.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Add p2p via dmabuf to habanalabs
Date: Wed, 21 Jul 2021 18:10:48 +0200 [thread overview]
Message-ID: <YPhHCIoHzMnbIfeF@kroah.com> (raw)
In-Reply-To: <20210711140601.7472-1-ogabbay@kernel.org>
On Sun, Jul 11, 2021 at 05:05:59PM +0300, Oded Gabbay wrote:
> Hi,
> This is v5 of this patch-set following again a long email thread.
>
> It contains fixes to the implementation according to the review that Jason
> did on v4. Jason, I appreciate your feedback. If you can take another look
> to see I didn't miss anything that would be great.
>
> The details of the fixes are in the changelog in the commit message of
> the second patch.
>
> There was one issue with your proposal to set the orig_nents to 0. I did
> that, but I also had to restore it to nents before calling sg_free_table
> because that function uses orig_nents to iterate.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: linux-kernel@vger.kernel.org, jgg@ziepe.ca,
sumit.semwal@linaro.org, christian.koenig@amd.com,
daniel.vetter@ffwll.ch, galpress@amazon.com, sleybo@amazon.com,
dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
linux-media@vger.kernel.org, dledford@redhat.com,
airlied@gmail.com, alexander.deucher@amd.com, leonro@nvidia.com,
hch@lst.de, amd-gfx@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v5 0/2] Add p2p via dmabuf to habanalabs
Date: Wed, 21 Jul 2021 18:10:48 +0200 [thread overview]
Message-ID: <YPhHCIoHzMnbIfeF@kroah.com> (raw)
In-Reply-To: <20210711140601.7472-1-ogabbay@kernel.org>
On Sun, Jul 11, 2021 at 05:05:59PM +0300, Oded Gabbay wrote:
> Hi,
> This is v5 of this patch-set following again a long email thread.
>
> It contains fixes to the implementation according to the review that Jason
> did on v4. Jason, I appreciate your feedback. If you can take another look
> to see I didn't miss anything that would be great.
>
> The details of the fixes are in the changelog in the commit message of
> the second patch.
>
> There was one issue with your proposal to set the orig_nents to 0. I did
> that, but I also had to restore it to nents before calling sg_free_table
> because that function uses orig_nents to iterate.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: linux-rdma@vger.kernel.org, daniel.vetter@ffwll.ch,
sleybo@amazon.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, galpress@amazon.com,
linaro-mm-sig@lists.linaro.org, jgg@ziepe.ca,
dledford@redhat.com, hch@lst.de, amd-gfx@lists.freedesktop.org,
alexander.deucher@amd.com, christian.koenig@amd.com,
leonro@nvidia.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Add p2p via dmabuf to habanalabs
Date: Wed, 21 Jul 2021 18:10:48 +0200 [thread overview]
Message-ID: <YPhHCIoHzMnbIfeF@kroah.com> (raw)
In-Reply-To: <20210711140601.7472-1-ogabbay@kernel.org>
On Sun, Jul 11, 2021 at 05:05:59PM +0300, Oded Gabbay wrote:
> Hi,
> This is v5 of this patch-set following again a long email thread.
>
> It contains fixes to the implementation according to the review that Jason
> did on v4. Jason, I appreciate your feedback. If you can take another look
> to see I didn't miss anything that would be great.
>
> The details of the fixes are in the changelog in the commit message of
> the second patch.
>
> There was one issue with your proposal to set the orig_nents to 0. I did
> that, but I also had to restore it to nents before calling sg_free_table
> because that function uses orig_nents to iterate.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-07-21 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 14:05 [PATCH v5 0/2] Add p2p via dmabuf to habanalabs Oded Gabbay
2021-07-11 14:05 ` Oded Gabbay
2021-07-11 14:05 ` Oded Gabbay
2021-07-11 14:06 ` [PATCH v5 1/2] habanalabs: define uAPI to export FD for DMA-BUF Oded Gabbay
2021-07-11 14:06 ` Oded Gabbay
2021-07-11 14:06 ` Oded Gabbay
2021-07-11 14:06 ` [PATCH v5 2/2] habanalabs: add support for dma-buf exporter Oded Gabbay
2021-07-11 14:06 ` Oded Gabbay
2021-07-11 14:06 ` Oded Gabbay
2021-07-21 16:10 ` Greg KH [this message]
2021-07-21 16:10 ` [PATCH v5 0/2] Add p2p via dmabuf to habanalabs Greg KH
2021-07-21 16:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPhHCIoHzMnbIfeF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=galpress@amazon.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=leonro@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=sleybo@amazon.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.