[Intel-gfx] [CI] drm/i915/bios: Fix ports mask

[Intel-gfx] [CI] drm/i915/bios: Fix ports mask

[Rodrigo Vivi]

PORT_A to PORT_F are regular integers defined in the enum port,
while for_each_port_masked requires a bit mask for the ports.

Current given mask: 0b111
Desired mask: 0b111111

I noticed this while Christoph was reporting a bug found on headless
GVT configuration which bisect blamed commit 3ae04c0c7e63 ("drm/i915/bios:
limit default outputs to ports A through F")

v2: Avoid unnecessary line continuations as pointed by CI and Christoph

Cc: Christoph Hellwig <hch@infradead.org>
Fixes: 3ae04c0c7e63 ("drm/i915/bios: limit default outputs to ports A through F")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Tested-by: Christoph Hellwig <hch@infradead.org>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 5b6922e28ef2..aa667fa71158 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2166,7 +2166,8 @@ static void
 init_vbt_missing_defaults(struct drm_i915_private *i915)
 {
 	enum port port;
-	int ports = PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F;
+	int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) |
+		    BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
 
 	if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
 		return;
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 4197 bytes --]

== Series Details ==

Series: drm/i915/bios: Fix ports mask (rev2)
URL   : https://patchwork.freedesktop.org/series/92850/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20680
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20680 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20680, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20680:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-bdw-5557u:       NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@i915_pm_rpm@basic-rte.html

  
Known issues
------------

  Here are the changes found in Patchwork_20680 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@query-info:
    - fi-bsw-kefka:       NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html

  * igt@amdgpu/amd_basic@semaphore:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][3] ([fdo#109271]) +25 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][4] ([i915#3718])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - {fi-tgl-1115g4}:    [FAIL][5] ([i915#1888]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-kefka:       [INCOMPLETE][7] ([i915#2782] / [i915#2940]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bsw-kefka/igt@i915_selftest@live@execlists.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][9] ([i915#1372]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
  [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718


Participating hosts (38 -> 35)
------------------------------

  Missing    (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_10371 -> Patchwork_20680

  CI-20190529: 20190529
  CI_DRM_10371: 8e68c13425e29c96ef94c9dd3583159000c61380 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6147: f3994c2cd99a1acfe991a8cc838a387dcb36598a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20680: e1fd6ca0eb59bf30864ec455071ae7082201381b @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

e1fd6ca0eb59 drm/i915/bios: Fix ports mask

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/index.html

[-- Attachment #1.2: Type: text/html, Size: 5057 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev3)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 4279 bytes --]

== Series Details ==

Series: drm/i915/bios: Fix ports mask (rev3)
URL   : https://patchwork.freedesktop.org/series/92850/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20681
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20681 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20681, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20681:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-bdw-5557u:       NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-bdw-5557u/igt@i915_pm_rpm@basic-rte.html

  
Known issues
------------

  Here are the changes found in Patchwork_20681 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@query-info:
    - fi-bsw-kefka:       NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html

  * igt@amdgpu/amd_basic@semaphore:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][3] ([fdo#109271]) +25 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][4] ([i915#3718])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - {fi-tgl-1115g4}:    [FAIL][5] ([i915#1888]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-kefka:       [INCOMPLETE][7] ([i915#2782] / [i915#2940]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-bsw-kefka/igt@i915_selftest@live@execlists.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][9] ([i915#1372]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
  [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718


Participating hosts (38 -> 34)
------------------------------

  Missing    (4): fi-kbl-soraka fi-ilk-m540 fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_10371 -> Patchwork_20681

  CI-20190529: 20190529
  CI_DRM_10371: 8e68c13425e29c96ef94c9dd3583159000c61380 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6147: f3994c2cd99a1acfe991a8cc838a387dcb36598a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20681: cc6994cd19b7cdac4c3f4337be25b3f190303d33 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

cc6994cd19b7 drm/i915/bios: Fix ports mask

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20681/index.html

[-- Attachment #1.2: Type: text/html, Size: 5071 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Fix ports mask (rev2)

[Rodrigo Vivi]

On Thu, Jul 22, 2021 at 03:09:13PM -0000, Patchwork wrote:
>    Patch Details
> 
>    Series:  drm/i915/bios: Fix ports mask (rev2)
>    URL:     [1]https://patchwork.freedesktop.org/series/92850/
>    State:   failure
>    Details:
>    [2]https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/index.html
> 
>            CI Bug Log - changes from CI_DRM_10371 -> Patchwork_20680
> 
> Summary
> 
>    FAILURE
> 
>    Serious unknown changes coming with Patchwork_20680 absolutely need to
>    be
>    verified manually.
> 
>    If you think the reported changes have nothing to do with the changes
>    introduced in Patchwork_20680, please notify your bug team to allow
>    them
>    to document this new failure mode, which will reduce false positives in
>    CI.
> 
>    External URL:
>    https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/index.html
> 
> Possible new issues
> 
>    Here are the unknown changes that may have been introduced in
>    Patchwork_20680:
> 
>   IGT changes
> 
>     Possible regressions
> 
>      * igt@i915_pm_rpm@basic-rte:
>           + fi-bdw-5557u: NOTRUN -> [3]FAIL

Apparently after we moved to -rc2 this test is failing in all platforms.
Unfortunately I couldn't bisect because on the machines I got access it
was failing regardless the kernel that I was using :/

> 
> Known issues
> 
>    Here are the changes found in Patchwork_20680 that come from known
>    issues:
> 
>   IGT changes
> 
>     Issues hit
> 
>      * igt@amdgpu/amd_basic@query-info:
>           + fi-bsw-kefka: NOTRUN -> [4]SKIP ([5]fdo#109271) +17 similar
>             issues
>      * igt@amdgpu/amd_basic@semaphore:
>           + fi-bdw-5557u: NOTRUN -> [6]SKIP ([7]fdo#109271) +25 similar
>             issues
>      * igt@core_hotunplug@unbind-rebind:
>           + fi-bdw-5557u: NOTRUN -> [8]WARN ([9]i915#3718)
> 
>     Possible fixes
> 
>      * igt@gem_exec_suspend@basic-s3:
>           + {fi-tgl-1115g4}: [10]FAIL ([11]i915#1888) -> [12]PASS
>      * igt@i915_selftest@live@execlists:
>           + fi-bsw-kefka: [13]INCOMPLETE ([14]i915#2782 / [15]i915#2940)
>             -> [16]PASS
>      * igt@kms_chamelium@dp-crc-fast:
>           + fi-kbl-7500u: [17]FAIL ([18]i915#1372) -> [19]PASS
> 
>    {name}: This element is suppressed. This means it is ignored when
>    computing
>    the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> Participating hosts (38 -> 35)
> 
>    Missing (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u
> 
> Build changes
> 
>      * Linux: CI_DRM_10371 -> Patchwork_20680
> 
>    CI-20190529: 20190529
>    CI_DRM_10371: 8e68c13425e29c96ef94c9dd3583159000c61380 @
>    git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_6147: f3994c2cd99a1acfe991a8cc838a387dcb36598a @
>    https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>    Patchwork_20680: e1fd6ca0eb59bf30864ec455071ae7082201381b @
>    git://anongit.freedesktop.org/gfx-ci/linux
> 
>    == Linux commits ==
> 
>    e1fd6ca0eb59 drm/i915/bios: Fix ports mask
> 
> References
> 
>    1. https://patchwork.freedesktop.org/series/92850/
>    2. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/index.html
>    3. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@i915_pm_rpm@basic-rte.html
>    4. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
>    5. https://bugs.freedesktop.org/show_bug.cgi?id=109271
>    6. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
>    7. https://bugs.freedesktop.org/show_bug.cgi?id=109271
>    8. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
>    9. https://gitlab.freedesktop.org/drm/intel/issues/3718
>   10. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
>   11. https://gitlab.freedesktop.org/drm/intel/issues/1888
>   12. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
>   13. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
>   14. https://gitlab.freedesktop.org/drm/intel/issues/2782
>   15. https://gitlab.freedesktop.org/drm/intel/issues/2940
>   16. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
>   17. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10371/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
>   18. https://gitlab.freedesktop.org/drm/intel/issues/1372
>   19. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20680/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx