From: Matthias Kaehlcke <mka@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
kbuild-all@lists.01.org, Michal Simek <monstr@monstr.eu>,
linux-usb@vger.kernel.org, Peter Chen <peter.chen@kernel.org>,
Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH v14 4/6] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on'
Date: Thu, 22 Jul 2021 17:17:34 -0700 [thread overview]
Message-ID: <YPoKnkttCyCHHn4T@google.com> (raw)
In-Reply-To: <202107210812.LLUZpfu9-lkp@intel.com>
On Wed, Jul 21, 2021 at 08:46:17AM +0800, kernel test robot wrote:
> Hi Matthias,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on robh/for-next driver-core/driver-core-testing linus/master v5.14-rc2 next-20210720]
> [cannot apply to char-misc/char-misc-testing]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/usb-misc-Add-onboard_usb_hub-driver/20210720-144614
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> config: i386-randconfig-a003-20210720 (attached as .config)
> compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/1ac4caccda0f2e6904b0e1462bc9735c690d719f
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Matthias-Kaehlcke/usb-misc-Add-onboard_usb_hub-driver/20210720-144614
> git checkout 1ac4caccda0f2e6904b0e1462bc9735c690d719f
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> ld: drivers/usb/dwc3/core.o: in function `dwc3_resume_common':
> >> drivers/usb/dwc3/core.c:1853: undefined reference to `dwc3_gadget_resume'
> ld: drivers/usb/dwc3/core.o: in function `dwc3_runtime_resume':
> >> drivers/usb/dwc3/core.c:1912: undefined reference to `dwc3_gadget_process_pending_events'
> ld: drivers/usb/dwc3/core.o: in function `dwc3_suspend_common':
> >> drivers/usb/dwc3/core.c:1750: undefined reference to `dwc3_gadget_suspend'
What happened here is that USB_DWC3 was selected, but one of USB_DWC3_HOST,
USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE.
Typically one of them would be selected by:
choice
bool "DWC3 Mode Selection"
default USB_DWC3_DUAL_ROLE if (USB && USB_GADGET)
default USB_DWC3_HOST if (USB && !USB_GADGET)
default USB_DWC3_GADGET if (!USB && USB_GADGET)
In this case USB_XHCI_PLATFORM is not set (previously it would be selected
by USB_DWC3) and USB_DWC3_HOST (and USB_DWC3_DUAL_ROLE) now depends on it.
The following change should fix this:
config USB_DWC3
- depends on (USB || USB_GADGET) && HAS_DMA
+ depends on (USB && USB_XHCI_PLATFORM) || USB_GADGET)) && HAS_DMA
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v14 4/6] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on'
Date: Thu, 22 Jul 2021 17:17:34 -0700 [thread overview]
Message-ID: <YPoKnkttCyCHHn4T@google.com> (raw)
In-Reply-To: <202107210812.LLUZpfu9-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]
On Wed, Jul 21, 2021 at 08:46:17AM +0800, kernel test robot wrote:
> Hi Matthias,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on robh/for-next driver-core/driver-core-testing linus/master v5.14-rc2 next-20210720]
> [cannot apply to char-misc/char-misc-testing]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/usb-misc-Add-onboard_usb_hub-driver/20210720-144614
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> config: i386-randconfig-a003-20210720 (attached as .config)
> compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/1ac4caccda0f2e6904b0e1462bc9735c690d719f
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Matthias-Kaehlcke/usb-misc-Add-onboard_usb_hub-driver/20210720-144614
> git checkout 1ac4caccda0f2e6904b0e1462bc9735c690d719f
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> ld: drivers/usb/dwc3/core.o: in function `dwc3_resume_common':
> >> drivers/usb/dwc3/core.c:1853: undefined reference to `dwc3_gadget_resume'
> ld: drivers/usb/dwc3/core.o: in function `dwc3_runtime_resume':
> >> drivers/usb/dwc3/core.c:1912: undefined reference to `dwc3_gadget_process_pending_events'
> ld: drivers/usb/dwc3/core.o: in function `dwc3_suspend_common':
> >> drivers/usb/dwc3/core.c:1750: undefined reference to `dwc3_gadget_suspend'
What happened here is that USB_DWC3 was selected, but one of USB_DWC3_HOST,
USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE.
Typically one of them would be selected by:
choice
bool "DWC3 Mode Selection"
default USB_DWC3_DUAL_ROLE if (USB && USB_GADGET)
default USB_DWC3_HOST if (USB && !USB_GADGET)
default USB_DWC3_GADGET if (!USB && USB_GADGET)
In this case USB_XHCI_PLATFORM is not set (previously it would be selected
by USB_DWC3) and USB_DWC3_HOST (and USB_DWC3_DUAL_ROLE) now depends on it.
The following change should fix this:
config USB_DWC3
- depends on (USB || USB_GADGET) && HAS_DMA
+ depends on (USB && USB_XHCI_PLATFORM) || USB_GADGET)) && HAS_DMA
next prev parent reply other threads:[~2021-07-23 0:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 22:21 [PATCH v14 0/6] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-07-19 22:21 ` Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 1/6] " Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 2/6] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 3/6] arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM Matthias Kaehlcke
2021-07-19 22:21 ` Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 4/6] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Matthias Kaehlcke
2021-07-21 0:46 ` kernel test robot
2021-07-21 0:46 ` kernel test robot
2021-07-23 0:17 ` Matthias Kaehlcke [this message]
2021-07-23 0:17 ` Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 5/6] usb: host: xhci-plat: Create platform device for onboard hubs in probe() Matthias Kaehlcke
2021-07-19 22:21 ` [PATCH v14 6/6] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPoKnkttCyCHHn4T@google.com \
--to=mka@chromium.org \
--cc=balbi@kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathias.nyman@intel.com \
--cc=monstr@monstr.eu \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.