From: Eric Biggers <ebiggers@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Daeho Jeong <daehojeong@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: change fiemap way in printing compression chunk
Date: Fri, 23 Jul 2021 13:29:45 -0700 [thread overview]
Message-ID: <YPsmuUEoJUGhFm1J@gmail.com> (raw)
In-Reply-To: <20210723074928.1659385-1-daeho43@gmail.com>
On Fri, Jul 23, 2021 at 12:49:28AM -0700, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> When we print out a discontinuous compression chunk, it shows like a
> continuous chunk now. To show it more correctly, I've changed the way of
> printing fiemap info like below. Plus, eliminated NEW_ADDR(-1) in fiemap
> info, since it is not in fiemap user api manual.
>
> Let's assume 16KB compression cluster.
>
> <before>
> Logical Physical Length Flags
> 0: 0000000000000000 00000002c091f000 0000000000004000 1008
> 1: 0000000000004000 00000002c0920000 0000000000004000 1008
> ...
> 9: 0000000000034000 0000000f8c623000 0000000000004000 1008
> 10: 0000000000038000 000000101a6eb000 0000000000004000 1008
>
> <after>
> 0: 0000000000000000 00000002c091f000 0000000000004000 1008
> 1: 0000000000004000 00000002c0920000 0000000000004000 1008
> ...
> 9: 0000000000034000 0000000f8c623000 0000000000001000 1008
> 10: 0000000000035000 000000101a6ea000 0000000000003000 1008
> 11: 0000000000038000 000000101a6eb000 0000000000002000 1008
> 12: 000000000003a000 00000002c3544000 0000000000002000 1008
>
> Flags
> 0x1000 => FIEMAP_EXTENT_MERGED
> 0x0008 => FIEMAP_EXTENT_ENCODED
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
>
> ---
> v3: fix the missing last extent flag issue
> v2: changed the print format
> ---
> fs/f2fs/data.c | 75 ++++++++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 33 deletions(-)
I can't understand the code in f2fs_fiemap(), but I tested that my two
compression+encryption tests (xfstest f2fs/002 and Android
vts_kernel_encryption_test) pass reliably when this patch is applied.
Tested-by: Eric Biggers <ebiggers@google.com>
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: change fiemap way in printing compression chunk
Date: Fri, 23 Jul 2021 13:29:45 -0700 [thread overview]
Message-ID: <YPsmuUEoJUGhFm1J@gmail.com> (raw)
In-Reply-To: <20210723074928.1659385-1-daeho43@gmail.com>
On Fri, Jul 23, 2021 at 12:49:28AM -0700, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> When we print out a discontinuous compression chunk, it shows like a
> continuous chunk now. To show it more correctly, I've changed the way of
> printing fiemap info like below. Plus, eliminated NEW_ADDR(-1) in fiemap
> info, since it is not in fiemap user api manual.
>
> Let's assume 16KB compression cluster.
>
> <before>
> Logical Physical Length Flags
> 0: 0000000000000000 00000002c091f000 0000000000004000 1008
> 1: 0000000000004000 00000002c0920000 0000000000004000 1008
> ...
> 9: 0000000000034000 0000000f8c623000 0000000000004000 1008
> 10: 0000000000038000 000000101a6eb000 0000000000004000 1008
>
> <after>
> 0: 0000000000000000 00000002c091f000 0000000000004000 1008
> 1: 0000000000004000 00000002c0920000 0000000000004000 1008
> ...
> 9: 0000000000034000 0000000f8c623000 0000000000001000 1008
> 10: 0000000000035000 000000101a6ea000 0000000000003000 1008
> 11: 0000000000038000 000000101a6eb000 0000000000002000 1008
> 12: 000000000003a000 00000002c3544000 0000000000002000 1008
>
> Flags
> 0x1000 => FIEMAP_EXTENT_MERGED
> 0x0008 => FIEMAP_EXTENT_ENCODED
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
>
> ---
> v3: fix the missing last extent flag issue
> v2: changed the print format
> ---
> fs/f2fs/data.c | 75 ++++++++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 33 deletions(-)
I can't understand the code in f2fs_fiemap(), but I tested that my two
compression+encryption tests (xfstest f2fs/002 and Android
vts_kernel_encryption_test) pass reliably when this patch is applied.
Tested-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2021-07-23 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:49 [f2fs-dev] [PATCH v3] f2fs: change fiemap way in printing compression chunk Daeho Jeong
2021-07-23 7:49 ` Daeho Jeong
2021-07-23 20:29 ` Eric Biggers [this message]
2021-07-23 20:29 ` [f2fs-dev] " Eric Biggers
2021-07-24 1:19 ` Jaegeuk Kim
2021-07-24 1:19 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPsmuUEoJUGhFm1J@gmail.com \
--to=ebiggers@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.