From: Lee Jones <lee.jones@linaro.org>
To: Chris <chrisrblake93@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Christian Lamparter <chunkeey@gmail.com>
Subject: Re: [PATCH v2] platform/x86: add meraki-mx100 platform driver
Date: Mon, 9 Aug 2021 10:05:47 +0100 [thread overview]
Message-ID: <YRDv61SWABt8kJjx@google.com> (raw)
In-Reply-To: <CALpBJjosR8WvG=8QB=i12JSpbS3wyPbWLC_N1YM+8FSfVyL1rQ@mail.gmail.com>
On Fri, 06 Aug 2021, Chris wrote:
> On Fri, Aug 6, 2021 at 8:59 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Fri, Aug 6, 2021 at 4:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
> > > On 8/6/21 9:52 AM, Andy Shevchenko wrote:
> > > > On Fri, Aug 6, 2021 at 5:47 AM Chris Blake <chrisrblake93@gmail.com> wrote:
> >
> > ...
> >
> > > >> +#include <linux/gpio/machine.h>
> > > >
> > > > Does this provide a GPIO controller driver? I don't think so.
> > >
> > > Actually GPIO controller drivers use <linux/gpio/driver.h>
> > > <linux/gpio/machine.h> for board files / glue code which
> > > e.g. needs to add lookup-tables, which this code does,
> > > so including this header is correct.
> >
> > Ah, indeed. I stand corrected.
> >
>
> Hello,
>
> Thank you both for the feedback, i'll work on getting the fixes
> implemented. The only one I have issues with is finding the git hash
> for the dependency commit in mfd, since I don't see it merged up yet
> to the maintainers staging branch at
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/.
Check again. :)
> @Lee, sorry to tag you in but any chance you have the git hash for the
> PR I did earlier that you accepted for 5.15? It was named: mfd:
> lpc_ich: Enable GPIO driver for DH89xxCC.
ef0eea5b151ae ("mfd: lpc_ich: Enable GPIO driver for DH89xxCC")
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-08-09 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 0:57 [PATCH v2] platform/x86: add meraki-mx100 platform driver Chris Blake
2021-08-06 7:52 ` Andy Shevchenko
2021-08-06 13:55 ` Hans de Goede
2021-08-06 13:58 ` Andy Shevchenko
2021-08-06 15:37 ` Chris
2021-08-06 15:44 ` Andy Shevchenko
2021-08-09 9:05 ` Lee Jones [this message]
2021-08-06 13:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRDv61SWABt8kJjx@google.com \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=chrisrblake93@gmail.com \
--cc=chunkeey@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-gpio@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.