All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@denx.de>
Cc: sashal@kernel.org, linux-omap@vger.kernel.org,
	Dave Gerlach <d-gerlach@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
	Suman Anna <s-anna@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status
Date: Tue, 10 Aug 2021 15:52:15 +0300	[thread overview]
Message-ID: <YRJ2fyS6z1i/2W2e@atomide.com> (raw)
In-Reply-To: <20210810124006.GA25121@amd>

* Pavel Machek <pavel@denx.de> [210810 12:40]:
> Hi!
> 
> I noticed the issue while reviewing stable kernels, as this is being
> backported.
> 
> > Jarkko Nikula <jarkko.nikula@bitmer.com> reported that Beagleboard
> > revision c2 stopped booting. Jarkko bisected the issue down to
> > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend
> > and resume for am3 and am4").
> > 
> > Let's fix the issue by tagging system timers as reserved rather than
> > ignoring them. And let's not probe any interconnect target module child
> > devices for reserved modules.
> 
> +++ b/drivers/bus/ti-sysc.c
> > @@ -3093,8 +3095,8 @@ static int sysc_probe(struct platform_device *pdev)
> >  		return error;
> >  
> >  	error = sysc_check_active_timer(ddata);
> > -	if (error)
> > -		return error;
> > +	if (error == -EBUSY)
> > +		ddata->reserved = true;
> >  
> >  	error = sysc_get_clocks(ddata);
> >  	if (error)
> 
> What is going on here? First, we silently ignore errors other than
> EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it
> returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and
> -next-20210806).

Thanks for spotting it, looks like there's now a conflict with commit
65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as
clockevent/source"). It seems we should also check for -ENXIO here
too. And yeah it makes sens to return on other errors for sure.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@denx.de>
Cc: sashal@kernel.org, Nishanth Menon <nm@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Dave Gerlach <d-gerlach@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Faiz Abbas <faiz_abbas@ti.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Keerthy <j-keerthy@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status
Date: Tue, 10 Aug 2021 15:52:15 +0300	[thread overview]
Message-ID: <YRJ2fyS6z1i/2W2e@atomide.com> (raw)
In-Reply-To: <20210810124006.GA25121@amd>

* Pavel Machek <pavel@denx.de> [210810 12:40]:
> Hi!
> 
> I noticed the issue while reviewing stable kernels, as this is being
> backported.
> 
> > Jarkko Nikula <jarkko.nikula@bitmer.com> reported that Beagleboard
> > revision c2 stopped booting. Jarkko bisected the issue down to
> > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend
> > and resume for am3 and am4").
> > 
> > Let's fix the issue by tagging system timers as reserved rather than
> > ignoring them. And let's not probe any interconnect target module child
> > devices for reserved modules.
> 
> +++ b/drivers/bus/ti-sysc.c
> > @@ -3093,8 +3095,8 @@ static int sysc_probe(struct platform_device *pdev)
> >  		return error;
> >  
> >  	error = sysc_check_active_timer(ddata);
> > -	if (error)
> > -		return error;
> > +	if (error == -EBUSY)
> > +		ddata->reserved = true;
> >  
> >  	error = sysc_get_clocks(ddata);
> >  	if (error)
> 
> What is going on here? First, we silently ignore errors other than
> EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it
> returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and
> -next-20210806).

Thanks for spotting it, looks like there's now a conflict with commit
65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as
clockevent/source"). It seems we should also check for -ENXIO here
too. And yeah it makes sens to return on other errors for sure.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-10 12:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  6:02 [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status Tony Lindgren
2021-06-11  6:02 ` Tony Lindgren
2021-06-11 13:45 ` Jarkko Nikula
2021-06-11 13:45   ` Jarkko Nikula
2021-08-10 12:40 ` Pavel Machek
2021-08-10 12:40   ` Pavel Machek
2021-08-10 12:52   ` Tony Lindgren [this message]
2021-08-10 12:52     ` Tony Lindgren
2021-08-11  6:12     ` Tony Lindgren
2021-08-11  6:12       ` Tony Lindgren
2022-03-04 17:41 ` Kevin Hilman
2022-03-04 17:41   ` Kevin Hilman
2022-03-07 12:51   ` Tony Lindgren
2022-03-07 12:51     ` Tony Lindgren
2022-03-09 10:36     ` Kevin Hilman
2022-03-09 10:36       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRJ2fyS6z1i/2W2e@atomide.com \
    --to=tony@atomide.com \
    --cc=d-gerlach@ti.com \
    --cc=faiz_abbas@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pavel@denx.de \
    --cc=s-anna@ti.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.