From: Tzung-Bi Shih <tzungbi@google.com>
To: Jack Yu <jack.yu@realtek.com>
Cc: oder_chiou@realtek.com, robh@kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de,
kent_chen@realtek.com, devicetree@vger.kernel.org,
kenny_chen@realtek.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, broonie@kernel.org,
derek.fang@realtek.com, shumingf@realtek.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: dt-bindings: rt1015p: fix syntax error in dts-binding document
Date: Tue, 10 Aug 2021 17:37:11 +0800 [thread overview]
Message-ID: <YRJIx4O4BTybk1gi@google.com> (raw)
In-Reply-To: <20210810020834.32414-1-jack.yu@realtek.com>
On Tue, Aug 10, 2021 at 10:08:34AM +0800, Jack Yu wrote:
> Signed-off-by: Jack Yu <jack.yu@realtek.com>
Would be better to put the tag:
Fixes: 064478e4877c ("ASoC: dt-bindings: rt1015p: add new compatible id")
> properties:
> compatible:
> oneOf:
> - const: realtek,rt1015p
> - const: realtek,rt1019p
> + - const: realtek,rt1015p
> + - const: realtek,rt1019p
Not directly related to the fix but the "oneOf" has 2 extra space indent from the upper layer.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Jack Yu <jack.yu@realtek.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, robh@kernel.org,
oder_chiou@realtek.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de,
kent_chen@realtek.com, kenny_chen@realtek.com,
linux-kernel@vger.kernel.org, derek.fang@realtek.com,
shumingf@realtek.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: dt-bindings: rt1015p: fix syntax error in dts-binding document
Date: Tue, 10 Aug 2021 17:37:11 +0800 [thread overview]
Message-ID: <YRJIx4O4BTybk1gi@google.com> (raw)
In-Reply-To: <20210810020834.32414-1-jack.yu@realtek.com>
On Tue, Aug 10, 2021 at 10:08:34AM +0800, Jack Yu wrote:
> Signed-off-by: Jack Yu <jack.yu@realtek.com>
Would be better to put the tag:
Fixes: 064478e4877c ("ASoC: dt-bindings: rt1015p: add new compatible id")
> properties:
> compatible:
> oneOf:
> - const: realtek,rt1015p
> - const: realtek,rt1019p
> + - const: realtek,rt1015p
> + - const: realtek,rt1019p
Not directly related to the fix but the "oneOf" has 2 extra space indent from the upper layer.
next prev parent reply other threads:[~2021-08-10 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 2:08 [PATCH] ASoC: dt-bindings: rt1015p: fix syntax error in dts-binding document Jack Yu
2021-08-10 2:08 ` Jack Yu
2021-08-10 9:37 ` Tzung-Bi Shih [this message]
2021-08-10 9:37 ` Tzung-Bi Shih
2021-08-10 15:20 ` Mark Brown
2021-08-10 15:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRJIx4O4BTybk1gi@google.com \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kenny_chen@realtek.com \
--cc=kent_chen@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=robh@kernel.org \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.