From: Christoph Hellwig <hch@infradead.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Baoquan He <bhe@redhat.com>, Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@infradead.org>,
brijesh.singh@amd.com, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
rientjes@google.com
Subject: Re: [PATCH RFC 0/2] dma-pool: allow user to disable atomic pool
Date: Wed, 11 Aug 2021 06:52:57 +0100 [thread overview]
Message-ID: <YRNluS1qt1YL2r7p@infradead.org> (raw)
In-Reply-To: <5df93c4e-ffdd-88c5-db4a-1a09826d047a@amd.com>
On Tue, Aug 10, 2021 at 03:52:25PM -0500, Tom Lendacky via iommu wrote:
> I think the atomic pool is used by the NVMe driver. My understanding is
> that driver will do a dma_alloc_coherent() from interrupt context, so it
> needs to use GFP_ATOMIC. The pool was created because dma_alloc_coherent()
> would perform a set_memory_decrypted() call, which can sleep. The pool
> eliminates that issue (David can correct me if I got that wrong).
Not just the NVMe driver. We have plenty of drivers doing that, just
do a quick grep for dma_alloc_* dma_poll_alloc, dma_pool_zalloc with
GFP_ATOMIC (and that won't even find multi-line strings).
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: brijesh.singh@amd.com, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
rientjes@google.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH RFC 0/2] dma-pool: allow user to disable atomic pool
Date: Wed, 11 Aug 2021 06:52:57 +0100 [thread overview]
Message-ID: <YRNluS1qt1YL2r7p@infradead.org> (raw)
In-Reply-To: <5df93c4e-ffdd-88c5-db4a-1a09826d047a@amd.com>
On Tue, Aug 10, 2021 at 03:52:25PM -0500, Tom Lendacky via iommu wrote:
> I think the atomic pool is used by the NVMe driver. My understanding is
> that driver will do a dma_alloc_coherent() from interrupt context, so it
> needs to use GFP_ATOMIC. The pool was created because dma_alloc_coherent()
> would perform a set_memory_decrypted() call, which can sleep. The pool
> eliminates that issue (David can correct me if I got that wrong).
Not just the NVMe driver. We have plenty of drivers doing that, just
do a quick grep for dma_alloc_* dma_poll_alloc, dma_pool_zalloc with
GFP_ATOMIC (and that won't even find multi-line strings).
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Baoquan He <bhe@redhat.com>, Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@infradead.org>,
brijesh.singh@amd.com, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
rientjes@google.com
Subject: Re: [PATCH RFC 0/2] dma-pool: allow user to disable atomic pool
Date: Wed, 11 Aug 2021 06:52:57 +0100 [thread overview]
Message-ID: <YRNluS1qt1YL2r7p@infradead.org> (raw)
In-Reply-To: <5df93c4e-ffdd-88c5-db4a-1a09826d047a@amd.com>
On Tue, Aug 10, 2021 at 03:52:25PM -0500, Tom Lendacky via iommu wrote:
> I think the atomic pool is used by the NVMe driver. My understanding is
> that driver will do a dma_alloc_coherent() from interrupt context, so it
> needs to use GFP_ATOMIC. The pool was created because dma_alloc_coherent()
> would perform a set_memory_decrypted() call, which can sleep. The pool
> eliminates that issue (David can correct me if I got that wrong).
Not just the NVMe driver. We have plenty of drivers doing that, just
do a quick grep for dma_alloc_* dma_poll_alloc, dma_pool_zalloc with
GFP_ATOMIC (and that won't even find multi-line strings).
next prev parent reply other threads:[~2021-08-11 5:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 5:20 [PATCH RFC 0/2] dma-pool: allow user to disable atomic pool Baoquan He
2021-06-24 5:20 ` Baoquan He
2021-06-24 5:20 ` [PATCH 1/2] docs: kernel-parameters: Update to reflect the current default size of " Baoquan He
2021-06-24 5:20 ` Baoquan He
2021-06-24 5:20 ` [PATCH 2/2] dma-pool: allow user to disable " Baoquan He
2021-06-24 5:20 ` Baoquan He
2021-06-24 7:40 ` [PATCH RFC 0/2] " Christoph Hellwig
2021-06-24 7:40 ` Christoph Hellwig
2021-06-24 9:29 ` Baoquan He
2021-06-24 9:29 ` Baoquan He
2021-06-24 9:29 ` Baoquan He
2021-06-24 10:47 ` Robin Murphy
2021-06-24 10:47 ` Robin Murphy
2021-06-24 10:47 ` Robin Murphy
2021-06-24 12:10 ` Christoph Hellwig
2021-06-24 12:10 ` Christoph Hellwig
2021-06-24 12:10 ` Christoph Hellwig
2021-08-05 6:54 ` Baoquan He
2021-08-05 6:54 ` Baoquan He
2021-08-05 6:54 ` Baoquan He
2021-08-10 20:52 ` Tom Lendacky
2021-08-10 20:52 ` Tom Lendacky
2021-08-10 20:52 ` Tom Lendacky via iommu
2021-08-11 2:23 ` Baoquan He
2021-08-11 2:23 ` Baoquan He
2021-08-11 2:23 ` Baoquan He
2021-08-11 13:46 ` Tom Lendacky
2021-08-11 13:46 ` Tom Lendacky
2021-08-11 13:46 ` Tom Lendacky via iommu
2021-08-11 5:52 ` Christoph Hellwig [this message]
2021-08-11 5:52 ` Christoph Hellwig
2021-08-11 5:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRNluS1qt1YL2r7p@infradead.org \
--to=hch@infradead.org \
--cc=bhe@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.