From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ido Schimmel <idosch@idosch.org>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, davem@davemloft.net, mkubecek@suse.cz,
pali@kernel.org, vadimp@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [RFC PATCH net-next 1/8] ethtool: Add ability to control transceiver modules' low power mode
Date: Wed, 11 Aug 2021 16:36:13 +0200 [thread overview]
Message-ID: <YRPgXWKZ2e88J1sn@lunn.ch> (raw)
In-Reply-To: <20210811060343.014724e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Aug 11, 2021 at 06:03:43AM -0700, Jakub Kicinski wrote:
> On Wed, 11 Aug 2021 14:33:06 +0300 Ido Schimmel wrote:
> > # ethtool --set-module swp13 low-power on
> >
> > $ ethtool --show-module swp13
> > Module parameters for swp13:
> > low-power true
> >
> > # ip link set dev swp13 up
> >
> > $ ip link show dev swp13
> > 127: swp13: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
> > link/ether 1c:34:da:18:55:49 brd ff:ff:ff:ff:ff:ff
> >
> > $ ip link show dev swp14
> > 128: swp14: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
> > link/ether 1c:34:da:18:55:4d brd ff:ff:ff:ff:ff:ff
>
> Oh, so if we set low-power true the carrier will never show up?
> I thought Andrew suggested the setting is only taken into account
> when netdev is down.
Yes, that was my intention. If this low power mode also applies when
the interface is admin up, it sounds like a foot gun. ip link show
gives you no idea why the carrier is down, and people will assume the
cable or peer is broken. We at least need a new flag, LOWER_DISABLED
or similar to give the poor user some chance to figure out what is
going on.
To me, this setting should only apply when the link is admin down.
Andrew
next prev parent reply other threads:[~2021-08-11 14:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 10:21 [RFC PATCH net-next 0/8] ethtool: Add ability to control transceiver modules Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 1/8] ethtool: Add ability to control transceiver modules' low power mode Ido Schimmel
2021-08-09 14:28 ` Andrew Lunn
2021-08-10 7:26 ` Ido Schimmel
2021-08-10 13:52 ` Andrew Lunn
2021-08-10 13:59 ` Jakub Kicinski
2021-08-10 20:46 ` Ido Schimmel
2021-08-10 22:00 ` Keller, Jacob E
2021-08-10 22:06 ` Jakub Kicinski
2021-08-10 22:18 ` Keller, Jacob E
2021-08-10 22:24 ` Keller, Jacob E
2021-08-10 22:31 ` Andrew Lunn
2021-08-11 0:38 ` Keller, Jacob E
2021-08-10 22:05 ` Jakub Kicinski
2021-08-10 22:51 ` Andrew Lunn
2021-08-11 11:33 ` Ido Schimmel
2021-08-11 13:03 ` Jakub Kicinski
2021-08-11 14:36 ` Andrew Lunn [this message]
2021-08-11 19:37 ` Ido Schimmel
2021-08-11 20:30 ` Jakub Kicinski
2021-08-11 20:57 ` Andrew Lunn
2021-08-11 21:04 ` Ido Schimmel
2021-08-11 20:42 ` Andrew Lunn
2021-08-10 21:38 ` Keller, Jacob E
2021-08-09 10:21 ` [RFC PATCH net-next 2/8] ethtool: Add ability to reset transceiver modules Ido Schimmel
2021-08-09 19:13 ` Andrew Lunn
2021-08-10 13:05 ` Ido Schimmel
2021-08-10 13:54 ` Jakub Kicinski
2021-08-10 18:15 ` Ido Schimmel
2021-08-10 18:58 ` Andrew Lunn
2021-08-10 19:00 ` Jakub Kicinski
2021-08-10 19:28 ` Andrew Lunn
2021-08-10 20:50 ` Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 3/8] mlxsw: reg: Add fields to PMAOS register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 4/8] mlxsw: Make PMAOS pack function more generic Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 5/8] mlxsw: reg: Add Port Module Memory Map Properties register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 6/8] mlxsw: reg: Add Management Cable IO and Notifications register Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 7/8] mlxsw: Add ability to control transceiver modules' low power mode Ido Schimmel
2021-08-09 10:21 ` [RFC PATCH net-next 8/8] mlxsw: Add ability to reset transceiver modules Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRPgXWKZ2e88J1sn@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.