All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Remove duplicate #ifdef in pci_try_set_mwi()
Date: Thu, 12 Aug 2021 08:49:21 +0200	[thread overview]
Message-ID: <YRTEcd0S2/2XlL7p@kroah.com> (raw)
In-Reply-To: <20210811234601.341947-1-utkarshverma294@gmail.com>

On Thu, Aug 12, 2021 at 05:16:01AM +0530, Utkarsh Verma wrote:
> Remove the unnecessary #ifdef PCI_DISABLE_MWI, because pci_set_mwi()
> performs the same check.
> 
> Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
> ---
>  drivers/pci/pci.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index aacf575c15cf..7d4c7c294ef2 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4456,11 +4456,7 @@ EXPORT_SYMBOL(pcim_set_mwi);
>   */
>  int pci_try_set_mwi(struct pci_dev *dev)
>  {
> -#ifdef PCI_DISABLE_MWI
> -	return 0;
> -#else
>  	return pci_set_mwi(dev);
> -#endif
>  }
>  EXPORT_SYMBOL(pci_try_set_mwi);

If this is the case, why do we even need pci_try_set_mwi()?  Why not
just replace it with calls to pci_set_mwi() and then delete this one?

thanks,

greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Remove duplicate #ifdef in pci_try_set_mwi()
Date: Thu, 12 Aug 2021 08:49:21 +0200	[thread overview]
Message-ID: <YRTEcd0S2/2XlL7p@kroah.com> (raw)
In-Reply-To: <20210811234601.341947-1-utkarshverma294@gmail.com>

On Thu, Aug 12, 2021 at 05:16:01AM +0530, Utkarsh Verma wrote:
> Remove the unnecessary #ifdef PCI_DISABLE_MWI, because pci_set_mwi()
> performs the same check.
> 
> Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
> ---
>  drivers/pci/pci.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index aacf575c15cf..7d4c7c294ef2 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4456,11 +4456,7 @@ EXPORT_SYMBOL(pcim_set_mwi);
>   */
>  int pci_try_set_mwi(struct pci_dev *dev)
>  {
> -#ifdef PCI_DISABLE_MWI
> -	return 0;
> -#else
>  	return pci_set_mwi(dev);
> -#endif
>  }
>  EXPORT_SYMBOL(pci_try_set_mwi);

If this is the case, why do we even need pci_try_set_mwi()?  Why not
just replace it with calls to pci_set_mwi() and then delete this one?

thanks,

greg k-h

  reply	other threads:[~2021-08-12  6:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 23:46 [PATCH] PCI: Remove duplicate #ifdef in pci_try_set_mwi() Utkarsh Verma
2021-08-11 23:46 ` Utkarsh Verma
2021-08-12  6:49 ` Greg KH [this message]
2021-08-12  6:49   ` Greg KH
2021-08-12 10:55   ` Utkarsh Verma
2021-08-12 10:55     ` Utkarsh Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRTEcd0S2/2XlL7p@kroah.com \
    --to=greg@kroah.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=utkarshverma294@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.