From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"John Stultz" <john.stultz@linaro.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/vgem: use shmem helpers
Date: Thu, 12 Aug 2021 19:01:44 +0200 [thread overview]
Message-ID: <YRVT+B69l74Lk4+A@ravnborg.org> (raw)
In-Reply-To: <20210812131412.2487363-4-daniel.vetter@ffwll.ch>
Hi Daniel,
On Thu, Aug 12, 2021 at 03:14:12PM +0200, Daniel Vetter wrote:
> Aside from deleting lots of code the real motivation here is to switch
> the mmap over to VM_PFNMAP, to be more consistent with what real gpu
> drivers do. They're all VM_PFNMP, which means get_user_pages doesn't
> work, and even if you try and there's a struct page behind that,
> touching it and mucking around with its refcount can upset drivers
> real bad.
The only thing I understood of all this complicated stuff was "deleting
lots of code" which is a good thing.
You may want to s/VM_PFNMP/VM_PFNMAP/ before you push this.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"John Stultz" <john.stultz@linaro.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 4/4] drm/vgem: use shmem helpers
Date: Thu, 12 Aug 2021 19:01:44 +0200 [thread overview]
Message-ID: <YRVT+B69l74Lk4+A@ravnborg.org> (raw)
In-Reply-To: <20210812131412.2487363-4-daniel.vetter@ffwll.ch>
Hi Daniel,
On Thu, Aug 12, 2021 at 03:14:12PM +0200, Daniel Vetter wrote:
> Aside from deleting lots of code the real motivation here is to switch
> the mmap over to VM_PFNMAP, to be more consistent with what real gpu
> drivers do. They're all VM_PFNMP, which means get_user_pages doesn't
> work, and even if you try and there's a struct page behind that,
> touching it and mucking around with its refcount can upset drivers
> real bad.
The only thing I understood of all this complicated stuff was "deleting
lots of code" which is a good thing.
You may want to s/VM_PFNMP/VM_PFNMAP/ before you push this.
Sam
next prev parent reply other threads:[~2021-08-12 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 13:14 [Intel-gfx] [PATCH 1/4] dma-buf: Require VM_PFNMAP vma for mmap Daniel Vetter
2021-08-12 13:14 ` Daniel Vetter
2021-08-12 13:14 ` [Intel-gfx] [PATCH 2/4] drm/shmem-helper: Switch to vmf_insert_pfn Daniel Vetter
2021-08-12 13:14 ` Daniel Vetter
2021-08-12 13:14 ` [Intel-gfx] [PATCH 3/4] drm/shmem-helpers: Allocate wc pages on x86 Daniel Vetter
2021-08-12 13:14 ` Daniel Vetter
2021-08-12 13:14 ` [Intel-gfx] [PATCH 4/4] drm/vgem: use shmem helpers Daniel Vetter
2021-08-12 13:14 ` Daniel Vetter
2021-08-12 17:01 ` Sam Ravnborg [this message]
2021-08-12 17:01 ` Sam Ravnborg
2021-08-12 19:41 ` [Intel-gfx] " Daniel Vetter
2021-08-12 19:41 ` Daniel Vetter
2021-08-12 18:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] dma-buf: Require VM_PFNMAP vma for mmap Patchwork
2021-08-12 19:21 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRVT+B69l74Lk4+A@ravnborg.org \
--to=sam@ravnborg.org \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=melissa.srw@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.