From: Greg KH <gregkh@linuxfoundation.org>
To: SelvaKumar S <selvakuma.s1@samsung.com>
Cc: snitzer@redhat.com, djwong@kernel.org,
linux-nvme@lists.infradead.org, dm-devel@redhat.com, hch@lst.de,
agk@redhat.com, bvanassche@acm.org, linux-scsi@vger.kernel.org,
nitheshshetty@gmail.com, willy@infradead.org,
nj.shetty@samsung.com, kch@kernel.org, selvajove@gmail.com,
linux-block@vger.kernel.org, mpatocka@redhat.com,
javier.gonz@samsung.com, kbusch@kernel.org, axboe@kernel.dk,
damien.lemoal@wdc.com, joshi.k@samsung.com,
martin.petersen@oracle.com, linux-api@vger.kernel.org,
johannes.thumshirn@wdc.com, linux-fsdevel@vger.kernel.org,
joshiiitr@gmail.com, asml.silence@gmail.com
Subject: Re: [dm-devel] [PATCH 2/7] block: Introduce queue limits for copy-offload support
Date: Tue, 17 Aug 2021 15:08:43 +0200 [thread overview]
Message-ID: <YRu02+RgnZekKSqi@kroah.com> (raw)
In-Reply-To: <20210817101423.12367-3-selvakuma.s1@samsung.com>
On Tue, Aug 17, 2021 at 03:44:18PM +0530, SelvaKumar S wrote:
> From: Nitesh Shetty <nj.shetty@samsung.com>
>
> Add device limits as sysfs entries,
> - copy_offload (READ_WRITE)
> - max_copy_sectors (READ_ONLY)
> - max_copy_ranges_sectors (READ_ONLY)
> - max_copy_nr_ranges (READ_ONLY)
You forgot to add Documentation/ABI/ entries for your new sysfs files,
so we can't properly review them :(
thanks,
greg k-h
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: SelvaKumar S <selvakuma.s1@samsung.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
kbusch@kernel.org, axboe@kernel.dk, damien.lemoal@wdc.com,
asml.silence@gmail.com, johannes.thumshirn@wdc.com, hch@lst.de,
willy@infradead.org, kch@kernel.org, martin.petersen@oracle.com,
mpatocka@redhat.com, bvanassche@acm.org, djwong@kernel.org,
snitzer@redhat.com, agk@redhat.com, selvajove@gmail.com,
joshiiitr@gmail.com, nj.shetty@samsung.com,
nitheshshetty@gmail.com, joshi.k@samsung.com,
javier.gonz@samsung.com
Subject: Re: [PATCH 2/7] block: Introduce queue limits for copy-offload support
Date: Tue, 17 Aug 2021 15:08:43 +0200 [thread overview]
Message-ID: <YRu02+RgnZekKSqi@kroah.com> (raw)
In-Reply-To: <20210817101423.12367-3-selvakuma.s1@samsung.com>
On Tue, Aug 17, 2021 at 03:44:18PM +0530, SelvaKumar S wrote:
> From: Nitesh Shetty <nj.shetty@samsung.com>
>
> Add device limits as sysfs entries,
> - copy_offload (READ_WRITE)
> - max_copy_sectors (READ_ONLY)
> - max_copy_ranges_sectors (READ_ONLY)
> - max_copy_nr_ranges (READ_ONLY)
You forgot to add Documentation/ABI/ entries for your new sysfs files,
so we can't properly review them :(
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: SelvaKumar S <selvakuma.s1@samsung.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
kbusch@kernel.org, axboe@kernel.dk, damien.lemoal@wdc.com,
asml.silence@gmail.com, johannes.thumshirn@wdc.com, hch@lst.de,
willy@infradead.org, kch@kernel.org, martin.petersen@oracle.com,
mpatocka@redhat.com, bvanassche@acm.org, djwong@kernel.org,
snitzer@redhat.com, agk@redhat.com, selvajove@gmail.com,
joshiiitr@gmail.com, nj.shetty@samsung.com,
nitheshshetty@gmail.com, joshi.k@samsung.com,
javier.gonz@samsung.com
Subject: Re: [PATCH 2/7] block: Introduce queue limits for copy-offload support
Date: Tue, 17 Aug 2021 15:08:43 +0200 [thread overview]
Message-ID: <YRu02+RgnZekKSqi@kroah.com> (raw)
In-Reply-To: <20210817101423.12367-3-selvakuma.s1@samsung.com>
On Tue, Aug 17, 2021 at 03:44:18PM +0530, SelvaKumar S wrote:
> From: Nitesh Shetty <nj.shetty@samsung.com>
>
> Add device limits as sysfs entries,
> - copy_offload (READ_WRITE)
> - max_copy_sectors (READ_ONLY)
> - max_copy_ranges_sectors (READ_ONLY)
> - max_copy_nr_ranges (READ_ONLY)
You forgot to add Documentation/ABI/ entries for your new sysfs files,
so we can't properly review them :(
thanks,
greg k-h
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-08-17 13:18 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210817101741epcas5p174ca0a539587da6a67b9f58cd13f2bad@epcas5p1.samsung.com>
2021-08-17 10:14 ` [dm-devel] [PATCH 0/7] add simple copy support SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` [dm-devel] [PATCH 1/7] block: make bio_map_kern() non static SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` [dm-devel] [PATCH 2/7] block: Introduce queue limits for copy-offload support SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 13:08 ` Greg KH [this message]
2021-08-17 13:08 ` Greg KH
2021-08-17 13:08 ` Greg KH
2021-08-17 14:42 ` [dm-devel] " Nitesh Shetty
2021-08-17 14:42 ` Nitesh Shetty
2021-08-17 14:42 ` Nitesh Shetty
2021-08-17 10:14 ` [dm-devel] [PATCH 3/7] block: copy offload support infrastructure SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 17:14 ` [dm-devel] " Bart Van Assche
2021-08-17 17:14 ` Bart Van Assche
2021-08-17 17:14 ` Bart Van Assche
2021-08-17 20:41 ` [dm-devel] " Mikulas Patocka
2021-08-17 20:41 ` Mikulas Patocka
2021-08-17 20:41 ` Mikulas Patocka
2021-08-17 21:53 ` [dm-devel] " Douglas Gilbert
2021-08-17 21:53 ` Douglas Gilbert
2021-08-17 21:53 ` Douglas Gilbert
2021-08-17 22:06 ` [dm-devel] " Bart Van Assche
2021-08-17 22:06 ` Bart Van Assche
2021-08-17 22:06 ` Bart Van Assche
2021-08-20 10:39 ` [dm-devel] " Kanchan Joshi
2021-08-20 10:39 ` Kanchan Joshi
2021-08-20 10:39 ` Kanchan Joshi
2021-08-20 21:18 ` [dm-devel] " Bart Van Assche
2021-08-20 21:18 ` Bart Van Assche
2021-08-20 21:18 ` Bart Van Assche
2021-08-26 7:46 ` [dm-devel] " Nitesh Shetty
2021-08-26 7:46 ` Nitesh Shetty
2021-08-26 7:46 ` Nitesh Shetty
2021-08-17 20:35 ` [dm-devel] " kernel test robot
2021-08-17 20:35 ` kernel test robot
2021-08-17 20:35 ` kernel test robot
2021-08-17 20:35 ` kernel test robot
2021-08-18 18:35 ` [dm-devel] " Martin K. Petersen
2021-08-18 18:35 ` Martin K. Petersen
2021-08-18 18:35 ` Martin K. Petersen
2021-08-20 11:11 ` [dm-devel] " Kanchan Joshi
2021-08-20 11:11 ` Kanchan Joshi
2021-08-20 11:11 ` Kanchan Joshi
2021-08-17 10:14 ` [dm-devel] [PATCH 4/7] block: Introduce a new ioctl for simple copy SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 13:09 ` [dm-devel] " Greg KH
2021-08-17 13:09 ` Greg KH
2021-08-17 13:09 ` Greg KH
2021-08-17 13:10 ` [dm-devel] " Greg KH
2021-08-17 13:10 ` Greg KH
2021-08-17 13:10 ` Greg KH
2021-08-17 14:48 ` [dm-devel] " Nitesh Shetty
2021-08-17 14:48 ` Nitesh Shetty
2021-08-17 14:48 ` Nitesh Shetty
2021-08-17 23:36 ` [dm-devel] " Darrick J. Wong
2021-08-17 23:36 ` Darrick J. Wong
2021-08-17 23:36 ` Darrick J. Wong
2021-08-18 15:37 ` [dm-devel] " Nitesh Shetty
2021-08-18 15:37 ` Nitesh Shetty
2021-08-18 15:37 ` Nitesh Shetty
2021-08-18 16:17 ` [dm-devel] " Darrick J. Wong
2021-08-18 16:17 ` Darrick J. Wong
2021-08-18 16:17 ` Darrick J. Wong
2021-08-17 10:14 ` [dm-devel] [PATCH 5/7] block: add emulation " SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 22:10 ` [dm-devel] " kernel test robot
2021-08-17 22:10 ` kernel test robot
2021-08-17 22:10 ` kernel test robot
2021-08-17 22:10 ` kernel test robot
2021-08-17 10:14 ` [dm-devel] [PATCH 6/7] nvme: add simple copy support SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` [dm-devel] [PATCH 7/7] dm kcopyd: add simple copy offload support SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 10:14 ` SelvaKumar S
2021-08-17 20:29 ` [dm-devel] " Mikulas Patocka
2021-08-17 20:29 ` Mikulas Patocka
2021-08-17 20:29 ` Mikulas Patocka
2021-08-17 23:37 ` [dm-devel] [PATCH 0/7] add simple copy support Darrick J. Wong
2021-08-17 23:37 ` Darrick J. Wong
2021-08-17 23:37 ` Darrick J. Wong
2021-08-18 15:40 ` [dm-devel] " Nitesh Shetty
2021-08-18 15:40 ` Nitesh Shetty
2021-08-18 15:40 ` Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRu02+RgnZekKSqi@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agk@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=johannes.thumshirn@wdc.com \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=kch@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=selvajove@gmail.com \
--cc=selvakuma.s1@samsung.com \
--cc=snitzer@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.