From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Valmer Huhn <valmer.huhn@concurrent-rt.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] serial: 8250_exar: Add missing call to pci_free_irq_vectors()
Date: Tue, 17 Aug 2021 20:38:44 +0300 [thread overview]
Message-ID: <YRv0JO64HRHrl7Gb@smile.fi.intel.com> (raw)
In-Reply-To: <20210817170057.16783-1-utkarshverma294@gmail.com>
On Tue, Aug 17, 2021 at 10:30:57PM +0530, Utkarsh Verma wrote:
> Free the pci irq vectors if the call to pci_alloc_irq_vectors() fails
> or if the device is removed.
...
> rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
> - if (rc < 0)
> + if (rc < 0) {
> + pci_free_irq_vectors(pcidev);
Why?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Valmer Huhn <valmer.huhn@concurrent-rt.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] serial: 8250_exar: Add missing call to pci_free_irq_vectors()
Date: Tue, 17 Aug 2021 20:38:44 +0300 [thread overview]
Message-ID: <YRv0JO64HRHrl7Gb@smile.fi.intel.com> (raw)
In-Reply-To: <20210817170057.16783-1-utkarshverma294@gmail.com>
On Tue, Aug 17, 2021 at 10:30:57PM +0530, Utkarsh Verma wrote:
> Free the pci irq vectors if the call to pci_alloc_irq_vectors() fails
> or if the device is removed.
...
> rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
> - if (rc < 0)
> + if (rc < 0) {
> + pci_free_irq_vectors(pcidev);
Why?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-17 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 17:00 [PATCH] serial: 8250_exar: Add missing call to pci_free_irq_vectors() Utkarsh Verma
2021-08-17 17:00 ` Utkarsh Verma
2021-08-17 17:31 ` Andy Shevchenko
2021-08-17 17:31 ` Andy Shevchenko
2021-08-17 17:38 ` Andy Shevchenko [this message]
2021-08-17 17:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRv0JO64HRHrl7Gb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=utkarshverma294@gmail.com \
--cc=valmer.huhn@concurrent-rt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.