From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915/debugfs: register LPSP capability on all platforms
Date: Wed, 1 Sep 2021 12:19:05 -0400 [thread overview]
Message-ID: <YS+n+Sj5sUWhUqoO@intel.com> (raw)
In-Reply-To: <939453050a5a5175a12a08f16542c1b40bd726dc.1630327990.git.jani.nikula@intel.com>
On Mon, Aug 30, 2021 at 03:53:42PM +0300, Jani Nikula wrote:
> The debugfs file shows it's not capable, don't duplicate the info.
okay, but the file is useless if not supported right?!
I believe the goal here was even avoid the file creation...
But either way:
If this is not breaking IGT:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> .../gpu/drm/i915/display/intel_display_debugfs.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index a6dcb95cfc1f..c1cd5d005e08 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2486,14 +2486,11 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
> connector, &i915_dsc_bpp_fops);
> }
>
> - /* Legacy panels doesn't lpsp on any platform */
> - if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
> - IS_BROADWELL(dev_priv)) &&
> - (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> - connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> - connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> - connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> - connector->connector_type == DRM_MODE_CONNECTOR_HDMIB))
> + if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> + connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> + connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> + connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
> debugfs_create_file("i915_lpsp_capability", 0444, root,
> connector, &i915_lpsp_capability_fops);
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-09-01 16:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:53 [Intel-gfx] [PATCH 0/5] drm/i915/display: debugfs cleanups Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 1/5] drm/i915/debugfs: clean up LPSP status Jani Nikula
2021-09-01 16:13 ` Rodrigo Vivi
2021-08-30 12:53 ` [Intel-gfx] [PATCH 2/5] drm/i915/debugfs: clean up LPSP capable Jani Nikula
2021-09-01 16:14 ` Rodrigo Vivi
2021-09-02 11:14 ` Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 3/5] drm/i915/debugfs: register LPSP capability on all platforms Jani Nikula
2021-09-01 16:19 ` Rodrigo Vivi [this message]
2021-08-30 12:53 ` [Intel-gfx] [PATCH 4/5] drm/i915/display: stop returning errors from debugfs registration Jani Nikula
2021-09-01 16:20 ` Rodrigo Vivi
2021-09-01 17:02 ` Jani Nikula
2021-09-02 12:15 ` Vivi, Rodrigo
2021-08-30 12:53 ` [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add() Jani Nikula
2021-08-30 14:02 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2021-08-30 20:48 ` [Intel-gfx] [PATCH 5/5] " kernel test robot
2021-08-30 20:48 ` kernel test robot
2021-08-31 16:00 ` kernel test robot
2021-08-31 16:00 ` kernel test robot
2021-09-01 16:09 ` Rodrigo Vivi
2021-09-01 16:11 ` Rodrigo Vivi
2021-09-01 17:03 ` Jani Nikula
2021-08-30 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: debugfs cleanups Patchwork
2021-08-30 14:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: debugfs cleanups (rev2) Patchwork
2021-08-30 16:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS+n+Sj5sUWhUqoO@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.