From: kernel test robot <lkp@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org, jani.nikula@intel.com
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add()
Date: Tue, 31 Aug 2021 04:48:54 +0800 [thread overview]
Message-ID: <202108310406.upsJixEb-lkp@intel.com> (raw)
In-Reply-To: <a557a46d452b20c186f4735e9f15bf37e2845c99.1630327990.git.jani.nikula@intel.com>
[-- Attachment #1: Type: text/plain, Size: 5620 bytes --]
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210830]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/3398bb6468f037af818548e7987e8fd062278824
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
git checkout 3398bb6468f037af818548e7987e8fd062278824
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:2447:6: error: conflicting types for 'intel_connector_debugfs_add'
2447 | void intel_connector_debugfs_add(struct intel_connector *intel_connector)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/display/intel_display_debugfs.c:10:
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:6: note: previous declaration of 'intel_connector_debugfs_add' was here
15 | void intel_connector_debugfs_add(struct drm_connector *connector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/gpu/drm/i915/display/intel_connector.c: In function 'intel_connector_register':
>> drivers/gpu/drm/i915/display/intel_connector.c:127:30: error: passing argument 1 of 'intel_connector_debugfs_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
127 | intel_connector_debugfs_add(intel_connector);
| ^~~~~~~~~~~~~~~
| |
| struct intel_connector *
In file included from drivers/gpu/drm/i915/display/intel_connector.c:36:
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:56: note: expected 'struct drm_connector *' but argument is of type 'struct intel_connector *'
15 | void intel_connector_debugfs_add(struct drm_connector *connector);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
cc1: all warnings being treated as errors
vim +/intel_connector_debugfs_add +2447 drivers/gpu/drm/i915/display/intel_display_debugfs.c
2439
2440 /**
2441 * intel_connector_debugfs_add - add i915 specific connector debugfs files
2442 * @connector: pointer to a registered drm_connector
2443 *
2444 * Cleanup will be done by drm_connector_unregister() through a call to
2445 * drm_debugfs_connector_remove().
2446 */
> 2447 void intel_connector_debugfs_add(struct intel_connector *intel_connector)
2448 {
2449 struct drm_connector *connector = &intel_connector->base;
2450 struct dentry *root = connector->debugfs_entry;
2451 struct drm_i915_private *dev_priv = to_i915(connector->dev);
2452
2453 /* The connector must have been registered beforehands. */
2454 if (!root)
2455 return;
2456
2457 if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
2458 debugfs_create_file("i915_panel_timings", S_IRUGO, root,
2459 connector, &i915_panel_fops);
2460 debugfs_create_file("i915_psr_sink_status", S_IRUGO, root,
2461 connector, &i915_psr_sink_status_fops);
2462 }
2463
2464 if (HAS_PSR(dev_priv) &&
2465 connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
2466 debugfs_create_file("i915_psr_status", 0444, root,
2467 connector, &i915_psr_status_fops);
2468 }
2469
2470 if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
2471 connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
2472 connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
2473 debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,
2474 connector, &i915_hdcp_sink_capability_fops);
2475 }
2476
2477 if (DISPLAY_VER(dev_priv) >= 11 &&
2478 ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
2479 !to_intel_connector(connector)->mst_port) ||
2480 connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
2481 debugfs_create_file("i915_dsc_fec_support", 0644, root,
2482 connector, &i915_dsc_fec_support_fops);
2483
2484 debugfs_create_file("i915_dsc_bpp", 0644, root,
2485 connector, &i915_dsc_bpp_fops);
2486 }
2487
2488 if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
2489 connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
2490 connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
2491 connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
2492 connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
2493 debugfs_create_file("i915_lpsp_capability", 0444, root,
2494 connector, &i915_lpsp_capability_fops);
2495 }
2496
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65210 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add()
Date: Tue, 31 Aug 2021 04:48:54 +0800 [thread overview]
Message-ID: <202108310406.upsJixEb-lkp@intel.com> (raw)
In-Reply-To: <a557a46d452b20c186f4735e9f15bf37e2845c99.1630327990.git.jani.nikula@intel.com>
[-- Attachment #1: Type: text/plain, Size: 5736 bytes --]
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210830]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/3398bb6468f037af818548e7987e8fd062278824
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
git checkout 3398bb6468f037af818548e7987e8fd062278824
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:2447:6: error: conflicting types for 'intel_connector_debugfs_add'
2447 | void intel_connector_debugfs_add(struct intel_connector *intel_connector)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/i915/display/intel_display_debugfs.c:10:
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:6: note: previous declaration of 'intel_connector_debugfs_add' was here
15 | void intel_connector_debugfs_add(struct drm_connector *connector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/gpu/drm/i915/display/intel_connector.c: In function 'intel_connector_register':
>> drivers/gpu/drm/i915/display/intel_connector.c:127:30: error: passing argument 1 of 'intel_connector_debugfs_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
127 | intel_connector_debugfs_add(intel_connector);
| ^~~~~~~~~~~~~~~
| |
| struct intel_connector *
In file included from drivers/gpu/drm/i915/display/intel_connector.c:36:
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:56: note: expected 'struct drm_connector *' but argument is of type 'struct intel_connector *'
15 | void intel_connector_debugfs_add(struct drm_connector *connector);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
cc1: all warnings being treated as errors
vim +/intel_connector_debugfs_add +2447 drivers/gpu/drm/i915/display/intel_display_debugfs.c
2439
2440 /**
2441 * intel_connector_debugfs_add - add i915 specific connector debugfs files
2442 * @connector: pointer to a registered drm_connector
2443 *
2444 * Cleanup will be done by drm_connector_unregister() through a call to
2445 * drm_debugfs_connector_remove().
2446 */
> 2447 void intel_connector_debugfs_add(struct intel_connector *intel_connector)
2448 {
2449 struct drm_connector *connector = &intel_connector->base;
2450 struct dentry *root = connector->debugfs_entry;
2451 struct drm_i915_private *dev_priv = to_i915(connector->dev);
2452
2453 /* The connector must have been registered beforehands. */
2454 if (!root)
2455 return;
2456
2457 if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
2458 debugfs_create_file("i915_panel_timings", S_IRUGO, root,
2459 connector, &i915_panel_fops);
2460 debugfs_create_file("i915_psr_sink_status", S_IRUGO, root,
2461 connector, &i915_psr_sink_status_fops);
2462 }
2463
2464 if (HAS_PSR(dev_priv) &&
2465 connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
2466 debugfs_create_file("i915_psr_status", 0444, root,
2467 connector, &i915_psr_status_fops);
2468 }
2469
2470 if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
2471 connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
2472 connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
2473 debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,
2474 connector, &i915_hdcp_sink_capability_fops);
2475 }
2476
2477 if (DISPLAY_VER(dev_priv) >= 11 &&
2478 ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
2479 !to_intel_connector(connector)->mst_port) ||
2480 connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
2481 debugfs_create_file("i915_dsc_fec_support", 0644, root,
2482 connector, &i915_dsc_fec_support_fops);
2483
2484 debugfs_create_file("i915_dsc_bpp", 0644, root,
2485 connector, &i915_dsc_bpp_fops);
2486 }
2487
2488 if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
2489 connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
2490 connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
2491 connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
2492 connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
2493 debugfs_create_file("i915_lpsp_capability", 0444, root,
2494 connector, &i915_lpsp_capability_fops);
2495 }
2496
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65210 bytes --]
next prev parent reply other threads:[~2021-08-30 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:53 [Intel-gfx] [PATCH 0/5] drm/i915/display: debugfs cleanups Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 1/5] drm/i915/debugfs: clean up LPSP status Jani Nikula
2021-09-01 16:13 ` Rodrigo Vivi
2021-08-30 12:53 ` [Intel-gfx] [PATCH 2/5] drm/i915/debugfs: clean up LPSP capable Jani Nikula
2021-09-01 16:14 ` Rodrigo Vivi
2021-09-02 11:14 ` Jani Nikula
2021-08-30 12:53 ` [Intel-gfx] [PATCH 3/5] drm/i915/debugfs: register LPSP capability on all platforms Jani Nikula
2021-09-01 16:19 ` Rodrigo Vivi
2021-08-30 12:53 ` [Intel-gfx] [PATCH 4/5] drm/i915/display: stop returning errors from debugfs registration Jani Nikula
2021-09-01 16:20 ` Rodrigo Vivi
2021-09-01 17:02 ` Jani Nikula
2021-09-02 12:15 ` Vivi, Rodrigo
2021-08-30 12:53 ` [Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add() Jani Nikula
2021-08-30 14:02 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2021-08-30 20:48 ` kernel test robot [this message]
2021-08-30 20:48 ` [Intel-gfx] [PATCH 5/5] " kernel test robot
2021-08-31 16:00 ` kernel test robot
2021-08-31 16:00 ` kernel test robot
2021-09-01 16:09 ` Rodrigo Vivi
2021-09-01 16:11 ` Rodrigo Vivi
2021-09-01 17:03 ` Jani Nikula
2021-08-30 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: debugfs cleanups Patchwork
2021-08-30 14:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: debugfs cleanups (rev2) Patchwork
2021-08-30 16:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108310406.upsJixEb-lkp@intel.com \
--to=lkp@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.