From: Rob Herring <robh@kernel.org>
To: Sugar Zhang <sugar.zhang@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
broonie@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org
Subject: Re: [PATCH 15/15] ASoC: dt-bindings: rockchip: i2s: Document property 'clk-trcm'
Date: Mon, 23 Aug 2021 12:36:17 -0500 [thread overview]
Message-ID: <YSPckWacS4kk270r@robh.at.kernel.org> (raw)
In-Reply-To: <1629716132-21544-1-git-send-email-sugar.zhang@rock-chips.com>
On Mon, Aug 23, 2021 at 06:55:32PM +0800, Sugar Zhang wrote:
> This patch documents property 'rockchip,clk-trcm' which is used
> to specify the lrck.
>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2
Drop this.
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 11e911a..8d9dfed 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -72,6 +72,15 @@ properties:
> resets:
> maxItems: 2
>
> + rockchip,clk-trcm:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0
> + description:
> + tx and rx lrck/bclk common use.
> + 0: both tx_lrck/bclk and rx_lrck/bclk are used
> + 1: only tx_lrck/bclk is used
> + 2: only rx_lrck/bclk is used
Sounds like constraints. Make a schema.
> +
> rockchip,capture-channels:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 2
> --
> 2.7.4
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sugar Zhang <sugar.zhang@rock-chips.com>
Cc: broonie@kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 15/15] ASoC: dt-bindings: rockchip: i2s: Document property 'clk-trcm'
Date: Mon, 23 Aug 2021 12:36:17 -0500 [thread overview]
Message-ID: <YSPckWacS4kk270r@robh.at.kernel.org> (raw)
In-Reply-To: <1629716132-21544-1-git-send-email-sugar.zhang@rock-chips.com>
On Mon, Aug 23, 2021 at 06:55:32PM +0800, Sugar Zhang wrote:
> This patch documents property 'rockchip,clk-trcm' which is used
> to specify the lrck.
>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2
Drop this.
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 11e911a..8d9dfed 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -72,6 +72,15 @@ properties:
> resets:
> maxItems: 2
>
> + rockchip,clk-trcm:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0
> + description:
> + tx and rx lrck/bclk common use.
> + 0: both tx_lrck/bclk and rx_lrck/bclk are used
> + 1: only tx_lrck/bclk is used
> + 2: only rx_lrck/bclk is used
Sounds like constraints. Make a schema.
> +
> rockchip,capture-channels:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 2
> --
> 2.7.4
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sugar Zhang <sugar.zhang@rock-chips.com>
Cc: broonie@kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 15/15] ASoC: dt-bindings: rockchip: i2s: Document property 'clk-trcm'
Date: Mon, 23 Aug 2021 12:36:17 -0500 [thread overview]
Message-ID: <YSPckWacS4kk270r@robh.at.kernel.org> (raw)
In-Reply-To: <1629716132-21544-1-git-send-email-sugar.zhang@rock-chips.com>
On Mon, Aug 23, 2021 at 06:55:32PM +0800, Sugar Zhang wrote:
> This patch documents property 'rockchip,clk-trcm' which is used
> to specify the lrck.
>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2
Drop this.
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 11e911a..8d9dfed 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -72,6 +72,15 @@ properties:
> resets:
> maxItems: 2
>
> + rockchip,clk-trcm:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0
> + description:
> + tx and rx lrck/bclk common use.
> + 0: both tx_lrck/bclk and rx_lrck/bclk are used
> + 1: only tx_lrck/bclk is used
> + 2: only rx_lrck/bclk is used
Sounds like constraints. Make a schema.
> +
> rockchip,capture-channels:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 2
> --
> 2.7.4
>
>
>
>
next prev parent reply other threads:[~2021-08-23 17:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 10:48 [PATCH v1 0/15] Patches to update for rockchip i2s Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` [PATCH v1 01/15] ASoC: rockchip: i2s: Add support for set bclk ratio Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` [PATCH v1 02/15] ASoC: rockchip: i2s: Fixup clk div error Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` [PATCH v1 03/15] ASoC: rockchip: i2s: Improve dma data transfer efficiency Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` [PATCH v1 04/15] ASoC: rockchip: i2s: Fix regmap_ops hang Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:48 ` Sugar Zhang
2021-08-23 10:53 ` [PATCH 05/15] ASoC: rockchip: i2s: Fix concurrency between tx/rx Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` [PATCH 06/15] ASoC: rockchip: i2s: Reset the controller if soft reset failed Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` [PATCH 07/15] ASoC: dt-bindings: rockchip: Document reset property for i2s Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` [PATCH 08/15] ASoC: rockchip: i2s: Fixup config for DAIFMT_DSP_A/B Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` [PATCH 09/15] ASoC: rockchip: i2s: Add property to specify play/cap capability Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:53 ` Sugar Zhang
2021-08-23 10:54 ` [PATCH 10/15] ASoC: dt-bindings: rockchip: i2s: Document property for playback/capture Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` [PATCH 11/15] ASoC: rockchip: i2s: Add compatible for more SoCs Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` [PATCH 12/15] ASoC: dt-bindings: rockchip: Add compatible strings " Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` [PATCH 13/15] ASoC: rockchip: i2s: Add support for frame inversion Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` Sugar Zhang
2021-08-23 10:54 ` [PATCH 14/15] ASoC: rockchip: i2s: Add support for 'rockchip, clk-trcm' property Sugar Zhang
2021-08-23 10:54 ` [PATCH 14/15] ASoC: rockchip: i2s: Add support for 'rockchip,clk-trcm' property Sugar Zhang
2021-08-23 10:54 ` [PATCH 14/15] ASoC: rockchip: i2s: Add support for 'rockchip, clk-trcm' property Sugar Zhang
2021-08-23 11:47 ` Nicolas Frattaroli
2021-08-23 11:47 ` Nicolas Frattaroli
2021-08-23 11:47 ` Nicolas Frattaroli
2021-08-24 1:41 ` sugar zhang
2021-08-24 1:41 ` sugar zhang
2021-08-23 10:55 ` [PATCH 15/15] ASoC: dt-bindings: rockchip: i2s: Document property 'clk-trcm' Sugar Zhang
2021-08-23 10:55 ` Sugar Zhang
2021-08-23 10:55 ` Sugar Zhang
2021-08-23 13:30 ` Rob Herring
2021-08-23 13:30 ` Rob Herring
2021-08-23 13:30 ` Rob Herring
2021-08-23 17:36 ` Rob Herring [this message]
2021-08-23 17:36 ` Rob Herring
2021-08-23 17:36 ` Rob Herring
2021-08-24 2:48 ` [PATCH 15/15] ASoC: dt-bindings: rockchip: i2s: Document property 'clk-trcm'【请注意，邮件由robherring2@gmail.com代发】 sugar zhang
2021-08-24 2:48 ` sugar zhang
2021-08-24 2:48 ` sugar zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPckWacS4kk270r@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=sugar.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.