From: Rob Herring <robh@kernel.org>
To: Piyush Mehta <piyush.mehta@xilinx.com>
Cc: sgoud@xilinx.com, git@xilinx.com, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, zou_wei@huawei.com, arnd@arndb.de,
michal.simek@xilinx.com, robh+dt@kernel.org,
iwamatsu@nigauri.org, wendy.liang@xilinx.com,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
rajan.vaja@xilinx.com, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 2/3] dt-bindings: gpio: zynqmp: Add binding documentation for modepin
Date: Mon, 23 Aug 2021 13:09:29 -0500 [thread overview]
Message-ID: <YSPkWUs0Y2zDiHQU@robh.at.kernel.org> (raw)
In-Reply-To: <20210818081018.2620544-3-piyush.mehta@xilinx.com>
On Wed, 18 Aug 2021 13:40:17 +0530, Piyush Mehta wrote:
> This patch adds DT binding document for zynqmp modepin GPIO controller.
> Modepin GPIO controller has four GPIO pins which can be configurable
> as input or output.
>
> Modepin driver is a bridge between the peripheral driver and GPIO pins.
> It has set and get APIs for accessing GPIO pins, based on the device-tree
> entry of reset-gpio property in the peripheral driver, every pin can be
> configured as input/output and trigger GPIO pin.
>
> For more information please refer zynqMp TRM link:
> Link: https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf
> Chapter 2: Signals, Interfaces, and Pins
> Table 2-2: Clock, Reset, and Configuration Pins - PS_MODE
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> Changes in v2:
> - Addressed review comments: Update commit message
>
> Review Comments:
> https://lore.kernel.org/linux-arm-kernel/20210615080553.2021061-2-piyush.mehta@xilinx.com/T/#mbd1fbda813e33b19397b350bde75747c92a0d7e1
> https://lore.kernel.org/linux-arm-kernel/20210615080553.2021061-2-piyush.mehta@xilinx.com/T/#me82b1444ab3776162cdb0077dfc9256365c7e736
>
> Changes in v3:
> - Addressed Rob and Michal review comments:
> - Update DT example.
>
> Review Comments:
> https://lore.kernel.org/linux-arm-kernel/YRbBnRS0VosXcZWz@robh.at.kernel.org/
> https://lore.kernel.org/linux-arm-kernel/d71ad7f9-6972-8cc0-6dfb-b5306c9900d0@xilinx.com/
> ---
> .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 41 ++++++++++++++++++++++
> .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Piyush Mehta <piyush.mehta@xilinx.com>
Cc: sgoud@xilinx.com, git@xilinx.com, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, zou_wei@huawei.com, arnd@arndb.de,
michal.simek@xilinx.com, robh+dt@kernel.org,
iwamatsu@nigauri.org, wendy.liang@xilinx.com,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
rajan.vaja@xilinx.com, devicetree@vger.kernel.org
Subject: Re: [PATCH V3 2/3] dt-bindings: gpio: zynqmp: Add binding documentation for modepin
Date: Mon, 23 Aug 2021 13:09:29 -0500 [thread overview]
Message-ID: <YSPkWUs0Y2zDiHQU@robh.at.kernel.org> (raw)
In-Reply-To: <20210818081018.2620544-3-piyush.mehta@xilinx.com>
On Wed, 18 Aug 2021 13:40:17 +0530, Piyush Mehta wrote:
> This patch adds DT binding document for zynqmp modepin GPIO controller.
> Modepin GPIO controller has four GPIO pins which can be configurable
> as input or output.
>
> Modepin driver is a bridge between the peripheral driver and GPIO pins.
> It has set and get APIs for accessing GPIO pins, based on the device-tree
> entry of reset-gpio property in the peripheral driver, every pin can be
> configured as input/output and trigger GPIO pin.
>
> For more information please refer zynqMp TRM link:
> Link: https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf
> Chapter 2: Signals, Interfaces, and Pins
> Table 2-2: Clock, Reset, and Configuration Pins - PS_MODE
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> Changes in v2:
> - Addressed review comments: Update commit message
>
> Review Comments:
> https://lore.kernel.org/linux-arm-kernel/20210615080553.2021061-2-piyush.mehta@xilinx.com/T/#mbd1fbda813e33b19397b350bde75747c92a0d7e1
> https://lore.kernel.org/linux-arm-kernel/20210615080553.2021061-2-piyush.mehta@xilinx.com/T/#me82b1444ab3776162cdb0077dfc9256365c7e736
>
> Changes in v3:
> - Addressed Rob and Michal review comments:
> - Update DT example.
>
> Review Comments:
> https://lore.kernel.org/linux-arm-kernel/YRbBnRS0VosXcZWz@robh.at.kernel.org/
> https://lore.kernel.org/linux-arm-kernel/d71ad7f9-6972-8cc0-6dfb-b5306c9900d0@xilinx.com/
> ---
> .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 41 ++++++++++++++++++++++
> .../bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-23 18:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 8:10 [PATCH V3 0/3] gpio: modepin: Add driver support for modepin GPIO controller Piyush Mehta
2021-08-18 8:10 ` Piyush Mehta
2021-08-18 8:10 ` [PATCH V3 1/3] firmware: zynqmp: Add MMIO read and write support for PS_MODE pin Piyush Mehta
2021-08-18 8:10 ` Piyush Mehta
2021-08-18 8:10 ` [PATCH V3 2/3] dt-bindings: gpio: zynqmp: Add binding documentation for modepin Piyush Mehta
2021-08-18 8:10 ` Piyush Mehta
2021-08-18 9:00 ` Ahmad Fatoum
2021-08-18 9:00 ` Ahmad Fatoum
2021-08-18 9:38 ` Michal Simek
2021-08-18 9:38 ` Michal Simek
2021-08-18 9:55 ` Ahmad Fatoum
2021-08-18 9:55 ` Ahmad Fatoum
2021-08-18 10:01 ` Michal Simek
2021-08-18 10:01 ` Michal Simek
2021-08-23 18:09 ` Rob Herring [this message]
2021-08-23 18:09 ` Rob Herring
2021-08-18 8:10 ` [PATCH V3 3/3] gpio: modepin: Add driver support for modepin GPIO controller Piyush Mehta
2021-08-18 8:10 ` Piyush Mehta
2021-08-18 8:52 ` Ahmad Fatoum
2021-08-18 8:52 ` Ahmad Fatoum
2021-08-18 10:09 ` Piyush Mehta
2021-08-18 10:09 ` Piyush Mehta
2021-08-18 13:05 ` Ahmad Fatoum
2021-08-18 13:05 ` Ahmad Fatoum
2021-08-23 8:02 ` Bartosz Golaszewski
2021-08-23 8:02 ` Bartosz Golaszewski
2021-08-23 8:14 ` Michal Simek
2021-08-23 8:14 ` Michal Simek
2021-09-22 10:18 ` Bartosz Golaszewski
2021-09-22 10:18 ` Bartosz Golaszewski
2021-09-22 10:21 ` Bartosz Golaszewski
2021-09-22 10:21 ` Bartosz Golaszewski
2021-09-22 10:23 ` Michal Simek
2021-09-22 10:23 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPkWUs0Y2zDiHQU@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=iwamatsu@nigauri.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=piyush.mehta@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=wendy.liang@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.