Re: [PATCH 2/2] autogen.sh: Detect python

[Petr Vorel <pvorel@suse.cz>]

Hi Daniel,

> On Wed, Aug 18, 2021 at 09:19:23AM +0200, Petr Vorel wrote:
> > > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote:
> > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote:
> > > > > It help to avoid error on distros which has only python3 binary:
> > > > > ./autogen.sh: line 20: python: command not found

> > > > > Using bash builtin 'command -v' to avoid requiring which as extra
> > > > > dependency (usable on containers).

> > > > It looks the bash dependency is not specified in the INSTALL file in
> > > > "The Requirements" section. May I ask you to add it?

> > > ...and python requirement is missing from the list too. Additionally,
> > > please update autogen.sh python usage in the INSTALL file.
> > There is Python 2.6 or later, not sure if it still works on 2.6 (which is EOL)
> > or it requires now 2.7).

> I think we should update this requirement to "Python 3.0.0 or later".
I'll just note Python 3, because 1) IMHO it would not work on 3.0, first
reasonable python 3 version which allowed 2 and 3 reasonably easily coexist
together was IMHO 3.3, 2) no distro uses 3.0, they either use match higher 3
version (3.6 at least) or 2.7 (or 2.6 the oldest ones).

> > Also "If you use a development snapshot or want to hack on GRUB you may
> > need the following." is obsolete (from 2009), I'll move python, autoconf and
> > automake to the list on the top.

> OK...

> There is also:

>   3. Type `./bootstrap'.

>      * autogen.sh (called by bootstrap) uses python. By default the
>        invocation is "python", but it can be overridden by setting the
>        variable $PYTHON.

> I think this should be updated too.

+1.

Kind regards,
Petr