From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Gerhard Engleder <gerhard@engleder-embedded.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net] Revert "net: phy: Uniform PHY driver access"
Date: Mon, 13 Sep 2021 20:49:19 +0200 [thread overview]
Message-ID: <YT+dL1R/DTVBWQ7D@lunn.ch> (raw)
In-Reply-To: <20210912213855.kxoyfqdyxktax6d3@skbuf>
> I am not sure why "to_phy_driver" needs cleanup. Au contraire, I think
> the PHY library's usage of struct phy_device :: drv is what is strange
> and potentially buggy, it is the only subsystem I know of that keeps its
> own driver pointer rather than looking at struct device :: driver.
There is one odd driver in the mix. Take a look at xilinx_gmii2rgmii.c.
It probably could be done a better way, but that is what we have.
Andrew
next prev parent reply other threads:[~2021-09-13 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 19:28 [RFC PATCH net] Revert "net: phy: Uniform PHY driver access" Vladimir Oltean
2021-09-12 20:49 ` Gerhard Engleder
2021-09-12 21:38 ` Vladimir Oltean
2021-09-13 18:49 ` Andrew Lunn [this message]
2021-09-14 12:06 ` Vladimir Oltean
2021-09-14 14:33 ` Andrew Lunn
2021-09-14 15:15 ` Vladimir Oltean
2021-09-14 16:17 ` Gerhard Engleder
2021-09-14 16:29 ` Andrew Lunn
2021-09-14 17:14 ` Gerhard Engleder
2021-09-14 17:44 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT+dL1R/DTVBWQ7D@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gerhard@engleder-embedded.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.