From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
stephan@gerhold.net, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, jonathanh@nvidia.com, broonie@kernel.org,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
jbrunet@baylibre.com
Subject: Re: [PATCH v2 1/3] ASoC: Add json-schema documentation for sound-name-prefix
Date: Thu, 2 Sep 2021 14:27:24 -0500 [thread overview]
Message-ID: <YTElnNRjM3JTnYIw@robh.at.kernel.org> (raw)
In-Reply-To: <1630584239.106707.685602.nullmailer@robh.at.kernel.org>
On Thu, Sep 02, 2021 at 07:03:59AM -0500, Rob Herring wrote:
> On Thu, 02 Sep 2021 11:23:51 +0530, Sameer Pujar wrote:
> > The 'sound-name-prefix' is used to prepend suitable strings to a
> > component widgets or controls. This is helpful when there are
> > multiple instances of the same component. Add relevant json-schema
> > and is inspired from sound-name-prefix.txt documentation.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > .../devicetree/bindings/sound/name-prefix.yaml | 35 ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/name-prefix.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/sound/name-prefix.example.dts:19.28-22.11: Warning (unit_address_vs_reg): /example-0/analog-amplifier@0: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/sound/name-prefix.example.dts:24.28-27.11: Warning (unit_address_vs_reg): /example-0/analog-amplifier@1: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/sound/name-prefix.example.dt.yaml:0:0: /example-0/analog-amplifier@0: failed to match any schema with compatible: ['simple-audio-amplifier']
> Documentation/devicetree/bindings/sound/name-prefix.example.dt.yaml:0:0: /example-0/analog-amplifier@1: failed to match any schema with compatible: ['simple-audio-amplifier']
I'd suggest you just drop the example. This schema is not a complete
binding.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org, stephan@gerhold.net,
jbrunet@baylibre.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, lgirdwood@gmail.com,
jonathanh@nvidia.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com
Subject: Re: [PATCH v2 1/3] ASoC: Add json-schema documentation for sound-name-prefix
Date: Thu, 2 Sep 2021 14:27:24 -0500 [thread overview]
Message-ID: <YTElnNRjM3JTnYIw@robh.at.kernel.org> (raw)
In-Reply-To: <1630584239.106707.685602.nullmailer@robh.at.kernel.org>
On Thu, Sep 02, 2021 at 07:03:59AM -0500, Rob Herring wrote:
> On Thu, 02 Sep 2021 11:23:51 +0530, Sameer Pujar wrote:
> > The 'sound-name-prefix' is used to prepend suitable strings to a
> > component widgets or controls. This is helpful when there are
> > multiple instances of the same component. Add relevant json-schema
> > and is inspired from sound-name-prefix.txt documentation.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > .../devicetree/bindings/sound/name-prefix.yaml | 35 ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/name-prefix.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/sound/name-prefix.example.dts:19.28-22.11: Warning (unit_address_vs_reg): /example-0/analog-amplifier@0: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/sound/name-prefix.example.dts:24.28-27.11: Warning (unit_address_vs_reg): /example-0/analog-amplifier@1: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/sound/name-prefix.example.dt.yaml:0:0: /example-0/analog-amplifier@0: failed to match any schema with compatible: ['simple-audio-amplifier']
> Documentation/devicetree/bindings/sound/name-prefix.example.dt.yaml:0:0: /example-0/analog-amplifier@1: failed to match any schema with compatible: ['simple-audio-amplifier']
I'd suggest you just drop the example. This schema is not a complete
binding.
Rob
next prev parent reply other threads:[~2021-09-02 19:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:53 [PATCH v2 0/3] Convert name-prefix doc to json-schema Sameer Pujar
2021-09-02 5:53 ` Sameer Pujar
2021-09-02 5:53 ` [PATCH v2 1/3] ASoC: Add json-schema documentation for sound-name-prefix Sameer Pujar
2021-09-02 5:53 ` Sameer Pujar
2021-09-02 12:03 ` Rob Herring
2021-09-02 12:03 ` Rob Herring
2021-09-02 19:27 ` Rob Herring [this message]
2021-09-02 19:27 ` Rob Herring
2021-09-02 12:47 ` Jerome Brunet
2021-09-02 12:47 ` Jerome Brunet
2021-09-02 16:22 ` Sameer Pujar
2021-09-02 16:22 ` Sameer Pujar
2021-09-02 19:25 ` Rob Herring
2021-09-02 19:25 ` Rob Herring
2021-09-03 8:29 ` Jerome Brunet
2021-09-03 8:29 ` Jerome Brunet
2021-09-02 5:53 ` [PATCH v2 2/3] ASoC: Use schema reference " Sameer Pujar
2021-09-02 5:53 ` Sameer Pujar
2021-09-02 19:28 ` Rob Herring
2021-09-02 19:28 ` Rob Herring
2021-09-02 5:53 ` [PATCH v2 3/3] ASoC: Remove name-prefix.txt Sameer Pujar
2021-09-02 5:53 ` Sameer Pujar
2021-09-02 12:44 ` [PATCH v2 0/3] Convert name-prefix doc to json-schema Jerome Brunet
2021-09-02 12:44 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTElnNRjM3JTnYIw@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.