All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back
Date: Wed, 8 Sep 2021 22:28:37 -0700	[thread overview]
Message-ID: <YTmbhc7J5ZdVp3vI@google.com> (raw)
In-Reply-To: <YTmaPCd3/cpMyNEe@kroah.com>

On 09/09, Greg KH wrote:
> On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote:
> > From: Jaegeuk Kim <jaegeuk@kernel.org>
> > 
> > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream.
> > 
> > We must flush all the dirty data when enabling checkpoint back. Let's guarantee
> > that first by adding a retry logic on sync_inodes_sb(). In addition to that,
> > this patch adds to flush data in fsync when checkpoint is disabled, which can
> > mitigate the sync_inodes_sb() failures in advance.
> > 
> > Reviewed-by: Chao Yu <chao@kernel.org>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/file.c  |  5 ++---
> >  fs/f2fs/super.c | 11 ++++++++++-
> >  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> What stable kernel(s) are you wanting to have this backported to?

5.10 please.

> 
> thanks,
> 
> greg k-h


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	Chao Yu <chao@kernel.org>
Subject: Re: [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back
Date: Wed, 8 Sep 2021 22:28:37 -0700	[thread overview]
Message-ID: <YTmbhc7J5ZdVp3vI@google.com> (raw)
In-Reply-To: <YTmaPCd3/cpMyNEe@kroah.com>

On 09/09, Greg KH wrote:
> On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote:
> > From: Jaegeuk Kim <jaegeuk@kernel.org>
> > 
> > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream.
> > 
> > We must flush all the dirty data when enabling checkpoint back. Let's guarantee
> > that first by adding a retry logic on sync_inodes_sb(). In addition to that,
> > this patch adds to flush data in fsync when checkpoint is disabled, which can
> > mitigate the sync_inodes_sb() failures in advance.
> > 
> > Reviewed-by: Chao Yu <chao@kernel.org>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/file.c  |  5 ++---
> >  fs/f2fs/super.c | 11 ++++++++++-
> >  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> What stable kernel(s) are you wanting to have this backported to?

5.10 please.

> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2021-09-09  5:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 22:00 [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back Jaegeuk Kim via Linux-f2fs-devel
2021-09-08 22:00 ` Jaegeuk Kim
2021-09-09  5:23 ` [f2fs-dev] " Greg KH
2021-09-09  5:23   ` Greg KH
2021-09-09  5:28   ` Jaegeuk Kim [this message]
2021-09-09  5:28     ` Jaegeuk Kim
2021-09-09  5:32     ` [f2fs-dev] " Greg KH
2021-09-09  5:32       ` Greg KH
2021-09-09  5:42       ` [f2fs-dev] " Jaegeuk Kim
2021-09-09  5:42         ` Jaegeuk Kim
2021-09-09  6:09         ` [f2fs-dev] " Greg KH
2021-09-09  6:09           ` Greg KH
2021-09-13  9:24           ` [f2fs-dev] " Greg KH
2021-09-13  9:24             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YTmbhc7J5ZdVp3vI@google.com \
    --to=jaegeuk@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.