All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v2 3/3] firmware: xilinx: Add sysfs support for feature config
Date: Tue, 14 Sep 2021 11:21:17 +0200	[thread overview]
Message-ID: <YUBpjUGaB3G72wRa@kroah.com> (raw)
In-Reply-To: <20210913083955.27146-4-ronak.jain@xilinx.com>

On Mon, Sep 13, 2021 at 01:39:55AM -0700, Ronak Jain wrote:
> Add support for sysfs interface for runtime features configuration.
>  The user can configure the features at runtime. First the user need
>  to select the config id of the supported features and then the user
>  can configure the parameters of the feature based on the config id.
>  So far the support is added for the over temperature and external
>  watchdog features.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
> ---
> Changes in v2:
> - Update commit message
> ---
>  drivers/firmware/xilinx/zynqmp.c | 71 ++++++++++++++++++++++++++++++++
>  1 file changed, 71 insertions(+)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 875d13bc1a57..a1434dd368f2 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1361,6 +1361,75 @@ static DEVICE_ATTR_RW(pggs1);
>  static DEVICE_ATTR_RW(pggs2);
>  static DEVICE_ATTR_RW(pggs3);
>  
> +static atomic_t feature_conf_id;

Why does this have to be an atomic?

And shouldn't this be per-device, not global to all devices in the
system?

> +
> +static ssize_t feature_config_id_show(struct device *device,
> +				      struct device_attribute *attr,
> +				      char *buf)
> +{
> +	return sysfs_emit(buf, "%d\n", atomic_read(&feature_conf_id));
> +}
> +
> +static ssize_t feature_config_id_store(struct device *device,
> +				       struct device_attribute *attr,
> +				       const char *buf, size_t count)
> +{
> +	u32 config_id;
> +	int ret;
> +
> +	if (!buf)
> +		return -EINVAL;

How can there ever be a NULL buffer?

No need to check for impossible things.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v2 3/3] firmware: xilinx: Add sysfs support for feature config
Date: Tue, 14 Sep 2021 11:21:17 +0200	[thread overview]
Message-ID: <YUBpjUGaB3G72wRa@kroah.com> (raw)
In-Reply-To: <20210913083955.27146-4-ronak.jain@xilinx.com>

On Mon, Sep 13, 2021 at 01:39:55AM -0700, Ronak Jain wrote:
> Add support for sysfs interface for runtime features configuration.
>  The user can configure the features at runtime. First the user need
>  to select the config id of the supported features and then the user
>  can configure the parameters of the feature based on the config id.
>  So far the support is added for the over temperature and external
>  watchdog features.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
> ---
> Changes in v2:
> - Update commit message
> ---
>  drivers/firmware/xilinx/zynqmp.c | 71 ++++++++++++++++++++++++++++++++
>  1 file changed, 71 insertions(+)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 875d13bc1a57..a1434dd368f2 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1361,6 +1361,75 @@ static DEVICE_ATTR_RW(pggs1);
>  static DEVICE_ATTR_RW(pggs2);
>  static DEVICE_ATTR_RW(pggs3);
>  
> +static atomic_t feature_conf_id;

Why does this have to be an atomic?

And shouldn't this be per-device, not global to all devices in the
system?

> +
> +static ssize_t feature_config_id_show(struct device *device,
> +				      struct device_attribute *attr,
> +				      char *buf)
> +{
> +	return sysfs_emit(buf, "%d\n", atomic_read(&feature_conf_id));
> +}
> +
> +static ssize_t feature_config_id_store(struct device *device,
> +				       struct device_attribute *attr,
> +				       const char *buf, size_t count)
> +{
> +	u32 config_id;
> +	int ret;
> +
> +	if (!buf)
> +		return -EINVAL;

How can there ever be a NULL buffer?

No need to check for impossible things.

thanks,

greg k-h

  reply	other threads:[~2021-09-14  9:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  8:39 [PATCH v2 0/3] Add support for runtime features Ronak Jain
2021-09-13  8:39 ` Ronak Jain
2021-09-13  8:39 ` [PATCH v2 1/3] firmware: xilinx: " Ronak Jain
2021-09-13  8:39   ` Ronak Jain
2021-09-13  8:39 ` [PATCH v2 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
2021-09-13  8:39   ` Ronak Jain
2021-09-16 23:37   ` Punit Agrawal
2021-09-16 23:37     ` Punit Agrawal
2021-09-13  8:39 ` [PATCH v2 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
2021-09-13  8:39   ` Ronak Jain
2021-09-14  9:21   ` Greg KH [this message]
2021-09-14  9:21     ` Greg KH
2021-09-15  6:16     ` Ronak Jain
2021-09-15  6:16       ` Ronak Jain
2021-09-15  6:29       ` Greg KH
2021-09-15  6:29         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUBpjUGaB3G72wRa@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=ronak.jain@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.