From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
o.rempel@pengutronix.de, andrew@lunn.ch,
john.weber@technexion.com
Subject: Re: [PATCH] ARM: dts: Fix Ethernet support
Date: Tue, 14 Sep 2021 16:06:53 +0100 [thread overview]
Message-ID: <YUC6jUcTLbsAjLsS@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210914144946.2010617-1-festevam@gmail.com>
On Tue, Sep 14, 2021 at 11:49:46AM -0300, Fabio Estevam wrote:
> Currently, it is no longer possible to retrieve a DHCP address
> on the imx6qdl-pico board.
>
> This issue has been exposed by commit f5d9aa79dfdf ("ARM: imx6q:
> remove clk-out fixup for the Atheros AR8031 and AR8035 PHYs").
>
> Fix it by describing the qca,clk-out-frequency property as suggested
> by the commit above.
>
> Fixes: 98670a0bb0ef14bbb3 ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-pico.dtsi | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-pico.dtsi b/arch/arm/boot/dts/imx6qdl-pico.dtsi
> index 5de4ccb97916..0a55e1e583ae 100644
> --- a/arch/arm/boot/dts/imx6qdl-pico.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-pico.dtsi
> @@ -175,8 +175,19 @@ &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rgmii-id";
> - phy-reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
> status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + phy: ethernet-phy@1 {
> + reg = <1>;
> + qca,clk-out-frequency = <125000000>;
> + reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + };
> + };
> };
>
> &hdmi {
Do you really want to move the reset properties? Have you tested kexec?
Moving the reset into the phy node without a compatible risks not being
able to read the PHY ID and not being able to detect the presence of
the PHY.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-14 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:49 [PATCH] ARM: dts: Fix Ethernet support Fabio Estevam
2021-09-14 15:06 ` Russell King (Oracle) [this message]
2021-09-14 16:00 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUC6jUcTLbsAjLsS@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=festevam@gmail.com \
--cc=john.weber@technexion.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.