From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib/tst_net.sh: ignore errors on rhost with -i option in tst_net_run()
Date: Wed, 15 Sep 2021 11:35:26 +0200 [thread overview]
Message-ID: <YUG+XlCf83X4TP26@pevik> (raw)
In-Reply-To: <82b63456-0ba6-dedc-9688-cc74c40e4982@bell-sw.com>
Hi Alexey,
> Hi Petr,
> On 14.09.2021 08:46, Petr Vorel wrote:
> > Hi Alexey,
> > good catch!
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > BTW are you going to send patch / report it to busybox? (I haven't find anything on ML)
> Looking at busybox history, seems expected from the beginning there:
> commit 64309f8669f08f2c3c16a3b5bf82d9cae84ec388
> Author: Denis Vlasenko <vda.linux@googlemail.com>
> Date: Thu Nov 29 06:40:28 2007 +0000
> sysctl: add -e: supress warnings about invalid key (Jeremy Kerr <jk@ozlabs.org>)
> -e option unsets FLAG_SHOW_KEY_ERRORS.
> busybox/sysctl: "-e Don't warn about unknown keys"
> (Though, -q option can be used for that, which was added later, in 2012)
> vs
> procps/sysctl: "-e, --ignore ignore unknown variables errors"
Hm, IMHO it'd be good change to -e have 0 exit status. Because that's the
behavior in procps-ng (tested on 3.3.17).
If you do it, please let me know and/or Cc me in your patch. Otherwise I'll do it.
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib/tst_net.sh: ignore errors on rhost with -i option in tst_net_run()
Date: Wed, 15 Sep 2021 11:35:26 +0200 [thread overview]
Message-ID: <YUG+XlCf83X4TP26@pevik> (raw)
Message-ID: <20210915093526.Ytgp-LxHEp_UuY1-2Dz7ci8JpfOUSPuJ8NH2ZGM3M9M@z> (raw)
In-Reply-To: <82b63456-0ba6-dedc-9688-cc74c40e4982@bell-sw.com>
Hi Alexey,
> Hi Petr,
> On 14.09.2021 08:46, Petr Vorel wrote:
> > Hi Alexey,
> > good catch!
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > BTW are you going to send patch / report it to busybox? (I haven't find anything on ML)
> Looking at busybox history, seems expected from the beginning there:
> commit 64309f8669f08f2c3c16a3b5bf82d9cae84ec388
> Author: Denis Vlasenko <vda.linux@googlemail.com>
> Date: Thu Nov 29 06:40:28 2007 +0000
> sysctl: add -e: supress warnings about invalid key (Jeremy Kerr <jk@ozlabs.org>)
> -e option unsets FLAG_SHOW_KEY_ERRORS.
> busybox/sysctl: "-e Don't warn about unknown keys"
> (Though, -q option can be used for that, which was added later, in 2012)
> vs
> procps/sysctl: "-e, --ignore ignore unknown variables errors"
Hm, IMHO it'd be good change to -e have 0 exit status. Because that's the
behavior in procps-ng (tested on 3.3.17).
If you do it, please let me know and/or Cc me in your patch. Otherwise I'll do it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-15 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:39 [LTP] [PATCH 1/2] lib/tst_net.sh: ignore errors on rhost with -i option in tst_net_run() Alexey Kodanev
2021-09-13 12:39 ` Alexey Kodanev
2021-09-13 12:39 ` [LTP] [PATCH 2/2] lib/tst_net.sh: disable ipv6_dad work on test interfaces Alexey Kodanev
2021-09-13 12:39 ` Alexey Kodanev
2021-09-14 5:48 ` Petr Vorel
2021-09-14 5:48 ` Petr Vorel
2021-11-16 9:20 ` suy.fnst
2021-09-14 5:46 ` [LTP] [PATCH 1/2] lib/tst_net.sh: ignore errors on rhost with -i option in tst_net_run() Petr Vorel
2021-09-14 5:46 ` Petr Vorel
2021-09-14 9:42 ` Alexey Kodanev
2021-09-14 9:42 ` Alexey Kodanev
2021-09-15 9:35 ` Petr Vorel [this message]
2021-09-15 9:35 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUG+XlCf83X4TP26@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.