All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-phy@lists.infradead.org, "Rob Herring" <robh+dt@kernel.org>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	devicetree@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Chunfeng Yun" <chunfeng.yun@mediatek.com>
Subject: Re: [PATCH 2/4] dt-bindings: phy: brcm,ns-usb2-phy: bind just a PHY block
Date: Tue, 21 Sep 2021 15:19:35 -0500	[thread overview]
Message-ID: <YUo+V6yItABkQI1S@robh.at.kernel.org> (raw)
In-Reply-To: <20210913080024.6951-2-zajec5@gmail.com>

On Mon, 13 Sep 2021 10:00:22 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> The old binding was covering the whole DMU block space (DMU block
> contains CRU block which contains USB PHY). It was a bad design,
> overkill and a non-generic solution.
> 
> Northstar's USB 2.0 PHY is a small block (part of the CRU MFD) and
> binding should be designed to represent that properly. Rework the
> binding to map just PHY with the "reg" property and use syscon to
> reference shared register that controls block access.
> 
> The old binding is deprecated now.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/phy/bcm-ns-usb2-phy.yaml         | 25 ++++++++++++++-----
>  1 file changed, 19 insertions(+), 6 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-phy@lists.infradead.org, "Rob Herring" <robh+dt@kernel.org>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	devicetree@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Chunfeng Yun" <chunfeng.yun@mediatek.com>
Subject: Re: [PATCH 2/4] dt-bindings: phy: brcm,ns-usb2-phy: bind just a PHY block
Date: Tue, 21 Sep 2021 15:19:35 -0500	[thread overview]
Message-ID: <YUo+V6yItABkQI1S@robh.at.kernel.org> (raw)
In-Reply-To: <20210913080024.6951-2-zajec5@gmail.com>

On Mon, 13 Sep 2021 10:00:22 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> The old binding was covering the whole DMU block space (DMU block
> contains CRU block which contains USB PHY). It was a bad design,
> overkill and a non-generic solution.
> 
> Northstar's USB 2.0 PHY is a small block (part of the CRU MFD) and
> binding should be designed to represent that properly. Rework the
> binding to map just PHY with the "reg" property and use syscon to
> reference shared register that controls block access.
> 
> The old binding is deprecated now.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/phy/bcm-ns-usb2-phy.yaml         | 25 ++++++++++++++-----
>  1 file changed, 19 insertions(+), 6 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2021-09-21 20:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  8:00 [PATCH 1/4] dt-bindings: mfd: brcm,cru: add clkset syscon Rafał Miłecki
2021-09-13  8:00 ` Rafał Miłecki
2021-09-13  8:00 ` [PATCH 2/4] dt-bindings: phy: brcm, ns-usb2-phy: bind just a PHY block Rafał Miłecki
2021-09-13  8:00   ` [PATCH 2/4] dt-bindings: phy: brcm,ns-usb2-phy: " Rafał Miłecki
2021-09-21 20:19   ` Rob Herring [this message]
2021-09-21 20:19     ` Rob Herring
2021-10-01 10:08   ` Vinod Koul
2021-10-01 10:08     ` Vinod Koul
2021-09-13  8:00 ` [PATCH 3/4] dt-bindings: mfd: brcm,cru: add USB 2.0 PHY Rafał Miłecki
2021-09-13  8:00   ` Rafał Miłecki
2021-09-21 20:19   ` Rob Herring
2021-09-21 20:19     ` Rob Herring
2021-09-22  7:57   ` Lee Jones
2021-09-22  7:57     ` Lee Jones
2021-09-23 15:01     ` Rob Herring
2021-09-23 15:01       ` Rob Herring
2021-09-23 20:06       ` Lee Jones
2021-09-23 20:06         ` Lee Jones
2021-09-13  8:00 ` [PATCH 4/4] phy: bcm-ns-usb2: support updated DT binding with PHY reg space Rafał Miłecki
2021-09-13  8:00   ` Rafał Miłecki
2021-09-21 20:19 ` [PATCH 1/4] dt-bindings: mfd: brcm,cru: add clkset syscon Rob Herring
2021-09-21 20:19   ` Rob Herring
2021-09-22  7:57 ` Lee Jones
2021-09-22  7:57   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUo+V6yItABkQI1S@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.