All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: tony@atomide.com, grygorii.strashko@ti.com, nm@ti.com,
	lokeshvutla@ti.com, nsekhar@ti.com,
	krzysztof.kozlowski@canonical.com, miquel.raynal@bootlin.com,
	devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/8] dt-bindings: mtd: ti, gpmc-onenand: Convert to yaml
Date: Tue, 21 Sep 2021 15:45:14 -0500	[thread overview]
Message-ID: <YUpEWslQSEbppnBk@robh.at.kernel.org> (raw)
In-Reply-To: <20210914122705.15421-7-rogerq@kernel.org>

On Tue, Sep 14, 2021 at 03:27:03PM +0300, Roger Quadros wrote:
> Convert gpmc-onenand.txt to ti,gpmc-onenand.yaml.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  .../devicetree/bindings/mtd/gpmc-onenand.txt  | 48 -----------
>  .../bindings/mtd/ti,gpmc-onenand.yaml         | 81 +++++++++++++++++++
>  2 files changed, 81 insertions(+), 48 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
>  create mode 100644 Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> deleted file mode 100644
> index e9f01a963a0a..000000000000
> --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -Device tree bindings for GPMC connected OneNANDs
> -
> -GPMC connected OneNAND (found on OMAP boards) are represented as child nodes of
> -the GPMC controller with a name of "onenand".
> -
> -All timing relevant properties as well as generic gpmc child properties are
> -explained in a separate documents - please refer to
> -Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt
> -
> -Required properties:
> -
> - - compatible:		"ti,omap2-onenand"
> - - reg:			The CS line the peripheral is connected to
> - - gpmc,device-width:	Width of the ONENAND device connected to the GPMC
> -			in bytes. Must be 1 or 2.
> -
> -Optional properties:
> -
> - - int-gpios:		GPIO specifier for the INT pin.
> -
> -For inline partition table parsing (optional):
> -
> - - #address-cells: should be set to 1
> - - #size-cells: should be set to 1
> -
> -Example for an OMAP3430 board:
> -
> -	gpmc: gpmc@6e000000 {
> -		compatible = "ti,omap3430-gpmc";
> -		ti,hwmods = "gpmc";
> -		reg = <0x6e000000 0x1000000>;
> -		interrupts = <20>;
> -		gpmc,num-cs = <8>;
> -		gpmc,num-waitpins = <4>;
> -		#address-cells = <2>;
> -		#size-cells = <1>;
> -
> -		onenand@0 {
> -			compatible = "ti,omap2-onenand";
> -			reg = <0 0 0>; /* CS0, offset 0 */
> -			gpmc,device-width = <2>;
> -
> -			#address-cells = <1>;
> -			#size-cells = <1>;
> -
> -			/* partitions go here */
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> new file mode 100644
> index 000000000000..42149a9c3a8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ti,gpmc-onenand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OneNAND over Texas Instruments GPMC bus.
> +
> +maintainers:
> +  - Tony Lindgren <tony@atomide.com>
> +  - Roger Quadros <rogerq@kernel.org>
> +
> +description:
> +  GPMC connected OneNAND (found on OMAP boards) are represented
> +  as child nodes of the GPMC controller.
> +
> +properties:
> +  compatible:
> +    const: ti,omap2-onenand
> +
> +  reg:
> +    items:
> +      - description: |
> +          Chip Select number, register offset and size of
> +          OneNAND register window.
> +
> +  "#address-cells": true
> +
> +  "#size-cells": true
> +
> +  int-gpios:
> +    description: GPIO specifier for the INT pin.
> +
> +patternProperties:
> +  "@[0-9a-f]+$":
> +    $ref: "/schemas/mtd/partitions/partition.yaml"
> +
> +allOf:
> +  - $ref: "/schemas/memory-controllers/ti,gpmc-child.yaml"
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    gpmc: memory-controller@6e000000 {
> +      compatible = "ti,omap3430-gpmc";
> +      reg = <0x6e000000 0x02d0>;
> +      interrupts = <20>;
> +      gpmc,num-cs = <8>;
> +      gpmc,num-waitpins = <4>;
> +      clocks = <&l3s_clkctrl>;
> +      clock-names = "fck";
> +      #address-cells = <2>;
> +      #size-cells = <1>;
> +
> +      ranges = <0 0 0x01000000 0x01000000>,   /* 16 MB for OneNAND */
> +               <1 0 0x02000000 0x01000000>;   /* 16 MB for smc91c96 */
> +
> +      onenand@0,0 {
> +        compatible = "ti,omap2-onenand";
> +        reg = <0 0 0x20000>;    /* CS0, offset 0, IO size 128K */
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        partition@0 {
> +          label = "bootloader";
> +          reg = <0x00000000 0x00100000>;
> +        };
> +
> +        partition@1 {

partition@100000

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> +          label = "config";
> +          reg = <0x00100000 0x002c0000>;
> +        };
> +      };
> +    };
> -- 
> 2.17.1
> 
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: tony@atomide.com, grygorii.strashko@ti.com, nm@ti.com,
	lokeshvutla@ti.com, nsekhar@ti.com,
	krzysztof.kozlowski@canonical.com, miquel.raynal@bootlin.com,
	devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/8] dt-bindings: mtd: ti,gpmc-onenand: Convert to yaml
Date: Tue, 21 Sep 2021 15:45:14 -0500	[thread overview]
Message-ID: <YUpEWslQSEbppnBk@robh.at.kernel.org> (raw)
In-Reply-To: <20210914122705.15421-7-rogerq@kernel.org>

On Tue, Sep 14, 2021 at 03:27:03PM +0300, Roger Quadros wrote:
> Convert gpmc-onenand.txt to ti,gpmc-onenand.yaml.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  .../devicetree/bindings/mtd/gpmc-onenand.txt  | 48 -----------
>  .../bindings/mtd/ti,gpmc-onenand.yaml         | 81 +++++++++++++++++++
>  2 files changed, 81 insertions(+), 48 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
>  create mode 100644 Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> deleted file mode 100644
> index e9f01a963a0a..000000000000
> --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -Device tree bindings for GPMC connected OneNANDs
> -
> -GPMC connected OneNAND (found on OMAP boards) are represented as child nodes of
> -the GPMC controller with a name of "onenand".
> -
> -All timing relevant properties as well as generic gpmc child properties are
> -explained in a separate documents - please refer to
> -Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt
> -
> -Required properties:
> -
> - - compatible:		"ti,omap2-onenand"
> - - reg:			The CS line the peripheral is connected to
> - - gpmc,device-width:	Width of the ONENAND device connected to the GPMC
> -			in bytes. Must be 1 or 2.
> -
> -Optional properties:
> -
> - - int-gpios:		GPIO specifier for the INT pin.
> -
> -For inline partition table parsing (optional):
> -
> - - #address-cells: should be set to 1
> - - #size-cells: should be set to 1
> -
> -Example for an OMAP3430 board:
> -
> -	gpmc: gpmc@6e000000 {
> -		compatible = "ti,omap3430-gpmc";
> -		ti,hwmods = "gpmc";
> -		reg = <0x6e000000 0x1000000>;
> -		interrupts = <20>;
> -		gpmc,num-cs = <8>;
> -		gpmc,num-waitpins = <4>;
> -		#address-cells = <2>;
> -		#size-cells = <1>;
> -
> -		onenand@0 {
> -			compatible = "ti,omap2-onenand";
> -			reg = <0 0 0>; /* CS0, offset 0 */
> -			gpmc,device-width = <2>;
> -
> -			#address-cells = <1>;
> -			#size-cells = <1>;
> -
> -			/* partitions go here */
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> new file mode 100644
> index 000000000000..42149a9c3a8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ti,gpmc-onenand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OneNAND over Texas Instruments GPMC bus.
> +
> +maintainers:
> +  - Tony Lindgren <tony@atomide.com>
> +  - Roger Quadros <rogerq@kernel.org>
> +
> +description:
> +  GPMC connected OneNAND (found on OMAP boards) are represented
> +  as child nodes of the GPMC controller.
> +
> +properties:
> +  compatible:
> +    const: ti,omap2-onenand
> +
> +  reg:
> +    items:
> +      - description: |
> +          Chip Select number, register offset and size of
> +          OneNAND register window.
> +
> +  "#address-cells": true
> +
> +  "#size-cells": true
> +
> +  int-gpios:
> +    description: GPIO specifier for the INT pin.
> +
> +patternProperties:
> +  "@[0-9a-f]+$":
> +    $ref: "/schemas/mtd/partitions/partition.yaml"
> +
> +allOf:
> +  - $ref: "/schemas/memory-controllers/ti,gpmc-child.yaml"
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    gpmc: memory-controller@6e000000 {
> +      compatible = "ti,omap3430-gpmc";
> +      reg = <0x6e000000 0x02d0>;
> +      interrupts = <20>;
> +      gpmc,num-cs = <8>;
> +      gpmc,num-waitpins = <4>;
> +      clocks = <&l3s_clkctrl>;
> +      clock-names = "fck";
> +      #address-cells = <2>;
> +      #size-cells = <1>;
> +
> +      ranges = <0 0 0x01000000 0x01000000>,   /* 16 MB for OneNAND */
> +               <1 0 0x02000000 0x01000000>;   /* 16 MB for smc91c96 */
> +
> +      onenand@0,0 {
> +        compatible = "ti,omap2-onenand";
> +        reg = <0 0 0x20000>;    /* CS0, offset 0, IO size 128K */
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        partition@0 {
> +          label = "bootloader";
> +          reg = <0x00000000 0x00100000>;
> +        };
> +
> +        partition@1 {

partition@100000

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> +          label = "config";
> +          reg = <0x00100000 0x002c0000>;
> +        };
> +      };
> +    };
> -- 
> 2.17.1
> 
> 

  reply	other threads:[~2021-09-21 20:45 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 12:26 [PATCH v4 0/8] dt-bindings: memory-controllers: ti, gpmc: Convert to yaml Roger Quadros
2021-09-14 12:26 ` [PATCH v4 0/8] dt-bindings: memory-controllers: ti,gpmc: " Roger Quadros
2021-09-14 12:26 ` [PATCH v4 1/8] ARM: dts: omap: Fixup GPMC child nodes Roger Quadros
2021-09-14 12:26   ` Roger Quadros
2021-09-15  6:53   ` Krzysztof Kozlowski
2021-09-15  6:53     ` Krzysztof Kozlowski
2021-09-14 12:26 ` [PATCH v4 2/8] dt-bindings: mtd: Remove gpmc-nor.txt Roger Quadros
2021-09-14 12:26   ` Roger Quadros
2021-09-21 20:38   ` Rob Herring
2021-09-21 20:38     ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 3/8] dt-bindings: net: Remove gpmc-eth.txt Roger Quadros
2021-09-14 12:27   ` Roger Quadros
2021-09-21 20:38   ` Rob Herring
2021-09-21 20:38     ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 4/8] dt-bindings: memory-controllers: Introduce ti, gpmc-child Roger Quadros
2021-09-14 12:27   ` [PATCH v4 4/8] dt-bindings: memory-controllers: Introduce ti,gpmc-child Roger Quadros
2021-09-21 20:40   ` Rob Herring
2021-09-21 20:40     ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 5/8] dt-bindings: mtd: ti,gpmc-nand: Convert to yaml Roger Quadros
2021-09-14 12:27   ` Roger Quadros
2021-09-21 20:43   ` Rob Herring
2021-09-21 20:43     ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 6/8] dt-bindings: mtd: ti,gpmc-onenand: " Roger Quadros
2021-09-14 12:27   ` Roger Quadros
2021-09-21 20:45   ` Rob Herring [this message]
2021-09-21 20:45     ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti, gpmc: " Roger Quadros
2021-09-14 12:27   ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti,gpmc: " Roger Quadros
2021-09-15  7:20   ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti, gpmc: " Krzysztof Kozlowski
2021-09-15  7:20     ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti,gpmc: " Krzysztof Kozlowski
2021-10-07  8:03     ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti, gpmc: " Roger Quadros
2021-10-07  8:03       ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti,gpmc: " Roger Quadros
2021-09-21 20:47   ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti, gpmc: " Rob Herring
2021-09-21 20:47     ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti,gpmc: " Rob Herring
2021-09-14 12:27 ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc, device-width" DT property is optional Roger Quadros
2021-09-14 12:27   ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" " Roger Quadros
2021-09-15  7:12   ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc, device-width" " Krzysztof Kozlowski
2021-09-15  7:12     ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" " Krzysztof Kozlowski
2021-09-15  8:47     ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc, device-width" " Roger Quadros
2021-09-15  8:47       ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" " Roger Quadros
2021-09-15  9:05       ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc, device-width" " Krzysztof Kozlowski
2021-09-15  9:05         ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUpEWslQSEbppnBk@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.