From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com,
ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org,
agk@redhat.com, josef@toxicpanda.com
Cc: linux-block@vger.kernel.org, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
ming.lei@redhat.com, hch@infradead.org, dm-devel@redhat.com,
nbd@other.debian.org
Subject: Re: [dm-devel] [PATCH v4 4/6] dm: add add_disk() error handling
Date: Wed, 6 Oct 2021 09:17:50 -0400 [thread overview]
Message-ID: <YV2h/iA79JhMJt07@redhat.com> (raw)
In-Reply-To: <20210927215958.1062466-5-mcgrof@kernel.org>
On Mon, Sep 27 2021 at 5:59P -0400,
Luis Chamberlain <mcgrof@kernel.org> wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> There are two calls to dm_setup_md_queue() which can fail then,
> one on dm_early_create() and we can easily see that the error path
> there calls dm_destroy in the error path. The other use case is on
> the ioctl table_load case. If that fails userspace needs to call
> the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
> failure.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com,
ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org,
agk@redhat.com, josef@toxicpanda.com
Cc: hch@infradead.org, hare@suse.de, bvanassche@acm.org,
ming.lei@redhat.com, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org,
dm-devel@redhat.com, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] dm: add add_disk() error handling
Date: Wed, 6 Oct 2021 09:17:50 -0400 [thread overview]
Message-ID: <YV2h/iA79JhMJt07@redhat.com> (raw)
In-Reply-To: <20210927215958.1062466-5-mcgrof@kernel.org>
On Mon, Sep 27 2021 at 5:59P -0400,
Luis Chamberlain <mcgrof@kernel.org> wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> There are two calls to dm_setup_md_queue() which can fail then,
> one on dm_early_create() and we can easily see that the error path
> there calls dm_destroy in the error path. The other use case is on
> the ioctl table_load case. If that fails userspace needs to call
> the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
> failure.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com,
ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org,
agk@redhat.com, josef@toxicpanda.com
Cc: hch@infradead.org, hare@suse.de, bvanassche@acm.org,
ming.lei@redhat.com, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org,
dm-devel@redhat.com, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] dm: add add_disk() error handling
Date: Wed, 6 Oct 2021 09:17:50 -0400 [thread overview]
Message-ID: <YV2h/iA79JhMJt07@redhat.com> (raw)
In-Reply-To: <20210927215958.1062466-5-mcgrof@kernel.org>
On Mon, Sep 27 2021 at 5:59P -0400,
Luis Chamberlain <mcgrof@kernel.org> wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> There are two calls to dm_setup_md_queue() which can fail then,
> one on dm_early_create() and we can easily see that the error path
> there calls dm_destroy in the error path. The other use case is on
> the ioctl table_load case. If that fails userspace needs to call
> the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
> failure.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-10-06 13:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 21:59 [dm-devel] [PATCH v4 0/6] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` [dm-devel] [PATCH v4 1/6] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` [dm-devel] [PATCH v4 2/6] scsi/sr: " Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` [dm-devel] [PATCH v4 3/6] md: " Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` [dm-devel] [PATCH v4 4/6] dm: add add_disk() error handling Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-10-06 13:17 ` Mike Snitzer [this message]
2021-10-06 13:17 ` Mike Snitzer
2021-10-06 13:17 ` Mike Snitzer
2021-09-27 21:59 ` [dm-devel] [PATCH v4 5/6] loop: add error handling support for add_disk() Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 22:28 ` [dm-devel] " Jens Axboe
2021-09-27 22:28 ` Jens Axboe
2021-09-27 22:28 ` Jens Axboe
2021-09-27 21:59 ` [dm-devel] [PATCH v4 6/6] nbd: " Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 21:59 ` Luis Chamberlain
2021-09-27 22:28 ` [dm-devel] " Jens Axboe
2021-09-27 22:28 ` Jens Axboe
2021-09-27 22:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV2h/iA79JhMJt07@redhat.com \
--to=snitzer@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=agk@redhat.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=sagi@grimberg.me \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.