From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Alex Shi <alexs@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Shuah Khan <shuah@kernel.org>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
x86@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v1 1/6] mm/memory_hotplug: remove CONFIG_X86_64_ACPI_NUMA dependency from CONFIG_MEMORY_HOTPLUG
Date: Thu, 7 Oct 2021 10:09:03 +0200 [thread overview]
Message-ID: <YV6rH31mpJG0WLLQ@localhost.localdomain> (raw)
In-Reply-To: <20210929143600.49379-2-david@redhat.com>
On Wed, Sep 29, 2021 at 04:35:55PM +0200, David Hildenbrand wrote:
> SPARSEMEM is the only possible memory model for x86-64, FLATMEM is not
> possible:
> config ARCH_FLATMEM_ENABLE
> def_bool y
> depends on X86_32 && !NUMA
>
> And X86_64_ACPI_NUMA (obviously) only supports x86-64:
> config X86_64_ACPI_NUMA
> def_bool y
> depends on X86_64 && NUMA && ACPI && PCI
>
> Let's just remove the CONFIG_X86_64_ACPI_NUMA dependency, as it does no
> longer make sense.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index d16ba9249bc5..b7fb3f0b485e 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -123,7 +123,7 @@ config ARCH_ENABLE_MEMORY_HOTPLUG
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> select MEMORY_ISOLATION
> - depends on SPARSEMEM || X86_64_ACPI_NUMA
> + depends on SPARSEMEM
> depends on ARCH_ENABLE_MEMORY_HOTPLUG
> depends on 64BIT || BROKEN
> select NUMA_KEEP_MEMINFO if NUMA
> --
> 2.31.1
>
>
--
Oscar Salvador
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Jason Wang <jasowang@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Paul Mackerras <paulus@samba.org>,
linux-kselftest@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Shuah Khan <shuah@kernel.org>, Alex Shi <alexs@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v1 1/6] mm/memory_hotplug: remove CONFIG_X86_64_ACPI_NUMA dependency from CONFIG_MEMORY_HOTPLUG
Date: Thu, 7 Oct 2021 10:09:03 +0200 [thread overview]
Message-ID: <YV6rH31mpJG0WLLQ@localhost.localdomain> (raw)
In-Reply-To: <20210929143600.49379-2-david@redhat.com>
On Wed, Sep 29, 2021 at 04:35:55PM +0200, David Hildenbrand wrote:
> SPARSEMEM is the only possible memory model for x86-64, FLATMEM is not
> possible:
> config ARCH_FLATMEM_ENABLE
> def_bool y
> depends on X86_32 && !NUMA
>
> And X86_64_ACPI_NUMA (obviously) only supports x86-64:
> config X86_64_ACPI_NUMA
> def_bool y
> depends on X86_64 && NUMA && ACPI && PCI
>
> Let's just remove the CONFIG_X86_64_ACPI_NUMA dependency, as it does no
> longer make sense.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index d16ba9249bc5..b7fb3f0b485e 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -123,7 +123,7 @@ config ARCH_ENABLE_MEMORY_HOTPLUG
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> select MEMORY_ISOLATION
> - depends on SPARSEMEM || X86_64_ACPI_NUMA
> + depends on SPARSEMEM
> depends on ARCH_ENABLE_MEMORY_HOTPLUG
> depends on 64BIT || BROKEN
> select NUMA_KEEP_MEMINFO if NUMA
> --
> 2.31.1
>
>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2021-10-07 8:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 14:35 [PATCH v1 0/6] mm/memory_hotplug: Kconfig and 32 bit cleanups David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` [PATCH v1 1/6] mm/memory_hotplug: remove CONFIG_X86_64_ACPI_NUMA dependency from CONFIG_MEMORY_HOTPLUG David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-10-07 8:09 ` Oscar Salvador [this message]
2021-10-07 8:09 ` Oscar Salvador
2021-09-29 14:35 ` [PATCH v1 2/6] mm/memory_hotplug: remove CONFIG_MEMORY_HOTPLUG_SPARSE David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-10-05 13:43 ` Greg Kroah-Hartman
2021-10-05 13:43 ` Greg Kroah-Hartman
2021-10-05 13:43 ` Greg Kroah-Hartman
2021-10-05 14:22 ` Shuah Khan
2021-10-05 14:22 ` Shuah Khan
2021-10-07 8:20 ` Oscar Salvador
2021-10-07 8:20 ` Oscar Salvador
2021-09-29 14:35 ` [PATCH v1 3/6] mm/memory_hotplug: restrict CONFIG_MEMORY_HOTPLUG to 64 bit David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-10-07 9:02 ` Oscar Salvador
2021-10-07 9:02 ` Oscar Salvador
2021-09-29 14:35 ` [PATCH v1 4/6] mm/memory_hotplug: remove HIGHMEM leftovers David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-10-07 9:13 ` Oscar Salvador
2021-10-07 9:13 ` Oscar Salvador
2021-09-29 14:35 ` [PATCH v1 5/6] mm/memory_hotplug: remove stale function declarations David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-09-29 14:35 ` David Hildenbrand
2021-10-07 9:14 ` Oscar Salvador
2021-10-07 9:14 ` Oscar Salvador
2021-09-29 14:36 ` [PATCH v1 6/6] x86: remove memory hotplug support on X86_32 David Hildenbrand
2021-09-29 14:36 ` David Hildenbrand
2021-09-29 14:36 ` David Hildenbrand
2021-10-07 9:15 ` Oscar Salvador
2021-10-07 9:15 ` Oscar Salvador
2021-10-07 9:27 ` David Hildenbrand
2021-10-07 9:27 ` David Hildenbrand
2021-10-07 9:27 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV6rH31mpJG0WLLQ@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.