All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string
Date: Mon, 27 Sep 2021 13:59:11 -0500	[thread overview]
Message-ID: <YVIUf7/4ukMcrOb9@robh.at.kernel.org> (raw)
In-Reply-To: <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com>

On Wed, Sep 22, 2021 at 06:31:16PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,ast2600-emmc" compatible string for the sake of
> distinguishing between SD and eMMC device.

Why?

Is the h/w block different? We already have properties to handle some of 
the eMMC specifics. Also, you can have a child node for the eMMC device 
if you need that.

> 
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 5bb66849df65..41105cd104c6 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -52,6 +52,7 @@ patternProperties:
>            - aspeed,ast2400-sdhci
>            - aspeed,ast2500-sdhci
>            - aspeed,ast2600-sdhci
> +          - aspeed,ast2600-emmc
>        reg:
>          maxItems: 1
>          description: The SDHCI registers
> -- 
> 2.17.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Cc: joel@jms.id.au, mturquette@baylibre.com, sboyd@kernel.org,
	adrian.hunter@intel.com, linux-aspeed@lists.ozlabs.org,
	openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	andrew@aj.id.au, BMC-SW@aspeedtech.com,
	steven_lee@aspeedtech.com
Subject: Re: [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string
Date: Mon, 27 Sep 2021 13:59:11 -0500	[thread overview]
Message-ID: <YVIUf7/4ukMcrOb9@robh.at.kernel.org> (raw)
In-Reply-To: <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com>

On Wed, Sep 22, 2021 at 06:31:16PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,ast2600-emmc" compatible string for the sake of
> distinguishing between SD and eMMC device.

Why?

Is the h/w block different? We already have properties to handle some of 
the eMMC specifics. Also, you can have a child node for the eMMC device 
if you need that.

> 
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 5bb66849df65..41105cd104c6 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -52,6 +52,7 @@ patternProperties:
>            - aspeed,ast2400-sdhci
>            - aspeed,ast2500-sdhci
>            - aspeed,ast2600-sdhci
> +          - aspeed,ast2600-emmc
>        reg:
>          maxItems: 1
>          description: The SDHCI registers
> -- 
> 2.17.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com,
	sboyd@kernel.org, steven_lee@aspeedtech.com,
	openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org,
	adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
	andrew@aj.id.au, mturquette@baylibre.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string
Date: Mon, 27 Sep 2021 13:59:11 -0500	[thread overview]
Message-ID: <YVIUf7/4ukMcrOb9@robh.at.kernel.org> (raw)
In-Reply-To: <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com>

On Wed, Sep 22, 2021 at 06:31:16PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,ast2600-emmc" compatible string for the sake of
> distinguishing between SD and eMMC device.

Why?

Is the h/w block different? We already have properties to handle some of 
the eMMC specifics. Also, you can have a child node for the eMMC device 
if you need that.

> 
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 5bb66849df65..41105cd104c6 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -52,6 +52,7 @@ patternProperties:
>            - aspeed,ast2400-sdhci
>            - aspeed,ast2500-sdhci
>            - aspeed,ast2600-sdhci
> +          - aspeed,ast2600-emmc
>        reg:
>          maxItems: 1
>          description: The SDHCI registers
> -- 
> 2.17.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Cc: joel@jms.id.au, mturquette@baylibre.com, sboyd@kernel.org,
	adrian.hunter@intel.com, linux-aspeed@lists.ozlabs.org,
	openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	andrew@aj.id.au, BMC-SW@aspeedtech.com,
	steven_lee@aspeedtech.com
Subject: Re: [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string
Date: Mon, 27 Sep 2021 13:59:11 -0500	[thread overview]
Message-ID: <YVIUf7/4ukMcrOb9@robh.at.kernel.org> (raw)
In-Reply-To: <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com>

On Wed, Sep 22, 2021 at 06:31:16PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,ast2600-emmc" compatible string for the sake of
> distinguishing between SD and eMMC device.

Why?

Is the h/w block different? We already have properties to handle some of 
the eMMC specifics. Also, you can have a child node for the eMMC device 
if you need that.

> 
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 5bb66849df65..41105cd104c6 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -52,6 +52,7 @@ patternProperties:
>            - aspeed,ast2400-sdhci
>            - aspeed,ast2500-sdhci
>            - aspeed,ast2600-sdhci
> +          - aspeed,ast2600-emmc
>        reg:
>          maxItems: 1
>          description: The SDHCI registers
> -- 
> 2.17.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-27 18:59 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 10:31 [PATCH 00/10] ASPEED SD/eMMC controller clock configuration Chin-Ting Kuo
2021-09-22 10:31 ` Chin-Ting Kuo
2021-09-22 10:31 ` Chin-Ting Kuo
2021-09-22 10:31 ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 01/10] clk: aspeed: ast2600: Porting sdhci clock source Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-23  0:02   ` Joel Stanley
2021-09-23  0:02     ` Joel Stanley
2021-09-23  0:02     ` Joel Stanley
2021-09-23  0:02     ` Joel Stanley
2021-09-23  5:31     ` Chin-Ting Kuo
2021-09-23  5:31       ` Chin-Ting Kuo
2021-09-23  5:31       ` Chin-Ting Kuo
2021-09-23  5:31       ` Chin-Ting Kuo
2021-10-26  6:10   ` Paul Menzel
2021-10-26  6:10     ` Paul Menzel
2021-10-26  6:10     ` Paul Menzel
2021-10-26  6:10     ` Paul Menzel
2021-11-26  2:27     ` Chin-Ting Kuo
2021-11-26  2:27       ` Chin-Ting Kuo
2021-11-26  2:27       ` Chin-Ting Kuo
2021-11-26  2:27       ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 02/10] sdhci: aspeed: Add SDR50 support Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-10-26  0:31   ` Andrew Jeffery
2021-10-26  0:31     ` Andrew Jeffery
2021-10-26  0:31     ` Andrew Jeffery
2021-11-06 10:01     ` Chin-Ting Kuo
2021-11-06 10:01       ` Chin-Ting Kuo
2021-11-06 10:01       ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 03/10] dts: aspeed: ast2600: Support SDR50 for SD device Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-10-26  0:42   ` Andrew Jeffery
2021-10-26  0:42     ` Andrew Jeffery
2021-10-26  0:42     ` Andrew Jeffery
2021-11-06 10:01     ` Chin-Ting Kuo
2021-11-06 10:01       ` Chin-Ting Kuo
2021-11-06 10:01       ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 04/10] mmc: Add invert flag for clock phase signedness Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-10-26  0:52   ` Andrew Jeffery
2021-10-26  0:52     ` Andrew Jeffery
2021-10-26  0:52     ` Andrew Jeffery
2021-11-06 10:02     ` Chin-Ting Kuo
2021-11-06 10:02       ` Chin-Ting Kuo
2021-11-06 10:02       ` Chin-Ting Kuo
2021-11-08  0:21       ` Andrew Jeffery
2021-11-08  0:21         ` Andrew Jeffery
2021-11-08  0:21         ` Andrew Jeffery
2021-11-08  0:21         ` Andrew Jeffery
2021-09-22 10:31 ` [PATCH 05/10] mmc: aspeed: Adjust delay taps calculation method Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-10-26  3:10   ` Andrew Jeffery
2021-10-26  3:10     ` Andrew Jeffery
2021-10-26  3:10     ` Andrew Jeffery
2021-11-06 10:05     ` Chin-Ting Kuo
2021-11-06 10:05       ` Chin-Ting Kuo
2021-11-06 10:05       ` Chin-Ting Kuo
2021-11-07 23:42       ` Andrew Jeffery
2021-11-07 23:42         ` Andrew Jeffery
2021-11-07 23:42         ` Andrew Jeffery
2021-09-22 10:31 ` [PATCH 06/10] arm: dts: aspeed: Change eMMC device compatible Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 07/10] arm: dts: aspeed: Adjust clock phase parameter Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 08/10] arm: dts: ibm: " Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 09/10] dt-bindings: mmc: aspeed: Add max-tap-delay property Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-27 18:40   ` Rob Herring
2021-09-27 18:40     ` Rob Herring
2021-09-27 18:40     ` Rob Herring
2021-09-27 18:40     ` Rob Herring
2021-09-28  2:50     ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-22 10:31 ` [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-22 10:31   ` Chin-Ting Kuo
2021-09-27 18:59   ` Rob Herring [this message]
2021-09-27 18:59     ` Rob Herring
2021-09-27 18:59     ` Rob Herring
2021-09-27 18:59     ` Rob Herring
2021-09-28  2:50     ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-28  2:50       ` Chin-Ting Kuo
2021-09-28 22:28       ` Rob Herring
2021-09-28 22:28         ` Rob Herring
2021-09-28 22:28         ` Rob Herring
2021-09-28 22:28         ` Rob Herring
2021-09-29  3:03         ` Chin-Ting Kuo
2021-09-29  3:03           ` Chin-Ting Kuo
2021-09-29  3:03           ` Chin-Ting Kuo
2021-09-29  3:03           ` Chin-Ting Kuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVIUf7/4ukMcrOb9@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.