From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Andrew Jones <drjones@redhat.com>,
Laurent Vivier <laurent@vivier.eu>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH v2 1/2] qemu-options: Tweak [,maxcpus=cpus] to [,maxcpus=maxcpus]
Date: Tue, 28 Sep 2021 13:28:45 +0100 [thread overview]
Message-ID: <YVMKffLI2bbJkQ7w@redhat.com> (raw)
In-Reply-To: <20210928121134.21064-2-wangyanan55@huawei.com>
On Tue, Sep 28, 2021 at 08:11:33PM +0800, Yanan Wang wrote:
> In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the
> DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part.
> Obviously the later is right, let's fix the previous one.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: qemu-trivial@nongnu.org, wanghaibin.wang@huawei.com,
Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 1/2] qemu-options: Tweak [,maxcpus=cpus] to [,maxcpus=maxcpus]
Date: Tue, 28 Sep 2021 13:28:45 +0100 [thread overview]
Message-ID: <YVMKffLI2bbJkQ7w@redhat.com> (raw)
In-Reply-To: <20210928121134.21064-2-wangyanan55@huawei.com>
On Tue, Sep 28, 2021 at 08:11:33PM +0800, Yanan Wang wrote:
> In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the
> DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part.
> Obviously the later is right, let's fix the previous one.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-09-28 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 12:11 [PATCH v2 0/2] qemu-options: Trivial doc fixes related to -smp Yanan Wang
2021-09-28 12:11 ` Yanan Wang
2021-09-28 12:11 ` [PATCH v2 1/2] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] Yanan Wang
2021-09-28 12:11 ` Yanan Wang
2021-09-28 12:28 ` Daniel P. Berrangé [this message]
2021-09-28 12:28 ` [PATCH v2 1/2] qemu-options: Tweak [,maxcpus=cpus] to [,maxcpus=maxcpus] Daniel P. Berrangé
2021-09-29 14:38 ` Andrew Jones
2021-09-29 14:38 ` Andrew Jones
2021-09-29 14:55 ` [PATCH v2 1/2] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] Laurent Vivier
2021-09-28 12:11 ` [PATCH v2 2/2] qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2" Yanan Wang
2021-09-28 12:11 ` Yanan Wang
2021-09-28 12:28 ` [PATCH v2 2/2] qemu-options: Add missing "sockets=2,maxcpus=2" " Daniel P. Berrangé
2021-09-28 12:28 ` Daniel P. Berrangé
2021-09-29 14:38 ` Andrew Jones
2021-09-29 14:38 ` Andrew Jones
2021-09-29 14:55 ` [PATCH v2 2/2] qemu-options: Add missing "sockets=2, maxcpus=2" " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVMKffLI2bbJkQ7w@redhat.com \
--to=berrange@redhat.com \
--cc=drjones@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.