From: David Brazdil <dbrazdil@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, kernel-team@android.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line
Date: Tue, 28 Sep 2021 14:58:08 +0000 [thread overview]
Message-ID: <YVMtgBw+qG713+4k@google.com> (raw)
In-Reply-To: <20210903091652.985836-1-maz@kernel.org>
Hey Marc,
that all makes sense:
Reviewed-by: David Brazdil <dbrazdil@google.com>
> @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg)
> return 0;
> }
>
> - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode()))
> + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
> + kvm_mode = KVM_MODE_DEFAULT;
> return 0;
> + }
> +
> + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for
protected it is checked in is_kvm_protected_mode. May be worth unifying?
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: David Brazdil <dbrazdil@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, ascull@google.com,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
kernel-team@android.com
Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line
Date: Tue, 28 Sep 2021 14:58:08 +0000 [thread overview]
Message-ID: <YVMtgBw+qG713+4k@google.com> (raw)
In-Reply-To: <20210903091652.985836-1-maz@kernel.org>
Hey Marc,
that all makes sense:
Reviewed-by: David Brazdil <dbrazdil@google.com>
> @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg)
> return 0;
> }
>
> - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode()))
> + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
> + kvm_mode = KVM_MODE_DEFAULT;
> return 0;
> + }
> +
> + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for
protected it is checked in is_kvm_protected_mode. May be worth unifying?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: David Brazdil <dbrazdil@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, ascull@google.com,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
kernel-team@android.com
Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line
Date: Tue, 28 Sep 2021 14:58:08 +0000 [thread overview]
Message-ID: <YVMtgBw+qG713+4k@google.com> (raw)
In-Reply-To: <20210903091652.985836-1-maz@kernel.org>
Hey Marc,
that all makes sense:
Reviewed-by: David Brazdil <dbrazdil@google.com>
> @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg)
> return 0;
> }
>
> - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode()))
> + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
> + kvm_mode = KVM_MODE_DEFAULT;
> return 0;
> + }
> +
> + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) {
nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for
protected it is checked in is_kvm_protected_mode. May be worth unifying?
next prev parent reply other threads:[~2021-09-28 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 9:16 [PATCH] KVM: arm64: Allow KVM to be disabled from the command line Marc Zyngier
2021-09-03 9:16 ` Marc Zyngier
2021-09-03 9:16 ` Marc Zyngier
2021-09-28 14:58 ` David Brazdil [this message]
2021-09-28 14:58 ` David Brazdil
2021-09-28 14:58 ` David Brazdil
2021-09-30 10:22 ` Marc Zyngier
2021-09-30 10:22 ` Marc Zyngier
2021-09-30 10:22 ` Marc Zyngier
2021-09-29 10:28 ` Will Deacon
2021-09-29 10:28 ` Will Deacon
2021-09-29 10:28 ` Will Deacon
2021-09-29 10:35 ` Suzuki K Poulose
2021-09-29 10:35 ` Suzuki K Poulose
2021-09-29 10:35 ` Suzuki K Poulose
2021-09-30 10:29 ` Marc Zyngier
2021-09-30 10:29 ` Marc Zyngier
2021-09-30 10:29 ` Marc Zyngier
2021-10-01 9:27 ` Suzuki K Poulose
2021-10-01 9:27 ` Suzuki K Poulose
2021-10-01 9:27 ` Suzuki K Poulose
2021-10-01 14:54 ` Marc Zyngier
2021-10-01 14:54 ` Marc Zyngier
2021-10-01 14:54 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVMtgBw+qG713+4k@google.com \
--to=dbrazdil@google.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.