From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-block@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-scsi@vger.kernel.org
Subject: Re: remove ->rq_disk
Date: Wed, 29 Sep 2021 16:04:25 +0800 [thread overview]
Message-ID: <YVQeCdF/kT46pkC5@T590> (raw)
In-Reply-To: <20210929070733.GA31869@lst.de>
On Wed, Sep 29, 2021 at 09:07:33AM +0200, Christoph Hellwig wrote:
> On Tue, Sep 28, 2021 at 10:32:51PM +0800, Ming Lei wrote:
> > Hello Christoph,
> >
> > On Tue, Sep 28, 2021 at 07:22:06AM +0200, Christoph Hellwig wrote:
> > > Hi Jens,
> > >
> > > this series removes the rq_disk field in struct request, which isn't
> > > needed now that we can get the disk from the request_queue.
> >
> > Can we hold on this series until q->disk becomes really reliable[1][2]?
>
> It's not like q->disk isn't reliable. It is that we don't kill all bios
q->disk will be cleaned in gendisk's release handler, which may happen before
or after blk_cleanup_queue().
> when tearing down the gendisk, which is an old problem that got worse.
It is fine to not kill all bios when tearing down gendisk if BDI isn't
retrieved from q->disk->bdi since gendisk has same lifetime with bdev.
So what is the old problem?
> That being said I'm resending this again.
No, either your patch or mine can't fix the issue, and I will comment on
your resending.
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-block@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-scsi@vger.kernel.org
Subject: Re: remove ->rq_disk
Date: Wed, 29 Sep 2021 16:04:25 +0800 [thread overview]
Message-ID: <YVQeCdF/kT46pkC5@T590> (raw)
In-Reply-To: <20210929070733.GA31869@lst.de>
On Wed, Sep 29, 2021 at 09:07:33AM +0200, Christoph Hellwig wrote:
> On Tue, Sep 28, 2021 at 10:32:51PM +0800, Ming Lei wrote:
> > Hello Christoph,
> >
> > On Tue, Sep 28, 2021 at 07:22:06AM +0200, Christoph Hellwig wrote:
> > > Hi Jens,
> > >
> > > this series removes the rq_disk field in struct request, which isn't
> > > needed now that we can get the disk from the request_queue.
> >
> > Can we hold on this series until q->disk becomes really reliable[1][2]?
>
> It's not like q->disk isn't reliable. It is that we don't kill all bios
q->disk will be cleaned in gendisk's release handler, which may happen before
or after blk_cleanup_queue().
> when tearing down the gendisk, which is an old problem that got worse.
It is fine to not kill all bios when tearing down gendisk if BDI isn't
retrieved from q->disk->bdi since gendisk has same lifetime with bdev.
So what is the old problem?
> That being said I'm resending this again.
No, either your patch or mine can't fix the issue, and I will comment on
your resending.
Thanks,
Ming
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-09-29 8:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 5:22 remove ->rq_disk Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 5:22 ` [PATCH 1/5] mtd_blkdevs: remove the sector out of range check in do_blktrans_request Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 8:51 ` Miquel Raynal
2021-09-28 8:51 ` Miquel Raynal
2021-09-28 5:22 ` [PATCH 2/5] block: don't check ->rq_disk in merges Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 5:22 ` [PATCH 3/5] block: remove the ->rq_disk field in struct request Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 21:11 ` Chaitanya Kulkarni
2021-09-28 21:11 ` Chaitanya Kulkarni
2021-09-28 21:21 ` Chaitanya Kulkarni
2021-09-28 21:21 ` Chaitanya Kulkarni
2021-09-28 21:22 ` Chaitanya Kulkarni
2021-09-28 21:22 ` Chaitanya Kulkarni
2021-09-28 5:22 ` [PATCH 4/5] block: remove the gendisk argument to blk_execute_rq Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 21:23 ` Chaitanya Kulkarni
2021-09-28 21:23 ` Chaitanya Kulkarni
2021-09-28 5:22 ` [PATCH 5/5] scsi: remove the gendisk argument to scsi_ioctl Christoph Hellwig
2021-09-28 5:22 ` Christoph Hellwig
2021-09-28 21:24 ` Chaitanya Kulkarni
2021-09-28 21:24 ` Chaitanya Kulkarni
2021-09-28 14:32 ` remove ->rq_disk Ming Lei
2021-09-28 14:32 ` Ming Lei
2021-09-29 7:07 ` Christoph Hellwig
2021-09-29 7:07 ` Christoph Hellwig
2021-09-29 8:04 ` Ming Lei [this message]
2021-09-29 8:04 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVQeCdF/kT46pkC5@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.