From: Leon Romanovsky <leon@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 3/5] devlink: Allow set specific ops callbacks dynamically
Date: Wed, 29 Sep 2021 13:43:06 +0300 [thread overview]
Message-ID: <YVRDOijPHji2vg82@unreal> (raw)
In-Reply-To: <20210929103823.GK2048@kadam>
On Wed, Sep 29, 2021 at 01:38:23PM +0300, Dan Carpenter wrote:
> On Wed, Sep 29, 2021 at 01:16:37PM +0300, Leon Romanovsky wrote:
> > +void devlink_set_ops(struct devlink *devlink, struct devlink_ops *ops)
> > +{
> > + struct devlink_ops *dev_ops = devlink->ops;
> > +
> > + WARN_ON(!devlink_reload_actions_valid(ops));
> > +
> > +#define SET_DEVICE_OP(ptr, name) \
> > + do { \
> > + if (ops->name) \
>
> Could you make "ops" a parameter of the macro instead of hard coding it?
Sure
>
> regards,
> dan carpenter
>
> > + if (!((ptr)->name)) \
> > + (ptr)->name = ops->name; \
> > + } while (0)
> > +
> > + /* Keep sorted */
> > + SET_DEVICE_OP(dev_ops, reload_actions);
> > + SET_DEVICE_OP(dev_ops, reload_down);
> > + SET_DEVICE_OP(dev_ops, reload_limits);
> > + SET_DEVICE_OP(dev_ops, reload_up);
> > +
> > +#undef SET_DEVICE_OP
> > +}
> > +EXPORT_SYMBOL_GPL(devlink_set_ops);
>
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Ariel Elior <aelior@marvell.com>,
Bin Luo <luobin9@huawei.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Coiby Xu <coiby.xu@gmail.com>,
Derek Chickles <dchickles@marvell.com>,
drivers@pensando.io, Eric Dumazet <eric.dumazet@gmail.com>,
Felix Manlunas <fmanlunas@marvell.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Geetha sowjanya <gakula@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com,
hariprasad <hkelam@marvell.com>, Ido Schimmel <idosch@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jerin Jacob <jerinj@marvell.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@nvidia.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Linu Cherian <lcherian@marvell.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
Manish Chopra <manishc@marvell.com>,
Michael Chan <michael.chan@broadcom.com>,
Moshe Shemesh <moshe@nvidia.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Richard Cochran <richardcochran@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Salil Mehta <salil.mehta@huawei.com>,
Satanand Burla <sburla@marvell.com>,
Shannon Nelson <snelson@pensando.io>,
Shay Drory <shayd@nvidia.com>,
Simon Horman <simon.horman@corigine.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Tariq Toukan <tariqt@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>
Subject: Re: [PATCH net-next 3/5] devlink: Allow set specific ops callbacks dynamically
Date: Wed, 29 Sep 2021 13:43:06 +0300 [thread overview]
Message-ID: <YVRDOijPHji2vg82@unreal> (raw)
In-Reply-To: <20210929103823.GK2048@kadam>
On Wed, Sep 29, 2021 at 01:38:23PM +0300, Dan Carpenter wrote:
> On Wed, Sep 29, 2021 at 01:16:37PM +0300, Leon Romanovsky wrote:
> > +void devlink_set_ops(struct devlink *devlink, struct devlink_ops *ops)
> > +{
> > + struct devlink_ops *dev_ops = devlink->ops;
> > +
> > + WARN_ON(!devlink_reload_actions_valid(ops));
> > +
> > +#define SET_DEVICE_OP(ptr, name) \
> > + do { \
> > + if (ops->name) \
>
> Could you make "ops" a parameter of the macro instead of hard coding it?
Sure
>
> regards,
> dan carpenter
>
> > + if (!((ptr)->name)) \
> > + (ptr)->name = ops->name; \
> > + } while (0)
> > +
> > + /* Keep sorted */
> > + SET_DEVICE_OP(dev_ops, reload_actions);
> > + SET_DEVICE_OP(dev_ops, reload_down);
> > + SET_DEVICE_OP(dev_ops, reload_limits);
> > + SET_DEVICE_OP(dev_ops, reload_up);
> > +
> > +#undef SET_DEVICE_OP
> > +}
> > +EXPORT_SYMBOL_GPL(devlink_set_ops);
>
next prev parent reply other threads:[~2021-09-29 10:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 10:16 [Intel-wired-lan] [PATCH net-next 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:16 ` [Intel-wired-lan] [PATCH net-next 1/5] devlink: Add missed notifications iterators Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:16 ` [Intel-wired-lan] [PATCH net-next 2/5] devlink: Allow modification of devlink ops Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:20 ` [Intel-wired-lan] " Simon Horman
2021-09-29 10:20 ` Simon Horman
2021-09-29 10:16 ` [Intel-wired-lan] [PATCH net-next 3/5] devlink: Allow set specific ops callbacks dynamically Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:38 ` [Intel-wired-lan] " Dan Carpenter
2021-09-29 10:38 ` Dan Carpenter
2021-09-29 10:43 ` Leon Romanovsky [this message]
2021-09-29 10:43 ` Leon Romanovsky
2021-09-29 10:16 ` [Intel-wired-lan] [PATCH net-next 4/5] net/mlx5: Register separate reload devlink ops for multiport device Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:16 ` [Intel-wired-lan] [PATCH net-next 5/5] devlink: Delete reload enable/disable interface Leon Romanovsky
2021-09-29 10:16 ` Leon Romanovsky
2021-09-29 10:40 ` [Intel-wired-lan] [PATCH net-next 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 10:40 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVRDOijPHji2vg82@unreal \
--to=leon@kernel.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.