All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: devicetree@vger.kernel.org,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Stephen Boyd" <sboyd@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	linux-serial@vger.kernel.org, "Marek Behún" <kabel@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Vladimir Vid" <vladimir.vid@sartura.hr>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Michael Turquette" <mturquette@baylibre.com>
Subject: Re: [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
Date: Wed, 29 Sep 2021 16:30:06 -0500	[thread overview]
Message-ID: <YVTa3pt279D/qWz6@robh.at.kernel.org> (raw)
In-Reply-To: <20210929140132.gom6qiohucsczoxq@pali>

On Wed, Sep 29, 2021 at 04:01:32PM +0200, Pali Rohár wrote:
> On Wednesday 29 September 2021 08:46:25 Rob Herring wrote:
> > On Wed, 29 Sep 2021 10:20:31 +0200, Pali Rohár wrote:
> > > This change adds DT bindings documentation for device nodes with compatible
> > > string "marvell,armada-3700-uart-clock".
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > 
> > > ---
> > > Changes in v6
> > > * Fix license
> > > * Rename node to clock-controller@12010
> > > * Remove maxItems
> > > ---
> > >  .../bindings/clock/armada3700-uart-clock.yaml | 56 +++++++++++++++++++
> > >  1 file changed, 56 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: 'http://devicetree.org/schemas/clock/marvell,armada-3700-uart-clock#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
> > 	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: 'maintainers' is a required property
> > 	hint: Metaschema for devicetree binding documentation
> > 	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: relative path/filename doesn't match actual path or filename
> > 	expected: http://devicetree.org/schemas/clock/armada3700-uart-clock.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: ignoring, error in schema: $id
> > warning: no schema found in file: ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > Documentation/devicetree/bindings/clock/armada3700-uart-clock.example.dt.yaml:0:0: /example-0/clock-controller@12010: failed to match any schema with compatible: ['marvell,armada-3700-uart-clock']
> 
> Hello! What does this error mean?
> 
> Should I add .yaml suffix into '$id: ' line and rename file via?
> git mv Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml

Yes. They need to match.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: devicetree@vger.kernel.org,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Stephen Boyd" <sboyd@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	linux-serial@vger.kernel.org, "Marek Behún" <kabel@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Vladimir Vid" <vladimir.vid@sartura.hr>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Michael Turquette" <mturquette@baylibre.com>
Subject: Re: [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
Date: Wed, 29 Sep 2021 16:30:06 -0500	[thread overview]
Message-ID: <YVTa3pt279D/qWz6@robh.at.kernel.org> (raw)
In-Reply-To: <20210929140132.gom6qiohucsczoxq@pali>

On Wed, Sep 29, 2021 at 04:01:32PM +0200, Pali Rohár wrote:
> On Wednesday 29 September 2021 08:46:25 Rob Herring wrote:
> > On Wed, 29 Sep 2021 10:20:31 +0200, Pali Rohár wrote:
> > > This change adds DT bindings documentation for device nodes with compatible
> > > string "marvell,armada-3700-uart-clock".
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > 
> > > ---
> > > Changes in v6
> > > * Fix license
> > > * Rename node to clock-controller@12010
> > > * Remove maxItems
> > > ---
> > >  .../bindings/clock/armada3700-uart-clock.yaml | 56 +++++++++++++++++++
> > >  1 file changed, 56 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: 'http://devicetree.org/schemas/clock/marvell,armada-3700-uart-clock#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
> > 	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: 'maintainers' is a required property
> > 	hint: Metaschema for devicetree binding documentation
> > 	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: relative path/filename doesn't match actual path or filename
> > 	expected: http://devicetree.org/schemas/clock/armada3700-uart-clock.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: ignoring, error in schema: $id
> > warning: no schema found in file: ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > Documentation/devicetree/bindings/clock/armada3700-uart-clock.example.dt.yaml:0:0: /example-0/clock-controller@12010: failed to match any schema with compatible: ['marvell,armada-3700-uart-clock']
> 
> Hello! What does this error mean?
> 
> Should I add .yaml suffix into '$id: ' line and rename file via?
> git mv Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml

Yes. They need to match.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-29 21:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  8:20 [PATCH v6 0/6] serial: mvebu-uart: Support for higher baudrates Pali Rohár
2021-09-29  8:20 ` Pali Rohár
2021-09-29  8:20 ` [PATCH v6 1/6] math64: New DIV_U64_ROUND_CLOSEST helper Pali Rohár
2021-09-29  8:20   ` Pali Rohár
2021-09-29  8:20 ` [PATCH v6 2/6] serial: mvebu-uart: implement UART clock driver for configuring UART base clock Pali Rohár
2021-09-29  8:20   ` Pali Rohár
2021-09-29  8:20 ` [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-09-29  8:20   ` [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Pali Rohár
2021-09-29 13:46   ` [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Rob Herring
2021-09-29 13:46     ` [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Rob Herring
2021-09-29 14:01     ` [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-09-29 14:01       ` Pali Rohár
2021-09-29 21:30       ` Rob Herring [this message]
2021-09-29 21:30         ` Rob Herring
2021-09-29  8:20 ` [PATCH v6 4/6] dt-bindings: mvebu-uart: update information about UART clock Pali Rohár
2021-09-29  8:20   ` Pali Rohár
2021-09-29  8:20 ` [PATCH v6 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it Pali Rohár
2021-09-29  8:20   ` Pali Rohár
2021-09-29  8:20 ` [PATCH v6 6/6] serial: mvebu-uart: implement support for baudrates higher than 230400 Pali Rohár
2021-09-29  8:20   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVTa3pt279D/qWz6@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@bootlin.com \
    --cc=kabel@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pali@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=vladimir.vid@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.