From: Greg KH <gregkh@linuxfoundation.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: lee.jones@linaro.org, hdegoede@redhat.com,
mgross@linux.intel.com, bhelgaas@google.com,
andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 5/5] platform/x86: Add Intel Software Defined Silicon driver
Date: Fri, 1 Oct 2021 13:27:23 +0200 [thread overview]
Message-ID: <YVbwmxTVE9dRqB3r@kroah.com> (raw)
In-Reply-To: <b3602f18c657765c604531430052efc62f85e83b.camel@linux.intel.com>
On Fri, Oct 01, 2021 at 03:47:23AM -0700, David E. Box wrote:
> On Fri, 2021-10-01 at 09:16 +0200, Greg KH wrote:
> > On Thu, Sep 30, 2021 at 06:28:15PM -0700, David E. Box wrote:
> > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism for
> > > activating additional silicon features. Features are enabled through a
> > > license activation process. The SDSi driver provides a per socket, ioctl
> > > interface for applications to perform 3 main provisioning functions:
> > >
> > > 1. Provision an Authentication Key Certificate (AKC), a key written to
> > > internal NVRAM that is used to authenticate a capability specific
> > > activation payload.
> > >
> > > 2. Provision a Capability Activation Payload (CAP), a token authenticated
> > > using the AKC and applied to the CPU configuration to activate a new
> > > feature.
> > >
> > > 3. Read the SDSi State Certificate, containing the CPU configuration
> > > state.
> > >
> > > The ioctl operations perform function specific mailbox commands that
> > > forward the requests to SDSi hardware to perform authentication of the
> > > payloads and enable the silicon configuration (to be made available after
> > > power cycling).
> > >
> > > The SDSi device itself is enumerated as an auxiliary device from the
> > > intel_extended_caps driver and as such has a build dependency on
> > > CONFIG_INTEL_EXTENDED_CAPS.
> > >
> > > Link: https://github.com/intel/intel-sdsi
> > > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> >
> > I do not see the "required" review that Intel developers need when
> > sending stuff to me. What happened here?
>
> Ah. You were added because of the doc change. Normally, the changes to the driver wouldn't have gone
> through you. So it's just a miss on that. But it been through internal review.
Then where is the "reviewed-by:" line that shows this happened?
next prev parent reply other threads:[~2021-10-01 11:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 1:28 [PATCH 0/5] Move intel_pm from MFD to Auxiliary bus David E. Box
2021-10-01 1:28 ` [PATCH 1/5] PCI: Add #defines for accessing PCIe DVSEC fields David E. Box
2021-10-01 1:28 ` [PATCH 2/5] platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus David E. Box
2021-10-06 8:58 ` Leon Romanovsky
2021-10-06 20:58 ` David E. Box
2021-10-10 6:59 ` Leon Romanovsky
2021-11-14 1:56 ` kernel test robot
2021-11-14 1:56 ` kernel test robot
2021-10-01 1:28 ` [PATCH 3/5] platform/x86/intel: extended_caps: Add support for PCIe VSEC structures David E. Box
2021-10-01 1:28 ` [PATCH 4/5] Documentation: Update ioctl-number.rst for Intel Software Defined Silicon interface David E. Box
2021-10-01 1:28 ` [PATCH 5/5] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2021-10-01 7:14 ` Greg KH
2021-10-01 10:38 ` David E. Box
2021-10-01 11:29 ` Greg KH
2021-10-01 7:15 ` Greg KH
2021-10-01 7:16 ` Greg KH
2021-10-01 10:47 ` David E. Box
2021-10-01 11:27 ` Greg KH [this message]
2021-10-01 7:29 ` Greg KH
2021-10-01 11:13 ` David E. Box
2021-10-01 11:26 ` Greg KH
2021-10-01 20:43 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVbwmxTVE9dRqB3r@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.