* [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
@ 2021-10-01 17:15 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-10-01 17:15 UTC (permalink / raw)
To: linux-mtd, linux-kernel
Cc: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Andy Shevchenko
Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
Add Ice Lake-N PCI ID to the driver list of supported devices.
The device can be found on MacBookPro16,2 [1].
[1]: https://linux-hardware.org/?probe=f1c5cf0c43
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mtd/spi-nor/controllers/intel-spi-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
index 1bc53b8bb88a..f9bcd2dabb4f 100644
--- a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
@@ -70,6 +70,7 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x1bca), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x38a4), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x43a4), (unsigned long)&cnl_info },
{ PCI_VDEVICE(INTEL, 0x4b24), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x4da4), (unsigned long)&bxt_info },
--
2.33.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
@ 2021-10-01 17:15 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-10-01 17:15 UTC (permalink / raw)
To: linux-mtd, linux-kernel
Cc: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Andy Shevchenko
Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
Add Ice Lake-N PCI ID to the driver list of supported devices.
The device can be found on MacBookPro16,2 [1].
[1]: https://linux-hardware.org/?probe=f1c5cf0c43
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mtd/spi-nor/controllers/intel-spi-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
index 1bc53b8bb88a..f9bcd2dabb4f 100644
--- a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
@@ -70,6 +70,7 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x1bca), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x38a4), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x43a4), (unsigned long)&cnl_info },
{ PCI_VDEVICE(INTEL, 0x4b24), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x4da4), (unsigned long)&bxt_info },
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
2021-10-01 17:15 ` Andy Shevchenko
@ 2021-10-01 17:21 ` Michael Walle
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2021-10-01 17:21 UTC (permalink / raw)
To: Andy Shevchenko, linux-mtd, linux-kernel
Cc: Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
>Add Ice Lake-N PCI ID to the driver list of supported devices.
>
>The device can be found on MacBookPro16,2 [1].
>
>[1]: https://linux-hardware.org/?probe=f1c5cf0c43
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Andy,
there is currently a rewrite of this driver (to use spi-mem)
in progress:
https://lore.kernel.org/linux-mtd/20210930100719.2176-1-mika.westerberg@linux.intel.com/
Could you try that series with your hardware?
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
@ 2021-10-01 17:21 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2021-10-01 17:21 UTC (permalink / raw)
To: Andy Shevchenko, linux-mtd, linux-kernel
Cc: Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
>Add Ice Lake-N PCI ID to the driver list of supported devices.
>
>The device can be found on MacBookPro16,2 [1].
>
>[1]: https://linux-hardware.org/?probe=f1c5cf0c43
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Andy,
there is currently a rewrite of this driver (to use spi-mem)
in progress:
https://lore.kernel.org/linux-mtd/20210930100719.2176-1-mika.westerberg@linux.intel.com/
Could you try that series with your hardware?
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
2021-10-01 17:21 ` Michael Walle
@ 2021-10-01 19:36 ` Andy Shevchenko
-1 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-10-01 19:36 UTC (permalink / raw)
To: Michael Walle
Cc: linux-mtd, linux-kernel, Tudor Ambarus, Pratyush Yadav,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
On Fri, Oct 01, 2021 at 07:21:08PM +0200, Michael Walle wrote:
> Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> >Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
> >Add Ice Lake-N PCI ID to the driver list of supported devices.
> >
> >The device can be found on MacBookPro16,2 [1].
> >
> >[1]: https://linux-hardware.org/?probe=f1c5cf0c43
> >
> >Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Hi Andy,
>
> there is currently a rewrite of this driver (to use spi-mem)
> in progress:
>
> https://lore.kernel.org/linux-mtd/20210930100719.2176-1-mika.westerberg@linux.intel.com/
>
> Could you try that series with your hardware?
It's not mine - can't test myself. I'm helping to enable Linux on it.
But okay, I postpone this till the reworked version will be applied.
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash
@ 2021-10-01 19:36 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-10-01 19:36 UTC (permalink / raw)
To: Michael Walle
Cc: linux-mtd, linux-kernel, Tudor Ambarus, Pratyush Yadav,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
On Fri, Oct 01, 2021 at 07:21:08PM +0200, Michael Walle wrote:
> Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> >Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
> >Add Ice Lake-N PCI ID to the driver list of supported devices.
> >
> >The device can be found on MacBookPro16,2 [1].
> >
> >[1]: https://linux-hardware.org/?probe=f1c5cf0c43
> >
> >Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Hi Andy,
>
> there is currently a rewrite of this driver (to use spi-mem)
> in progress:
>
> https://lore.kernel.org/linux-mtd/20210930100719.2176-1-mika.westerberg@linux.intel.com/
>
> Could you try that series with your hardware?
It's not mine - can't test myself. I'm helping to enable Linux on it.
But okay, I postpone this till the reworked version will be applied.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-01 19:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-01 17:15 [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash Andy Shevchenko
2021-10-01 17:15 ` Andy Shevchenko
2021-10-01 17:21 ` Michael Walle
2021-10-01 17:21 ` Michael Walle
2021-10-01 19:36 ` Andy Shevchenko
2021-10-01 19:36 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.